Migrate TestCoreSearchUpdateIndexDelay from test_core.py to core_test.go

Author: MatteoPologruto

internal/integrationtest/core/core_test.go

@@ -19,11 +19,13 @@ import (
 	"crypto/md5"
 	"encoding/hex"
 	"fmt"
+	"os"
 	"runtime"
 	"sort"
 	"strconv"
 	"strings"
 	"testing"
+	"time"
 
 	"github.com/arduino/arduino-cli/internal/integrationtest"
 	"github.com/arduino/go-paths-helper"
@@ -598,6 +600,31 @@ func TestCoreListWithInstalledJson(t *testing.T) {
 	]`)
 }
 
+func TestCoreSearchUpdateIndexDelay(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	// Verifies index update is not run
+	stdout, _, err := cli.Run("core", "search")
+	require.NoError(t, err)
+	require.Contains(t, string(stdout), "Downloading index")
+
+	// Change edit time of package index file
+	indexFile := cli.DataDir().Join("package_index.json")
+	date := time.Now().Local().Add(time.Hour * (-25))
+	require.NoError(t, os.Chtimes(indexFile.String(), date, date))
+
+	// Verifies index update is run
+	stdout, _, err = cli.Run("core", "search")
+	require.NoError(t, err)
+	require.Contains(t, string(stdout), "Downloading index")
+
+	// Verifies index update is not run again
+	stdout, _, err = cli.Run("core", "search")
+	require.NoError(t, err)
+	require.NotContains(t, string(stdout), "Downloading index")
+}
+
 func TestCoreSearchSortedResults(t *testing.T) {
 	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
 	defer env.CleanUp()

test/test_core.py

@@ -47,31 +47,6 @@ def ordered(obj):
     assert ordered(installed_json) == ordered(expected_installed_json)
 
 
-def test_core_search_update_index_delay(run_command, data_dir):
-    assert run_command(["update"])
-
-    # Verifies index update is not run
-    res = run_command(["core", "search"])
-    assert res.ok
-    assert "Downloading index" not in res.stdout
-
-    # Change edit time of package index file
-    index_file = Path(data_dir, "package_index.json")
-    date = datetime.datetime.now() - datetime.timedelta(hours=25)
-    mod_time = time.mktime(date.timetuple())
-    os.utime(index_file, (mod_time, mod_time))
-
-    # Verifies index update is run
-    res = run_command(["core", "search"])
-    assert res.ok
-    assert "Downloading index" in res.stdout
-
-    # Verifies index update is not run again
-    res = run_command(["core", "search"])
-    assert res.ok
-    assert "Downloading index" not in res.stdout
-
-
 @pytest.mark.skipif(
     platform.system() in ["Darwin", "Windows"],
     reason="macOS by default is case insensitive https://github.com/actions/virtual-environments/issues/865 "