Migrate TestCompileSketchCaseMismatchFails from test_compile_part_3.py to compile_part_3_test.go

A new function that sets the working directory to a specific path has been added in order to run all the tests as intended.

Author: MatteoPologruto

internal/integrationtest/arduino-cli.go

@@ -146,6 +146,11 @@ func (cli *ArduinoCLI) DownloadDir() *paths.Path {
 	return cli.stagingDir
 }
 
+// SetWorkingDir sets a new working directory
+func (cli *ArduinoCLI) SetWorkingDir(p *paths.Path) {
+	cli.workingDir = p
+}
+
 // CopySketch copies a sketch inside the testing environment and returns its path
 func (cli *ArduinoCLI) CopySketch(sketchName string) *paths.Path {
 	p, err := paths.Getwd()

internal/integrationtest/compile/compile_part_3_test.go

@@ -16,6 +16,7 @@
 package compile_part_1_test
 
 import (
+	"strings"
 	"testing"
 
 	"github.com/arduino/arduino-cli/internal/integrationtest"
@@ -101,3 +102,44 @@ func TestCompileSketchWithMultipleMainFiles(t *testing.T) {
 	require.Error(t, err)
 	require.Contains(t, string(stderr), "Error opening sketch: multiple main sketch files found")
 }
+
+func TestCompileSketchCaseMismatchFails(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	// Init the environment explicitly
+	_, _, err := cli.Run("update")
+	require.NoError(t, err)
+
+	// Install core to compile
+	_, _, err = cli.Run("core", "install", "arduino:avr@1.8.3")
+	require.NoError(t, err)
+
+	sketchName := "CompileSketchCaseMismatch"
+	sketchPath := cli.SketchbookDir().Join(sketchName)
+	fqbn := "arduino:avr:uno"
+
+	_, _, err = cli.Run("sketch", "new", sketchPath.String())
+	require.NoError(t, err)
+
+	// Rename main .ino file so casing is different from sketch name
+	sketchFile := sketchPath.Join(sketchName + ".ino")
+	sketchMainFile := sketchPath.Join(strings.ToLower(sketchName) + ".ino")
+	err = sketchFile.Rename(sketchMainFile)
+	require.NoError(t, err)
+
+	// Verifies compilation fails when:
+	// * Compiling with sketch path
+	_, stderr, err := cli.Run("compile", "--clean", "-b", fqbn, sketchPath.String())
+	require.Error(t, err)
+	require.Contains(t, string(stderr), "Error opening sketch:")
+	// * Compiling with sketch main file
+	_, stderr, err = cli.Run("compile", "--clean", "-b", fqbn, sketchMainFile.String())
+	require.Error(t, err)
+	require.Contains(t, string(stderr), "Error opening sketch:")
+	// * Compiling in sketch path
+	cli.SetWorkingDir(sketchPath)
+	_, stderr, err = cli.Run("compile", "--clean", "-b", fqbn)
+	require.Error(t, err)
+	require.Contains(t, string(stderr), "Error opening sketch:")
+}

test/test_compile_part_3.py

@@ -39,37 +39,6 @@
 #    assert "Skipping dependencies detection for precompiled library Arduino_TensorFlowLite" in result.stdout
 
 
-def test_compile_sketch_case_mismatch_fails(run_command, data_dir):
-    # Init the environment explicitly
-    assert run_command(["update"])
-
-    # Install core to compile
-    assert run_command(["core", "install", "arduino:avr@1.8.3"])
-
-    sketch_name = "CompileSketchCaseMismatch"
-    sketch_path = Path(data_dir, sketch_name)
-    fqbn = "arduino:avr:uno"
-
-    assert run_command(["sketch", "new", sketch_path])
-
-    # Rename main .ino file so casing is different from sketch name
-    sketch_main_file = Path(sketch_path, f"{sketch_name}.ino").rename(sketch_path / f"{sketch_name.lower()}.ino")
-
-    # Verifies compilation fails when:
-    # * Compiling with sketch path
-    res = run_command(["compile", "--clean", "-b", fqbn, sketch_path])
-    assert res.failed
-    assert "Error opening sketch:" in res.stderr
-    # * Compiling with sketch main file
-    res = run_command(["compile", "--clean", "-b", fqbn, sketch_main_file])
-    assert res.failed
-    assert "Error opening sketch:" in res.stderr
-    # * Compiling in sketch path
-    res = run_command(["compile", "--clean", "-b", fqbn], custom_working_dir=sketch_path)
-    assert res.failed
-    assert "Error opening sketch:" in res.stderr
-
-
 def test_compile_with_only_compilation_database_flag(run_command, data_dir):
     assert run_command(["update"])