Migrated TestBoardListall from test_board.py to board_test.go

Author: MatteoPologruto

internal/integrationtest/board/board_test.go

@@ -64,3 +64,46 @@ func TestBoardListWithInvalidDiscovery(t *testing.T) {
 	require.NoError(t, err)
 	require.Contains(t, string(stderr), "builtin:serial-discovery")
 }
+
+func TestBoardListall(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("update")
+	require.NoError(t, err)
+	_, _, err = cli.Run("core", "install", "arduino:avr@1.8.3")
+	require.NoError(t, err)
+
+	stdout, _, err := cli.Run("board", "listall", "--format", "json")
+	require.NoError(t, err)
+
+	requirejson.Query(t, stdout, ".boards | length", "26")
+
+	requirejson.Contains(t, stdout, `{
+		"boards":[
+			{
+				"name": "Arduino Yún",
+				"fqbn": "arduino:avr:yun",
+				"platform": {
+					"id": "arduino:avr",
+					"installed": "1.8.3",
+					"name": "Arduino AVR Boards"
+				}
+			},
+			{
+				"name": "Arduino Uno",
+				"fqbn": "arduino:avr:uno",
+				"platform": {
+					"id": "arduino:avr",
+					"installed": "1.8.3",
+					"name": "Arduino AVR Boards"
+				}
+			}
+		]
+	}`)
+
+	// Check if the boards' "latest" value is not empty
+	requirejson.Parse(t, stdout).
+		Query(`[ .boards | .[] | .platform | select(.latest == "") ]`).
+		MustBeEmpty()
+}

test/test_board.py

@@ -394,31 +394,6 @@
 """  # noqa: E501
 
 
-def test_board_listall(run_command):
-    assert run_command(["update"])
-    assert run_command(["core", "install", "arduino:avr@1.8.3"])
-    res = run_command(["board", "listall", "--format", "json"])
-    assert res.ok
-    data = json.loads(res.stdout)
-    boards = {b["fqbn"]: b for b in data["boards"]}
-    assert len(boards) == 26
-    assert "arduino:avr:yun" in boards
-    assert "Arduino Yún" == boards["arduino:avr:yun"]["name"]
-    platform = boards["arduino:avr:yun"]["platform"]
-    assert "arduino:avr" == platform["id"]
-    assert "1.8.3" == platform["installed"]
-    assert "" != platform["latest"]
-    assert "Arduino AVR Boards" == platform["name"]
-
-    assert "arduino:avr:uno" in boards
-    assert "Arduino Uno" == boards["arduino:avr:uno"]["name"]
-    platform = boards["arduino:avr:uno"]["platform"]
-    assert "arduino:avr" == platform["id"]
-    assert "1.8.3" == platform["installed"]
-    assert "" != platform["latest"]
-    assert "Arduino AVR Boards" == platform["name"]
-
-
 def test_board_listall_with_manually_installed_platform(run_command, data_dir):
     assert run_command(["update"])