Made PackageManager.TempDir private

Author: cmaglie

arduino/cores/packagemanager/install_uninstall.go

@@ -39,7 +39,7 @@ func (pm *PackageManager) InstallPlatform(platformRelease *cores.PlatformRelease
 
 // InstallPlatformInDirectory installs a specific release of a platform in a specific directory.
 func (pm *PackageManager) InstallPlatformInDirectory(platformRelease *cores.PlatformRelease, destDir *paths.Path) error {
-	if err := platformRelease.Resource.Install(pm.DownloadDir, pm.TempDir, destDir); err != nil {
+	if err := platformRelease.Resource.Install(pm.DownloadDir, pm.tempDir, destDir); err != nil {
 		return errors.Errorf(tr("installing platform %[1]s: %[2]s"), platformRelease, err)
 	}
 	if d, err := destDir.Abs(); err == nil {
@@ -137,7 +137,7 @@ func (pm *PackageManager) InstallTool(toolRelease *cores.ToolRelease) error {
 		"tools",
 		toolRelease.Tool.Name,
 		toolRelease.Version.String())
-	return toolResource.Install(pm.DownloadDir, pm.TempDir, destDir)
+	return toolResource.Install(pm.DownloadDir, pm.tempDir, destDir)
 }
 
 // IsManagedToolRelease returns true if the ToolRelease is managed by the PackageManager

arduino/cores/packagemanager/package_manager.go

@@ -43,7 +43,7 @@ type PackageManager struct {
 	IndexDir               *paths.Path
 	PackagesDir            *paths.Path
 	DownloadDir            *paths.Path
-	TempDir                *paths.Path
+	tempDir                *paths.Path
 	CustomGlobalProperties *properties.Map
 	profile                *sketch.Profile
 	discoveryManager       *discoverymanager.DiscoveryManager
@@ -60,7 +60,7 @@ func NewPackageManager(indexDir, packagesDir, downloadDir, tempDir *paths.Path,
 		IndexDir:               indexDir,
 		PackagesDir:            packagesDir,
 		DownloadDir:            downloadDir,
-		TempDir:                tempDir,
+		tempDir:                tempDir,
 		CustomGlobalProperties: properties.NewMap(),
 		discoveryManager:       discoverymanager.New(),
 		userAgent:              userAgent,

arduino/cores/packagemanager/profiles.go

@@ -86,8 +86,8 @@ func (pm *PackageManager) loadProfilePlatform(platformRef *sketch.ProfilePlatfor
 
 func (pm *PackageManager) installMissingProfilePlatform(platformRef *sketch.ProfilePlatformReference, destDir *paths.Path, downloadCB rpc.DownloadProgressCB, taskCB rpc.TaskProgressCB) error {
 	// Instantiate a temporary package manager only for platform installation
-	_ = pm.TempDir.MkdirAll()
-	tmp, err := paths.MkTempDir(pm.TempDir.String(), "")
+	_ = pm.tempDir.MkdirAll()
+	tmp, err := paths.MkTempDir(pm.tempDir.String(), "")
 	if err != nil {
 		return fmt.Errorf("installing missing platform: could not create temp dir %s", err)
 	}