Migrate TestCompileSketchWithPdeExtension from test_compile_part_3.py to compile_part_3_test.go

Author: MatteoPologruto

internal/integrationtest/compile/compile_part_3_test.go

@@ -0,0 +1,61 @@
+// This file is part of arduino-cli.
+//
+// Copyright 2022 ARDUINO SA (http://www.arduino.cc/)
+//
+// This software is released under the GNU General Public License version 3,
+// which covers the main part of arduino-cli.
+// The terms of this license can be found at:
+// https://www.gnu.org/licenses/gpl-3.0.en.html
+//
+// You can be released from the requirements of the above licenses by purchasing
+// a commercial license. Buying such a license is mandatory if you want to
+// modify or otherwise use the software for commercial activities involving the
+// Arduino software without disclosing the source code of your own applications.
+// To purchase a commercial license, send an email to license@arduino.cc.
+
+package compile_part_1_test
+
+import (
+	"testing"
+
+	"github.com/arduino/arduino-cli/internal/integrationtest"
+	"github.com/stretchr/testify/require"
+)
+
+func TestCompileSketchWithPdeExtension(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	// Init the environment explicitly
+	_, _, err := cli.Run("update")
+	require.NoError(t, err)
+
+	// Install core to compile
+	_, _, err = cli.Run("core", "install", "arduino:avr@1.8.3")
+	require.NoError(t, err)
+
+	sketchName := "CompilePdeSketch"
+	sketchPath := cli.SketchbookDir().Join(sketchName)
+	fqbn := "arduino:avr:uno"
+
+	// Create a test sketch
+	_, _, err = cli.Run("sketch", "new", sketchPath.String())
+	require.NoError(t, err)
+
+	sketchFileIno := sketchPath.Join(sketchName + ".ino")
+	sketchFilePde := sketchPath.Join(sketchName + ".pde")
+	err = sketchFileIno.Rename(sketchFilePde)
+	require.NoError(t, err)
+
+	// Build sketch from folder
+	_, stderr, err := cli.Run("compile", "--clean", "-b", fqbn, sketchPath.String())
+	require.NoError(t, err)
+	require.Contains(t, string(stderr), "Sketches with .pde extension are deprecated, please rename the following files to .ino:")
+	require.Contains(t, string(stderr), sketchFilePde.String())
+
+	// Build sketch from file
+	_, stderr, err = cli.Run("compile", "--clean", "-b", fqbn, sketchFilePde.String())
+	require.NoError(t, err)
+	require.Contains(t, string(stderr), "Sketches with .pde extension are deprecated, please rename the following files to .ino:")
+	require.Contains(t, string(stderr), sketchFilePde.String())
+}

test/test_compile_part_3.py

@@ -39,36 +39,6 @@
 #    assert "Skipping dependencies detection for precompiled library Arduino_TensorFlowLite" in result.stdout
 
 
-def test_compile_sketch_with_pde_extension(run_command, data_dir):
-    # Init the environment explicitly
-    assert run_command(["update"])
-
-    # Install core to compile
-    assert run_command(["core", "install", "arduino:avr@1.8.3"])
-
-    sketch_name = "CompilePdeSketch"
-    sketch_path = Path(data_dir, sketch_name)
-    fqbn = "arduino:avr:uno"
-
-    # Create a test sketch
-    assert run_command(["sketch", "new", sketch_path])
-
-    # Renames sketch file to pde
-    sketch_file = Path(sketch_path, f"{sketch_name}.ino").rename(sketch_path / f"{sketch_name}.pde")
-
-    # Build sketch from folder
-    res = run_command(["compile", "--clean", "-b", fqbn, sketch_path])
-    assert res.ok
-    assert "Sketches with .pde extension are deprecated, please rename the following files to .ino:" in res.stderr
-    assert str(sketch_file) in res.stderr
-
-    # Build sketch from file
-    res = run_command(["compile", "--clean", "-b", fqbn, sketch_file])
-    assert res.ok
-    assert "Sketches with .pde extension are deprecated, please rename the following files to .ino" in res.stderr
-    assert str(sketch_file) in res.stderr
-
-
 def test_compile_sketch_with_multiple_main_files(run_command, data_dir):
     # Init the environment explicitly
     assert run_command(["update"])