Use pointers for SourceFile queues

Author: cmaglie

legacy/builder/container_find_includes.go

@@ -285,7 +285,7 @@ func writeCache(cache *includeCache, path *paths.Path) error {
 	return nil
 }
 
-func findIncludesUntilDone(ctx *types.Context, cache *includeCache, sourceFile types.SourceFile) error {
+func findIncludesUntilDone(ctx *types.Context, cache *includeCache, sourceFile *types.SourceFile) error {
 	sourcePath := sourceFile.SourcePath(ctx)
 	targetFilePath := paths.NullPath()
 	depPath := sourceFile.DepfilePath(ctx)

legacy/builder/types/accessories.go

@@ -43,19 +43,19 @@ func (queue *UniqueStringQueue) Empty() bool {
 	return queue.Len() == 0
 }
 
-type UniqueSourceFileQueue []SourceFile
+type UniqueSourceFileQueue []*SourceFile
 
 func (queue UniqueSourceFileQueue) Len() int           { return len(queue) }
 func (queue UniqueSourceFileQueue) Less(i, j int) bool { return false }
 func (queue UniqueSourceFileQueue) Swap(i, j int)      { panic("Who called me?!?") }
 
-func (queue *UniqueSourceFileQueue) Push(value SourceFile) {
+func (queue *UniqueSourceFileQueue) Push(value *SourceFile) {
 	if !sliceContainsSourceFile(*queue, value) {
 		*queue = append(*queue, value)
 	}
 }
 
-func (queue *UniqueSourceFileQueue) Pop() SourceFile {
+func (queue *UniqueSourceFileQueue) Pop() *SourceFile {
 	old := *queue
 	x := old[0]
 	*queue = old[1:]

legacy/builder/types/types.go

@@ -34,15 +34,15 @@ type SourceFile struct {
 // Create a SourceFile containing the given source file path within the
 // given origin. The given path can be absolute, or relative within the
 // origin's root source folder
-func MakeSourceFile(ctx *Context, origin interface{}, path *paths.Path) (SourceFile, error) {
+func MakeSourceFile(ctx *Context, origin interface{}, path *paths.Path) (*SourceFile, error) {
 	if path.IsAbs() {
 		var err error
 		path, err = sourceRoot(ctx, origin).RelTo(path)
 		if err != nil {
-			return SourceFile{}, err
+			return nil, err
 		}
 	}
-	return SourceFile{Origin: origin, RelativePath: path}, nil
+	return &SourceFile{Origin: origin, RelativePath: path}, nil
 }
 
 // Return the build root for the given origin, where build products will

legacy/builder/types/utils.go

@@ -25,7 +25,7 @@ func sliceContains(slice []string, target string) bool {
 	return false
 }
 
-func sliceContainsSourceFile(slice []SourceFile, target SourceFile) bool {
+func sliceContainsSourceFile(slice []SourceFile, target *SourceFile) bool {
 	for _, elem := range slice {
 		if elem.Origin == target.Origin && elem.RelativePath.EqualsTo(target.RelativePath) {
 			return true