Migrated TestBoardListWithInvalidDiscovery from test_board.py to board_test.go

Author: MatteoPologruto

internal/integrationtest/board/board_test.go

@@ -40,3 +40,30 @@ func TestBoardList(t *testing.T) {
 	requirejson.Query(t, stdout, ".[] | .port | .protocol!=\"\"", "true")
 	requirejson.Query(t, stdout, ".[] | .port | .protocol_label!=\"\"", "true")
 }
+
+func TestBoardListWithInvalidDiscovery(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("core", "update-index")
+	require.NoError(t, err)
+	_, _, err = cli.Run("board", "list")
+	require.NoError(t, err)
+
+	// check that the CLI does not crash if an invalid discovery is installed
+	// (for example if the installation fails midway).
+	// https://github.com/arduino/arduino-cli/issues/1669
+	toolDir := cli.DataDir().Join("packages", "builtin", "tools", "serial-discovery")
+	dirToRemove, err := toolDir.ReadDirRecursive()
+	require.NoError(t, err)
+	for i, d := range dirToRemove {
+		if i != 0 {
+			err = d.RemoveAll()
+			require.NoError(t, err)
+		}
+	}
+
+	_, stderr, err := cli.Run("board", "list")
+	require.NoError(t, err)
+	require.Contains(t, string(stderr), "builtin:serial-discovery")
+}

test/test_board.py

@@ -394,23 +394,6 @@
 """  # noqa: E501
 
 
-def test_board_list_with_invalid_discovery(run_command, data_dir):
-    run_command(["core", "update-index"])
-    result = run_command(["board", "list"])
-    assert result.ok
-
-    # check that the CLI do no crash if an invalid discovery is installed
-    # (for example if the installation fails midway).
-    # https://github.com/arduino/arduino-cli/issues/1669
-    tool_dir = os.path.join(data_dir, "packages", "builtin", "tools", "serial-discovery")
-    for file_to_delete in glob.glob(tool_dir + "/*/*"):
-        os.remove(file_to_delete)
-
-    result = run_command(["board", "list"])
-    assert result.ok
-    assert "builtin:serial-discovery" in result.stderr
-
-
 def test_board_listall(run_command):
     assert run_command(["update"])
     assert run_command(["core", "install", "arduino:avr@1.8.3"])