factor out the fqbn flag handling

Author: umbynos

cli/arguments/fqbn.go

@@ -0,0 +1,43 @@
+// This file is part of arduino-cli.
+//
+// Copyright 2020 ARDUINO SA (http://www.arduino.cc/)
+//
+// This software is released under the GNU General Public License version 3,
+// which covers the main part of arduino-cli.
+// The terms of this license can be found at:
+// https://www.gnu.org/licenses/gpl-3.0.en.html
+//
+// You can be released from the requirements of the above licenses by purchasing
+// a commercial license. Buying such a license is mandatory if you want to
+// modify or otherwise use the software for commercial activities involving the
+// Arduino software without disclosing the source code of your own applications.
+// To purchase a commercial license, send an email to license@arduino.cc.
+
+package arguments
+
+import "github.com/spf13/cobra"
+
+// Fqbn contains the fqbn flag data.
+// This is useful so all flags used by commands that need
+// this information are consistent with each other.
+type Fqbn struct {
+	fqbn string
+}
+
+// AddToCommand adds the flags used to set fqbn to the specified Command
+func (f *Fqbn) AddToCommand(cmd *cobra.Command) {
+	cmd.Flags().StringVarP(&f.fqbn, "fqbn", "b", "", tr("Fully Qualified Board Name, e.g.: arduino:avr:uno"))
+	cmd.RegisterFlagCompletionFunc("fqbn", func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+		return GetInstalledBoards(), cobra.ShellCompDirectiveDefault
+	})
+}
+
+// String returns the fqbn
+func (f *Fqbn) String() string {
+	return f.fqbn
+}
+
+// Set sets the fqbn
+func (f *Fqbn) Set(fqbn string) {
+	f.fqbn = fqbn
+}

cli/board/details.go

@@ -33,8 +33,8 @@ import (
 
 var (
 	showFullDetails bool
-	fqbn            string
 	listProgrammers bool
+	fqbn            arguments.Fqbn
 )
 
 func initDetailsCommand() *cobra.Command {
@@ -47,11 +47,8 @@ func initDetailsCommand() *cobra.Command {
 		Run:     runDetailsCommand,
 	}
 
+	fqbn.AddToCommand(detailsCommand)
 	detailsCommand.Flags().BoolVarP(&showFullDetails, "full", "f", false, tr("Show full board details"))
-	detailsCommand.Flags().StringVarP(&fqbn, "fqbn", "b", "", tr("Fully Qualified Board Name, e.g.: arduino:avr:uno"))
-	detailsCommand.RegisterFlagCompletionFunc("fqbn", func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
-		return arguments.GetInstalledBoards(), cobra.ShellCompDirectiveDefault
-	})
 	detailsCommand.Flags().BoolVarP(&listProgrammers, "list-programmers", "", false, tr("Show list of available programmers"))
 	// detailsCommand.MarkFlagRequired("fqbn") // enable once `board details <fqbn>` is removed
 
@@ -62,13 +59,13 @@ func runDetailsCommand(cmd *cobra.Command, args []string) {
 	inst := instance.CreateAndInit()
 
 	// remove once `board details <fqbn>` is removed
-	if fqbn == "" && len(args) > 0 {
-		fqbn = args[0]
+	if fqbn.String() == "" && len(args) > 0 {
+		fqbn.Set(args[0])
 	}
 
 	res, err := board.Details(context.Background(), &rpc.BoardDetailsRequest{
 		Instance: inst,
-		Fqbn:     fqbn,
+		Fqbn:     fqbn.String(),
 	})
 
 	if err != nil {