Skip to content

Commit df7fbb6

Browse files
cmagliefacchinm
authored andcommitted
Slightly refactored methods of UniqueSourceFileQueue
- Added 'Contains(...)' method (instead of sliceContainsSourceFile(...)) - Removed useless comparators
1 parent a0b802c commit df7fbb6

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

legacy/builder/container_find_includes.go

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -466,12 +466,12 @@ func (f *SourceFile) DepfilePath(ctx *types.Context) *paths.Path {
466466

467467
type UniqueSourceFileQueue []SourceFile
468468

469-
func (queue UniqueSourceFileQueue) Len() int { return len(queue) }
470-
func (queue UniqueSourceFileQueue) Less(i, j int) bool { return false }
471-
func (queue UniqueSourceFileQueue) Swap(i, j int) { panic("Who called me?!?") }
469+
func (queue UniqueSourceFileQueue) Len() int {
470+
return len(queue)
471+
}
472472

473473
func (queue *UniqueSourceFileQueue) Push(value SourceFile) {
474-
if !sliceContainsSourceFile(*queue, value) {
474+
if !queue.Contains(value) {
475475
*queue = append(*queue, value)
476476
}
477477
}
@@ -487,8 +487,8 @@ func (queue *UniqueSourceFileQueue) Empty() bool {
487487
return queue.Len() == 0
488488
}
489489

490-
func sliceContainsSourceFile(slice []SourceFile, target SourceFile) bool {
491-
for _, elem := range slice {
490+
func (queue *UniqueSourceFileQueue) Contains(target SourceFile) bool {
491+
for _, elem := range *queue {
492492
if elem.Origin == target.Origin && elem.RelativePath.EqualsTo(target.RelativePath) {
493493
return true
494494
}

0 commit comments

Comments
 (0)