Fixed error message and integration tests

Author: cmaglie

cli/arguments/sketch.go

@@ -48,7 +48,7 @@ func InitSketchPath(path string) (sketchPath *paths.Path) {
 func NewSketch(sketchPath *paths.Path) *sketch.Sketch {
 	sketch, err := sketch.New(sketchPath)
 	if err != nil {
-		feedback.Errorf(tr("Error creating sketch: %v"), err)
+		feedback.Errorf(tr("Error opening sketch: %v"), err)
 		os.Exit(errorcodes.ErrGeneric)
 	}
 	return sketch

test/test_compile_part_1.py

@@ -131,7 +131,7 @@ def test_compile_with_sketch_with_symlink_selfloop(run_command, data_dir):
     result = run_command(["compile", "-b", fqbn, sketch_path])
     # The assertion is a bit relaxed in this case because win behaves differently from macOs and linux
     # returning a different error detailed message
-    assert "Error during build: Can't open sketch:" in result.stderr
+    assert "Error opening sketch:" in result.stderr
     assert not result.ok
 
     sketch_name = "CompileIntegrationTestSymlinkDirLoop"
@@ -153,7 +153,7 @@ def test_compile_with_sketch_with_symlink_selfloop(run_command, data_dir):
     result = run_command(["compile", "-b", fqbn, sketch_path])
     # The assertion is a bit relaxed in this case because win behaves differently from macOs and linux
     # returning a different error detailed message
-    assert "Error during build: Can't open sketch:" in result.stderr
+    assert "Error opening sketch:" in result.stderr
     assert not result.ok
 
 

test/test_compile_part_3.py

@@ -91,17 +91,17 @@ def test_compile_sketch_with_multiple_main_files(run_command, data_dir):
     # Build sketch from folder
     res = run_command(["compile", "--clean", "-b", fqbn, sketch_path])
     assert res.failed
-    assert "Error during build: Can't open sketch: multiple main sketch files found" in res.stderr
+    assert "Error opening sketch: multiple main sketch files found" in res.stderr
 
     # Build sketch from .ino file
     res = run_command(["compile", "--clean", "-b", fqbn, sketch_ino_file])
     assert res.failed
-    assert "Error during build: Can't open sketch: multiple main sketch files found" in res.stderr
+    assert "Error opening sketch: multiple main sketch files found" in res.stderr
 
     # Build sketch from .pde file
     res = run_command(["compile", "--clean", "-b", fqbn, sketch_pde_file])
     assert res.failed
-    assert "Error during build: Can't open sketch: multiple main sketch files found" in res.stderr
+    assert "Error opening sketch: multiple main sketch files found" in res.stderr
 
 
 def test_compile_sketch_case_mismatch_fails(run_command, data_dir):
@@ -124,15 +124,15 @@ def test_compile_sketch_case_mismatch_fails(run_command, data_dir):
     # * Compiling with sketch path
     res = run_command(["compile", "--clean", "-b", fqbn, sketch_path])
     assert res.failed
-    assert "Error during build: Can't open sketch: no valid sketch found" in res.stderr
+    assert "Error opening sketch: no valid sketch found" in res.stderr
     # * Compiling with sketch main file
     res = run_command(["compile", "--clean", "-b", fqbn, sketch_main_file])
     assert res.failed
-    assert "Error during build: Can't open sketch: no valid sketch found" in res.stderr
+    assert "Error opening sketch: no valid sketch found" in res.stderr
     # * Compiling in sketch path
     res = run_command(["compile", "--clean", "-b", fqbn], custom_working_dir=sketch_path)
     assert res.failed
-    assert "Error during build: Can't open sketch: no valid sketch found" in res.stderr
+    assert "Error opening sketch: no valid sketch found" in res.stderr
 
 
 def test_compile_with_only_compilation_database_flag(run_command, data_dir):

test/test_compile_part_4.py

@@ -377,7 +377,7 @@ def test_compile_without_upload_and_fqbn(run_command, data_dir):
 
     res = run_command(["compile", sketch_path])
     assert res.failed
-    assert "Error during build: Missing FQBN (Fully Qualified Board Name)" in res.stderr
+    assert "Missing FQBN (Fully Qualified Board Name)" in res.stderr
 
 
 def test_compile_non_installed_platform_with_wrong_packager_and_arch(run_command, data_dir):

test/test_upload.py

@@ -364,7 +364,7 @@ def test_compile_and_upload_combo_sketch_with_mismatched_casing(run_command, dat
         # Try to compile
         res = run_command(["compile", "--clean", "-b", board.fqbn, "-u", "-p", board.address, sketch_path])
         assert res.failed
-        assert "Error during build: Can't open sketch: no valid sketch found in" in res.stderr
+        assert "Error opening sketch: no valid sketch found in" in res.stderr
 
 
 def test_upload_sketch_with_mismatched_casing(run_command, data_dir, detected_boards, wait_for_board):