Migrate TestGenerateCompileCommandsJsonResilience from test_compile_part_4.py to compile_part_4_test.go

Author: MatteoPologruto

internal/integrationtest/compile/compile_part_4_test.go

@@ -346,3 +346,27 @@ func TestCompileWithEsp8266BundledLibraries(t *testing.T) {
 	}
 	require.NotContains(t, string(stdout), expectedOutput[0]+"\n"+expectedOutput[1]+"\n"+expectedOutput[2]+"\n")
 }
+
+func TestGenerateCompileCommandsJsonResilience(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("update")
+	require.NoError(t, err)
+
+	// check it didn't fail with esp32@2.0.1 that has a prebuild hook that must run:
+	// https://github.com/arduino/arduino-cli/issues/1547
+	url := "https://raw.githubusercontent.com/espressif/arduino-esp32/gh-pages/package_esp32_index.json"
+	_, _, err = cli.Run("core", "update-index", "--additional-urls="+url)
+	require.NoError(t, err)
+	_, _, err = cli.Run("core", "install", "esp32:esp32@2.0.1", "--additional-urls="+url)
+	require.NoError(t, err)
+	sketchPath := cli.CopySketch("sketch_simple")
+	_, _, err = cli.Run("compile", "-b", "esp32:esp32:featheresp32", "--only-compilation-database", sketchPath.String())
+	require.NoError(t, err)
+
+	// check it didn't fail on a sketch with a missing include
+	sketchPath = cli.CopySketch("sketch_with_missing_include")
+	_, _, err = cli.Run("compile", "-b", "esp32:esp32:featheresp32", "--only-compilation-database", sketchPath.String())
+	require.NoError(t, err)
+}

internal/integrationtest/testdata/sketch_simple/build/adafruit.samd.adafruit_feather_m0/sketch_simple.ino.hex

@@ -0,0 +1 @@
+:00000001FF

internal/integrationtest/testdata/sketch_simple/build/adafruit.samd.adafruit_feather_m0/sketch_simple.ino.map

@@ -0,0 +1,29 @@
+:100000000C9434000C9446000C9446000C9446006A
+:100010000C9446000C9446000C9446000C94460048
+:100020000C9446000C9446000C9446000C94460038
+:100030000C9446000C9446000C9446000C94460028
+:100040000C9448000C9446000C9446000C94460016
+:100050000C9446000C9446000C9446000C94460008
+:100060000C9446000C94460011241FBECFEFD8E03C
+:10007000DEBFCDBF21E0A0E0B1E001C01D92A930FC
+:10008000B207E1F70E9492000C94DC000C9400008F
+:100090001F920F920FB60F9211242F933F938F93BD
+:1000A0009F93AF93BF938091050190910601A0911A
+:1000B0000701B09108013091040123E0230F2D378F
+:1000C00058F50196A11DB11D2093040180930501EF
+:1000D00090930601A0930701B0930801809100015D
+:1000E00090910101A0910201B09103010196A11D1F
+:1000F000B11D8093000190930101A0930201B09380
+:100100000301BF91AF919F918F913F912F910F90DC
+:100110000FBE0F901F90189526E8230F0296A11D81
+:10012000B11DD2CF789484B5826084BD84B58160DE
+:1001300084BD85B5826085BD85B5816085BD8091B2
+:100140006E00816080936E0010928100809181002A
+:100150008260809381008091810081608093810022
+:10016000809180008160809380008091B1008460E4
+:100170008093B1008091B00081608093B000809145
+:100180007A00846080937A0080917A008260809304
+:100190007A0080917A00816080937A0080917A0061
+:1001A000806880937A001092C100C0E0D0E0209770
+:0C01B000F1F30E940000FBCFF894FFCF99
+:00000001FF

internal/integrationtest/testdata/sketch_simple/build/arduino.avr.uno/sketch_simple.ino.eep

@@ -0,0 +1,63 @@
+:020000040000FA
+:100000000C9434000C9446000C9446000C9446006A
+:100010000C9446000C9446000C9446000C94460048
+:100020000C9446000C9446000C9446000C94460038
+:100030000C9446000C9446000C9446000C94460028
+:100040000C9448000C9446000C9446000C94460016
+:100050000C9446000C9446000C9446000C94460008
+:100060000C9446000C94460011241FBECFEFD8E03C
+:10007000DEBFCDBF21E0A0E0B1E001C01D92A930FC
+:10008000B207E1F70E9492000C94DC000C9400008F
+:100090001F920F920FB60F9211242F933F938F93BD
+:1000A0009F93AF93BF938091050190910601A0911A
+:1000B0000701B09108013091040123E0230F2D378F
+:1000C00058F50196A11DB11D2093040180930501EF
+:1000D00090930601A0930701B0930801809100015D
+:1000E00090910101A0910201B09103010196A11D1F
+:1000F000B11D8093000190930101A0930201B09380
+:100100000301BF91AF919F918F913F912F910F90DC
+:100110000FBE0F901F90189526E8230F0296A11D81
+:10012000B11DD2CF789484B5826084BD84B58160DE
+:1001300084BD85B5826085BD85B5816085BD8091B2
+:100140006E00816080936E0010928100809181002A
+:100150008260809381008091810081608093810022
+:10016000809180008160809380008091B1008460E4
+:100170008093B1008091B00081608093B000809145
+:100180007A00846080937A0080917A008260809304
+:100190007A0080917A00816080937A0080917A0061
+:1001A000806880937A001092C100C0E0D0E0209770
+:0C01B000F1F30E940000FBCFF894FFCF99
+:107E0000112484B714BE81FFF0D085E080938100F7
+:107E100082E08093C00088E18093C10086E0809377
+:107E2000C20080E18093C4008EE0C9D0259A86E02C
+:107E300020E33CEF91E0309385002093840096BBD3
+:107E4000B09BFECF1D9AA8958150A9F7CC24DD24C4
+:107E500088248394B5E0AB2EA1E19A2EF3E0BF2EE7
+:107E6000A2D0813461F49FD0082FAFD0023811F036
+:107E7000013811F484E001C083E08DD089C08234E0
+:107E800011F484E103C0853419F485E0A6D080C0E4
+:107E9000853579F488D0E82EFF2485D0082F10E0AE
+:107EA000102F00270E291F29000F111F8ED06801E7
+:107EB0006FC0863521F484E090D080E0DECF843638
+:107EC00009F040C070D06FD0082F6DD080E0C81688
+:107ED00080E7D80618F4F601B7BEE895C0E0D1E017
+:107EE00062D089930C17E1F7F0E0CF16F0E7DF06D8
+:107EF00018F0F601B7BEE89568D007B600FCFDCFD4
+:107F0000A601A0E0B1E02C9130E011968C91119780
+:107F100090E0982F8827822B932B1296FA010C0160
+:107F200087BEE89511244E5F5F4FF1E0A038BF0790
+:107F300051F7F601A7BEE89507B600FCFDCF97BE46
+:107F4000E89526C08437B1F42ED02DD0F82E2BD052
+:107F50003CD0F601EF2C8F010F5F1F4F84911BD097
+:107F6000EA94F801C1F70894C11CD11CFA94CF0C13
+:107F7000D11C0EC0853739F428D08EE10CD085E9AC
+:107F80000AD08FE07ACF813511F488E018D01DD067
+:107F900080E101D065CF982F8091C00085FFFCCF94
+:107FA0009093C60008958091C00087FFFCCF809118
+:107FB000C00084FD01C0A8958091C6000895E0E648
+:107FC000F0E098E1908380830895EDDF803219F02E
+:107FD00088E0F5DFFFCF84E1DECF1F93182FE3DFCA
+:107FE0001150E9F7F2DF1F91089580E0E8DFEE27F6
+:047FF000FF270994CA
+:027FFE00040479
+:00000001FF

internal/integrationtest/testdata/sketch_simple/build/arduino.avr.uno/sketch_simple.ino.hex

@@ -0,0 +1 @@
+#define TRUE FALSE

internal/integrationtest/testdata/sketch_simple/build/arduino.avr.uno/sketch_simple.ino.with_bootloader.hex

@@ -0,0 +1,15 @@
+#include <Arduino.h>
+#line 1 {{QuoteCppString .sketch.MainFile.Name}}
+void setup() {
+
+}
+
+void loop() {
+
+}
+#line 1 {{QuoteCppString (index .sketch.OtherSketchFiles 0).Name}}
+
+#line 1 {{QuoteCppString (index .sketch.OtherSketchFiles 1).Name}}
+String hello() {
+  return "world";
+}

internal/integrationtest/testdata/sketch_simple/doc.txt

@@ -0,0 +1,3 @@
+String hello() {
+  return "world";
+}

internal/integrationtest/testdata/sketch_simple/header.h

@@ -0,0 +1,7 @@
+void setup() {
+
+}
+
+void loop() {
+
+}

internal/integrationtest/testdata/sketch_simple/merged_sketch.txt

@@ -50,22 +50,6 @@ def test_compile_manually_installed_platform_using_boards_local_txt(run_command,
     assert run_command(["compile", "--clean", "-b", fqbn, sketch_path])
 
 
-def test_generate_compile_commands_json_resilience(run_command, data_dir, copy_sketch):
-    assert run_command(["update"])
-
-    # check it didn't fail with esp32@2.0.1 that has a prebuild hook that must run:
-    # https://github.com/arduino/arduino-cli/issues/1547
-    url = "https://raw.githubusercontent.com/espressif/arduino-esp32/gh-pages/package_esp32_index.json"
-    assert run_command(["core", "update-index", f"--additional-urls={url}"])
-    assert run_command(["core", "install", "esp32:esp32@2.0.1", f"--additional-urls={url}"])
-    sketch_path = copy_sketch("sketch_simple")
-    assert run_command(["compile", "-b", "esp32:esp32:featheresp32", "--only-compilation-database", sketch_path])
-
-    # check it didn't fail on a sketch with a missing include
-    sketch_path = copy_sketch("sketch_with_missing_include")
-    assert run_command(["compile", "-b", "esp32:esp32:featheresp32", "--only-compilation-database", sketch_path])
-
-
 def test_compile_sketch_with_tpp_file_include(run_command, copy_sketch):
     assert run_command(["update"])