debug: return error if debugging is not supported by the platform

Author: cmaglie

cli/debug/debug.go

@@ -33,6 +33,7 @@ import (
 	"github.com/fatih/color"
 	"github.com/sirupsen/logrus"
 	"github.com/spf13/cobra"
+	"google.golang.org/grpc/status"
 )
 
 var (
@@ -93,6 +94,10 @@ func run(command *cobra.Command, args []string) {
 	if printInfo {
 
 		if res, err := debug.GetDebugConfig(context.Background(), debugConfigRequested); err != nil {
+			if status, ok := status.FromError(err); ok {
+				feedback.Errorf("Error getting Debug info: %v", status.Message())
+				errorcodes.ExitWithGrpcStatus(status)
+			}
 			feedback.Errorf("Error getting Debug info: %v", err)
 			os.Exit(errorcodes.ErrGeneric)
 		} else {

cli/errorcodes/errorcodes.go

@@ -15,6 +15,13 @@
 
 package errorcodes
 
+import (
+	"os"
+
+	"google.golang.org/grpc/codes"
+	"google.golang.org/grpc/status"
+)
+
 // Error codes to be used for os.Exit().
 const (
 	_          = iota // 0 is not a valid exit error code
@@ -29,3 +36,14 @@ const (
 	ErrCoreConfig
 	ErrBadArgument
 )
+
+// ExitWithGrpcStatus will terminate the current process by returing the correct
+// error code closest matching the gRPC status.
+func ExitWithGrpcStatus(s *status.Status) {
+	switch s.Code() {
+	case codes.Unimplemented:
+		os.Exit(ErrBadArgument)
+	default:
+		os.Exit(ErrGeneric)
+	}
+}

commands/debug/debug_info.go

@@ -29,6 +29,8 @@ import (
 	"github.com/arduino/go-properties-orderedmap"
 	"github.com/pkg/errors"
 	"github.com/sirupsen/logrus"
+	"google.golang.org/grpc/codes"
+	"google.golang.org/grpc/status"
 )
 
 // GetDebugConfig returns metadata to start debugging with the specified board
@@ -40,6 +42,10 @@ func GetDebugConfig(ctx context.Context, req *debug.DebugConfigReq) (*debug.GetD
 		return nil, err
 	}
 
+	if !props.ContainsKey("executable") {
+		return nil, status.Error(codes.Unimplemented, fmt.Sprintf("debugging not supported for board %s", req.GetFqbn()))
+	}
+
 	server := props.Get("server")
 	toolchain := props.Get("toolchain")
 	resp := &debug.GetDebugConfigResp{