Fixed ENUM_VALUE_PREFIX and ENUM_VALUE_UPPER_SNAKE_CASE lint warning

Author: cmaglie

arduino/libraries/libraries_layout.go

@@ -72,9 +72,9 @@ func (d *LibraryLayout) UnmarshalJSON(b []byte) error {
 func (d *LibraryLayout) ToRPCLibraryLayout() rpc.LibraryLayout {
 	switch *d {
 	case FlatLayout:
-		return rpc.LibraryLayout_flat_layout
+		return rpc.LibraryLayout_LIBRARY_LAYOUT_FLAT
 	case RecursiveLayout:
-		return rpc.LibraryLayout_recursive_layout
+		return rpc.LibraryLayout_LIBRARY_LAYOUT_RECURSIVE
 	}
 	panic(fmt.Sprintf("invalid LibraryLayout value %d", *d))
 }

arduino/libraries/libraries_location.go

@@ -89,27 +89,27 @@ func (d *LibraryLocation) UnmarshalJSON(b []byte) error {
 func (d *LibraryLocation) ToRPCLibraryLocation() rpc.LibraryLocation {
 	switch *d {
 	case IDEBuiltIn:
-		return rpc.LibraryLocation_ide_builtin
+		return rpc.LibraryLocation_LIBRARY_LOCATION_IDE_BUILTIN
 	case PlatformBuiltIn:
-		return rpc.LibraryLocation_platform_builtin
+		return rpc.LibraryLocation_LIBRARY_LOCATION_PLATFORM_BUILTIN
 	case ReferencedPlatformBuiltIn:
-		return rpc.LibraryLocation_referenced_platform_builtin
+		return rpc.LibraryLocation_LIBRARY_LOCATION_REFERENCED_PLATFORM_BUILTIN
 	case User:
-		return rpc.LibraryLocation_user
+		return rpc.LibraryLocation_LIBRARY_LOCATION_USER
 	}
 	panic(fmt.Sprintf("invalid LibraryLocation value %d", *d))
 }
 
 // FromRPCLibraryLocation converts a rpc.LibraryLocation to a LibraryLocation
 func FromRPCLibraryLocation(l rpc.LibraryLocation) LibraryLocation {
 	switch l {
-	case rpc.LibraryLocation_ide_builtin:
+	case rpc.LibraryLocation_LIBRARY_LOCATION_IDE_BUILTIN:
 		return IDEBuiltIn
-	case rpc.LibraryLocation_platform_builtin:
+	case rpc.LibraryLocation_LIBRARY_LOCATION_PLATFORM_BUILTIN:
 		return PlatformBuiltIn
-	case rpc.LibraryLocation_referenced_platform_builtin:
+	case rpc.LibraryLocation_LIBRARY_LOCATION_REFERENCED_PLATFORM_BUILTIN:
 		return ReferencedPlatformBuiltIn
-	case rpc.LibraryLocation_user:
+	case rpc.LibraryLocation_LIBRARY_LOCATION_USER:
 		return User
 	}
 	panic(fmt.Sprintf("invalid rpc.LibraryLocation value %d", l))

cli/lib/examples.go

@@ -112,7 +112,7 @@ func (ir libraryExamplesResult) String() string {
 		name := lib.Library.Name
 		if lib.Library.ContainerPlatform != "" {
 			name += " (" + lib.Library.GetContainerPlatform() + ")"
-		} else if lib.Library.Location != rpc.LibraryLocation_user {
+		} else if lib.Library.Location != rpc.LibraryLocation_LIBRARY_LOCATION_USER {
 			name += " (" + lib.Library.GetLocation().String() + ")"
 		}
 		r := fmt.Sprintf("Examples for library %s\n", color.GreenString("%s", name))

cli/lib/search.go

@@ -124,12 +124,12 @@ func (res result) String() string {
 
 	var out strings.Builder
 
-	if res.results.GetStatus() == rpc.LibrarySearchStatus_failed {
+	if res.results.GetStatus() == rpc.LibrarySearchStatus_LIBRARY_SEARCH_STATUS_FAILED {
 		out.WriteString("No libraries matching your search.\nDid you mean...\n")
 	}
 
 	for _, lib := range results {
-		if res.results.GetStatus() == rpc.LibrarySearchStatus_success {
+		if res.results.GetStatus() == rpc.LibrarySearchStatus_LIBRARY_SEARCH_STATUS_SUCCESS {
 			out.WriteString(fmt.Sprintf("Name: \"%s\"\n", lib.Name))
 			if res.namesOnly {
 				continue

commands/daemon/monitor.go

@@ -45,7 +45,7 @@ func (s *MonitorService) StreamingOpen(stream rpc.MonitorService_StreamingOpenSe
 	// select which type of monitor we need
 	var mon monitors.Monitor
 	switch config.GetType() {
-	case rpc.MonitorConfig_SERIAL:
+	case rpc.MonitorConfig_TARGET_TYPE_SERIAL:
 		// grab port speed from additional config data
 		var baudRate float64
 		addCfg := config.GetAdditionalConfig()

commands/lib/search.go

@@ -41,7 +41,7 @@ func LibrarySearch(ctx context.Context, req *rpc.LibrarySearchRequest) (*rpc.Lib
 func searchLibrary(req *rpc.LibrarySearchRequest, lm *librariesmanager.LibrariesManager) (*rpc.LibrarySearchResponse, error) {
 	query := req.GetQuery()
 	res := []*rpc.SearchedLibrary{}
-	status := rpc.LibrarySearchStatus_success
+	status := rpc.LibrarySearchStatus_LIBRARY_SEARCH_STATUS_SUCCESS
 
 	// If the query is empty all libraries are returned
 	if strings.Trim(query, " ") == "" {

commands/lib/search_test.go

@@ -27,7 +27,7 @@ func TestSearchLibrary(t *testing.T) {
 	}
 
 	assert := assert.New(t)
-	assert.Equal(resp.GetStatus(), rpc.LibrarySearchStatus_success)
+	assert.Equal(resp.GetStatus(), rpc.LibrarySearchStatus_LIBRARY_SEARCH_STATUS_SUCCESS)
 	assert.Equal(len(resp.GetLibraries()), 2)
 	assert.True(strings.Contains(resp.GetLibraries()[0].Name, "Test"))
 	assert.True(strings.Contains(resp.GetLibraries()[1].Name, "Test"))
@@ -48,7 +48,7 @@ func TestSearchLibrarySimilar(t *testing.T) {
 	}
 
 	assert := assert.New(t)
-	assert.Equal(resp.GetStatus(), rpc.LibrarySearchStatus_success)
+	assert.Equal(resp.GetStatus(), rpc.LibrarySearchStatus_LIBRARY_SEARCH_STATUS_SUCCESS)
 	assert.Equal(len(resp.GetLibraries()), 2)
 	libs := map[string]*rpc.SearchedLibrary{}
 	for _, l := range resp.GetLibraries() {

rpc/buf.yaml

@@ -1,11 +1,6 @@
 version: v1beta1
 lint:
   ignore_only:
-    ENUM_VALUE_PREFIX:
-      - commands/lib.proto
-      - monitor/monitor.proto
-    ENUM_VALUE_UPPER_SNAKE_CASE:
-      - commands/lib.proto
     ENUM_ZERO_VALUE_SUFFIX:
       - commands/lib.proto
       - monitor/monitor.proto

rpc/commands/lib.pb.go

@@ -112,9 +112,9 @@ message LibrarySearchRequest {
 
 enum LibrarySearchStatus {
     // No search results were found.
-    failed = 0;
+    LIBRARY_SEARCH_STATUS_FAILED = 0;
     // Search results were found.
-    success = 1;
+    LIBRARY_SEARCH_STATUS_SUCCESS = 1;
 }
 
 message LibrarySearchResponse {
@@ -279,22 +279,22 @@ message Library {
 
 enum LibraryLayout {
     // Library is in the 1.0 Arduino library format.
-    flat_layout = 0;
+    LIBRARY_LAYOUT_FLAT = 0;
     // Library is in the 1.5 Arduino library format.
-    recursive_layout = 1;
+    LIBRARY_LAYOUT_RECURSIVE = 1;
 }
 
 enum LibraryLocation {
     // In the `libraries` subdirectory of the Arduino IDE installation.
-    ide_builtin = 0;
+    LIBRARY_LOCATION_IDE_BUILTIN = 0;
     // In the `libraries` subdirectory of the user directory (sketchbook).
-    user = 1;
+    LIBRARY_LOCATION_USER = 1;
     // In the `libraries` subdirectory of a platform.
-    platform_builtin = 2;
+    LIBRARY_LOCATION_PLATFORM_BUILTIN = 2;
     // When `LibraryLocation` is used in a context where a board is specified,
     // this indicates the library is in the `libraries` subdirectory of a
     // platform referenced by the board's platform.
-    referenced_platform_builtin = 3;
+    LIBRARY_LOCATION_REFERENCED_PLATFORM_BUILTIN = 3;
 }
 
 message ZipLibraryInstallRequest {