Migrate TestCompileWithInvalidBuildOptionJson from test_compile_part_4.py to compile_part_4_test.go

Author: MatteoPologruto

internal/integrationtest/compile/compile_part_4_test.go

@@ -218,3 +218,39 @@ func TestCompileWithConflictingLibrariesInclude(t *testing.T) {
 	}
 	require.Contains(t, string(stdout), expectedOutput[0]+"\n"+expectedOutput[1]+"\n"+expectedOutput[2]+"\n")
 }
+
+func TestCompileWithInvalidBuildOptionJson(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("update")
+	require.NoError(t, err)
+
+	_, _, err = cli.Run("core", "install", "arduino:avr@1.8.3")
+	require.NoError(t, err)
+
+	sketchName := "CompileInvalidBuildOptionsJson"
+	sketchPath := cli.SketchbookDir().Join(sketchName)
+	fqbn := "arduino:avr:uno"
+
+	// Create a test sketch
+	_, _, err = cli.Run("sketch", "new", sketchPath.String())
+	require.NoError(t, err)
+
+	// Get the build directory
+	md5 := md5.Sum(([]byte(sketchPath.String())))
+	sketchPathMd5 := strings.ToUpper(hex.EncodeToString(md5[:]))
+	require.NotEmpty(t, sketchPathMd5)
+	buildDir := paths.TempDir().Join("arduino-sketch-" + sketchPathMd5)
+
+	_, _, err = cli.Run("compile", "-b", fqbn, sketchPath.String(), "--verbose")
+	require.NoError(t, err)
+
+	// Breaks the build.options.json file
+	buildOptionsJson := buildDir.Join("build.options.json")
+	err = buildOptionsJson.WriteFile([]byte("invalid json"))
+	require.NoError(t, err)
+
+	_, _, err = cli.Run("compile", "-b", fqbn, sketchPath.String(), "--verbose")
+	require.NoError(t, err)
+}

test/test_compile_part_4.py

@@ -50,32 +50,6 @@ def test_compile_manually_installed_platform_using_boards_local_txt(run_command,
     assert run_command(["compile", "--clean", "-b", fqbn, sketch_path])
 
 
-def test_compile_with_invalid_build_options_json(run_command, data_dir):
-    assert run_command(["update"])
-
-    assert run_command(["core", "install", "arduino:avr@1.8.3"])
-
-    sketch_name = "CompileInvalidBuildOptionsJson"
-    sketch_path = Path(data_dir, sketch_name)
-    fqbn = "arduino:avr:uno"
-
-    # Create a test sketch
-    assert run_command(["sketch", "new", sketch_path])
-
-    # Get the build directory
-    sketch_path_md5 = hashlib.md5(bytes(sketch_path)).hexdigest().upper()
-    build_dir = Path(tempfile.gettempdir(), f"arduino-sketch-{sketch_path_md5}")
-
-    assert run_command(["compile", "-b", fqbn, sketch_path, "--verbose"])
-
-    # Breaks the build.options.json file
-    build_options_json = build_dir / "build.options.json"
-    with open(build_options_json, "w") as f:
-        f.write("invalid json")
-
-    assert run_command(["compile", "-b", fqbn, sketch_path, "--verbose"])
-
-
 def test_compile_with_esp32_bundled_libraries(run_command, data_dir, copy_sketch):
     # Some esp cores have have bundled libraries that are optimize for that architecture,
     # it might happen that if the user has a library with the same name installed conflicts