Replaced utils.SliceContains with stdlib function

Author: cmaglie

legacy/builder/create_cmake_rule.go

@@ -22,6 +22,7 @@ import (
 	"strings"
 
 	properties "github.com/arduino/go-properties-orderedmap"
+	"golang.org/x/exp/slices"
 
 	bldr "github.com/arduino/arduino-cli/arduino/builder"
 	"github.com/arduino/arduino-cli/arduino/globals"
@@ -209,7 +210,7 @@ func (s *ExportProjectCMake) Run(ctx *types.Context) error {
 		lib := staticLib.Base()
 		lib = strings.TrimPrefix(lib, "lib")
 		lib = strings.TrimSuffix(lib, ".a")
-		if !utils.SliceContains(dynamicLibsFromGccMinusL, lib) {
+		if !slices.Contains(dynamicLibsFromGccMinusL, lib) {
 			linkGroup += " " + lib
 			cmakelist += "add_library (" + lib + " STATIC IMPORTED)\n"
 			location := strings.TrimPrefix(staticLib.String(), cmakeFolder.String())
@@ -264,7 +265,7 @@ func findUniqueFoldersRelative(slice []string, base string) string {
 	for _, element := range slice {
 		path := filepath.Dir(element)
 		path = strings.TrimPrefix(path, base+"/")
-		if !utils.SliceContains(out, path) {
+		if !slices.Contains(out, path) {
 			out = append(out, path)
 		}
 	}

legacy/builder/test/helper_tools_downloader.go

@@ -29,10 +29,10 @@ import (
 
 	"github.com/arduino/arduino-cli/legacy/builder/constants"
 	"github.com/arduino/arduino-cli/legacy/builder/gohasissues"
-	"github.com/arduino/arduino-cli/legacy/builder/utils"
 	"github.com/arduino/go-paths-helper"
 	"github.com/arduino/go-properties-orderedmap"
 	"github.com/pkg/errors"
+	"golang.org/x/exp/slices"
 )
 
 var hardwareFolder = paths.New("downloaded_hardware")
@@ -692,7 +692,7 @@ func translateGOOSGOARCHToPackageIndexValue() []string {
 func findToolUrl(index map[string]interface{}, tool Tool, host []string) (string, error) {
 	if len(tool.OsUrls) > 0 {
 		for _, osUrl := range tool.OsUrls {
-			if utils.SliceContains(host, osUrl.Os) {
+			if slices.Contains(host, osUrl.Os) {
 				return osUrl.Url, nil
 			}
 		}
@@ -709,7 +709,7 @@ func findToolUrl(index map[string]interface{}, tool Tool, host []string) (string
 					systems := packageTool["systems"].([]interface{})
 					for _, s := range systems {
 						system := s.(map[string]interface{})
-						if utils.SliceContains(host, system["host"].(string)) {
+						if slices.Contains(host, system["host"].(string)) {
 							return system[constants.TOOL_URL].(string), nil
 						}
 					}

legacy/builder/unused_compiled_libraries_remover.go

@@ -18,8 +18,8 @@ package builder
 import (
 	"github.com/arduino/arduino-cli/arduino/libraries"
 	"github.com/arduino/arduino-cli/legacy/builder/types"
-	"github.com/arduino/arduino-cli/legacy/builder/utils"
 	"github.com/pkg/errors"
+	"golang.org/x/exp/slices"
 )
 
 type UnusedCompiledLibrariesRemover struct{}
@@ -39,7 +39,7 @@ func (s *UnusedCompiledLibrariesRemover) Run(ctx *types.Context) error {
 	}
 	for _, file := range files {
 		if file.IsDir() {
-			if !utils.SliceContains(libraryNames, file.Base()) {
+			if !slices.Contains(libraryNames, file.Base()) {
 				if err := file.RemoveAll(); err != nil {
 					return errors.WithStack(err)
 				}

legacy/builder/utils/utils.go

@@ -32,6 +32,7 @@ import (
 	"github.com/arduino/arduino-cli/legacy/builder/types"
 	paths "github.com/arduino/go-paths-helper"
 	"github.com/pkg/errors"
+	"golang.org/x/exp/slices"
 	"golang.org/x/text/runes"
 	"golang.org/x/text/transform"
 	"golang.org/x/text/unicode/norm"
@@ -63,7 +64,7 @@ func FilterFilesWithExtensions(extensions ...string) filterFiles {
 	return func(files []os.FileInfo) []os.FileInfo {
 		var filtered []os.FileInfo
 		for _, file := range files {
-			if !file.IsDir() && SliceContains(extensions, filepath.Ext(file.Name())) {
+			if !file.IsDir() && slices.Contains(extensions, filepath.Ext(file.Name())) {
 				filtered = append(filtered, file)
 			}
 		}
@@ -118,15 +119,6 @@ func IsSCCSFile(file os.FileInfo) bool {
 	return SOURCE_CONTROL_FOLDERS[name]
 }
 
-func SliceContains(slice []string, target string) bool {
-	for _, value := range slice {
-		if value == target {
-			return true
-		}
-	}
-	return false
-}
-
 type mapFunc func(string) string
 
 func Map(slice []string, fn mapFunc) []string {
@@ -262,7 +254,7 @@ func FindFilesInFolder(dir *paths.Path, recurse bool, extensions []string) (path
 
 func AppendIfNotPresent(target []string, elements ...string) []string {
 	for _, element := range elements {
-		if !SliceContains(target, element) {
+		if !slices.Contains(target, element) {
 			target = append(target, element)
 		}
 	}