Migrate TestCompileWithOutputDirFlag from test_compile_part_2.py to compile_part_2_test.go

Author: MatteoPologruto

internal/integrationtest/compile/compile_part_2_test.go

@@ -0,0 +1,73 @@
+// This file is part of arduino-cli.
+//
+// Copyright 2022 ARDUINO SA (http://www.arduino.cc/)
+//
+// This software is released under the GNU General Public License version 3,
+// which covers the main part of arduino-cli.
+// The terms of this license can be found at:
+// https://www.gnu.org/licenses/gpl-3.0.en.html
+//
+// You can be released from the requirements of the above licenses by purchasing
+// a commercial license. Buying such a license is mandatory if you want to
+// modify or otherwise use the software for commercial activities involving the
+// Arduino software without disclosing the source code of your own applications.
+// To purchase a commercial license, send an email to license@arduino.cc.
+
+package compile_part_1_test
+
+import (
+	"crypto/md5"
+	"encoding/hex"
+	"strings"
+	"testing"
+
+	"github.com/arduino/arduino-cli/internal/integrationtest"
+	"github.com/arduino/go-paths-helper"
+	"github.com/stretchr/testify/require"
+)
+
+func TestCompileWithOutputDirFlag(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	// Init the environment explicitly
+	_, _, err := cli.Run("core", "update-index")
+	require.NoError(t, err)
+
+	// Download latest AVR
+	_, _, err = cli.Run("core", "install", "arduino:avr")
+	require.NoError(t, err)
+
+	sketchName := "CompileWithOutputDir"
+	sketchPath := cli.SketchbookDir().Join(sketchName)
+	fqbn := "arduino:avr:uno"
+
+	// Create a test sketch
+	stdout, _, err := cli.Run("sketch", "new", sketchPath.String())
+	require.NoError(t, err)
+	require.Contains(t, string(stdout), "Sketch created in: "+sketchPath.String())
+
+	// Test the --output-dir flag with absolute path
+	outputDir := cli.SketchbookDir().Join("test_dir", "output_dir")
+	_, _, err = cli.Run("compile", "-b", fqbn, sketchPath.String(), "--output-dir", outputDir.String())
+	require.NoError(t, err)
+
+	// Verifies expected binaries have been built
+	md5 := md5.Sum(([]byte(sketchPath.String())))
+	sketchPathMd5 := strings.ToUpper(hex.EncodeToString(md5[:]))
+	require.NotEmpty(t, sketchPathMd5)
+	buildDir := paths.TempDir().Join("arduino-sketch-" + sketchPathMd5)
+	require.FileExists(t, buildDir.Join(sketchName+".ino.eep").String())
+	require.FileExists(t, buildDir.Join(sketchName+".ino.elf").String())
+	require.FileExists(t, buildDir.Join(sketchName+".ino.hex").String())
+	require.FileExists(t, buildDir.Join(sketchName+".ino.with_bootloader.bin").String())
+	require.FileExists(t, buildDir.Join(sketchName+".ino.with_bootloader.hex").String())
+
+	// Verifies binaries are exported when --output-dir flag is specified
+	require.DirExists(t, outputDir.String())
+	require.FileExists(t, outputDir.Join(sketchName+".ino.eep").String())
+	require.FileExists(t, outputDir.Join(sketchName+".ino.elf").String())
+	require.FileExists(t, outputDir.Join(sketchName+".ino.hex").String())
+	require.FileExists(t, outputDir.Join(sketchName+".ino.with_bootloader.bin").String())
+	require.FileExists(t, outputDir.Join(sketchName+".ino.with_bootloader.hex").String())
+}

test/test_compile_part_2.py

@@ -19,46 +19,6 @@
 import simplejson as json
 
 
-def test_compile_with_output_dir_flag(run_command, data_dir):
-    # Init the environment explicitly
-    run_command(["core", "update-index"])
-
-    # Download latest AVR
-    run_command(["core", "install", "arduino:avr"])
-
-    sketch_name = "CompileWithOutputDir"
-    sketch_path = Path(data_dir, sketch_name)
-    fqbn = "arduino:avr:uno"
-
-    # Create a test sketch
-    result = run_command(["sketch", "new", sketch_path])
-    assert result.ok
-    assert f"Sketch created in: {sketch_path}" in result.stdout
-
-    # Test the --output-dir flag with absolute path
-    output_dir = Path(data_dir, "test_dir", "output_dir")
-    result = run_command(["compile", "-b", fqbn, sketch_path, "--output-dir", output_dir])
-    assert result.ok
-
-    # Verifies expected binaries have been built
-    sketch_path_md5 = hashlib.md5(bytes(sketch_path)).hexdigest().upper()
-    build_dir = Path(tempfile.gettempdir(), f"arduino-sketch-{sketch_path_md5}")
-    assert (build_dir / f"{sketch_name}.ino.eep").exists()
-    assert (build_dir / f"{sketch_name}.ino.elf").exists()
-    assert (build_dir / f"{sketch_name}.ino.hex").exists()
-    assert (build_dir / f"{sketch_name}.ino.with_bootloader.bin").exists()
-    assert (build_dir / f"{sketch_name}.ino.with_bootloader.hex").exists()
-
-    # Verifies binaries are exported when --output-dir flag is specified
-    assert output_dir.exists()
-    assert output_dir.is_dir()
-    assert (output_dir / f"{sketch_name}.ino.eep").exists()
-    assert (output_dir / f"{sketch_name}.ino.elf").exists()
-    assert (output_dir / f"{sketch_name}.ino.hex").exists()
-    assert (output_dir / f"{sketch_name}.ino.with_bootloader.bin").exists()
-    assert (output_dir / f"{sketch_name}.ino.with_bootloader.hex").exists()
-
-
 def test_compile_with_export_binaries_flag(run_command, data_dir):
     # Init the environment explicitly
     run_command(["core", "update-index"])