Migrate TestCoreListOutdatedCore from test_core.py to core_test.go

Author: MatteoPologruto

internal/integrationtest/core/core_test.go

@@ -26,6 +26,7 @@ import (
 	"github.com/arduino/arduino-cli/internal/integrationtest"
 	"github.com/arduino/go-paths-helper"
 	"github.com/stretchr/testify/require"
+	semver "go.bug.st/relaxed-semver"
 	"go.bug.st/testifyjson/requirejson"
 	"gopkg.in/src-d/go-git.v4"
 	"gopkg.in/src-d/go-git.v4/plumbing"
@@ -831,3 +832,26 @@ func TestCoreWithMissingCustomBoardOptionsIsLoaded(t *testing.T) {
 		}
 	]`)
 }
+
+func TestCoreListOutdatedCore(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("update")
+	require.NoError(t, err)
+
+	// Install an old core version
+	_, _, err = cli.Run("core", "install", "arduino:samd@1.8.6")
+	require.NoError(t, err)
+
+	stdout, _, err := cli.Run("core", "list", "--format", "json")
+	require.NoError(t, err)
+	requirejson.Len(t, stdout, 1)
+	requirejson.Query(t, stdout, ".[0] | .installed", "\"1.8.6\"")
+	installedVersion, err := semver.Parse(strings.Trim(requirejson.Parse(t, stdout).Query(".[0] | .installed").String(), "\""))
+	require.NoError(t, err)
+	latestVersion, err := semver.Parse(strings.Trim(requirejson.Parse(t, stdout).Query(".[0] | .latest").String(), "\""))
+	require.NoError(t, err)
+	// Installed version must be older than latest
+	require.True(t, installedVersion.LessThan(latestVersion))
+}

test/test_core.py

@@ -133,24 +133,6 @@ def test_core_download_multiple_platforms(run_command, data_dir):
     assert "Invalid argument passed: Found 2 platform for reference" in res.stderr
 
 
-def test_core_list_outdated_core(run_command):
-    assert run_command(["update"])
-
-    # Install an old core version
-    assert run_command(["core", "install", "arduino:samd@1.8.6"])
-
-    res = run_command(["core", "list", "--format", "json"])
-
-    data = json.loads(res.stdout)
-    assert len(data) == 1
-    samd_core = data[0]
-    assert samd_core["installed"] == "1.8.6"
-    installed_version = semver.parse_version_info(samd_core["installed"])
-    latest_version = semver.parse_version_info(samd_core["latest"])
-    # Installed version must be older than latest
-    assert installed_version.compare(latest_version) == -1
-
-
 def test_core_loading_package_manager(run_command, data_dir):
     # Create empty architecture folder (this condition is normally produced by `core uninstall`)
     (Path(data_dir) / "packages" / "foovendor" / "hardware" / "fooarch").mkdir(parents=True)