Skip to content

Commit 744631e

Browse files
Migrate TestCompileWithBuildPropertyContainingQuotes from
test_compile_part_1.py to compile_part_1_test.go
1 parent 26d7aa6 commit 744631e

File tree

2 files changed

+27
-25
lines changed

2 files changed

+27
-25
lines changed

internal/integrationtest/compile/compile_part_1_test.go

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -364,3 +364,30 @@ func TestCompileWithBuildPropertiesFlag(t *testing.T) {
364364
require.Contains(t, string(stdout), "-DFIRST_PIN=1")
365365
require.Contains(t, string(stdout), "-DSECOND_PIN=2")
366366
}
367+
368+
func TestCompileWithBuildPropertyContainingQuotes(t *testing.T) {
369+
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
370+
defer env.CleanUp()
371+
372+
// Init the environment explicitly
373+
_, _, err := cli.Run("core", "update-index")
374+
require.NoError(t, err)
375+
376+
// Install Arduino AVR Boards
377+
_, _, err = cli.Run("core", "install", "arduino:avr@1.8.3")
378+
require.NoError(t, err)
379+
380+
sketchName := "sketch_with_single_string_define"
381+
sketchPath := cli.CopySketch(sketchName)
382+
fqbn := "arduino:avr:uno"
383+
384+
// Compile using a build property with quotes
385+
stdout, _, err := cli.Run("compile",
386+
"-b",
387+
fqbn,
388+
`--build-property=build.extra_flags="-DMY_DEFINE="hello world""`,
389+
sketchPath.String(),
390+
"--verbose")
391+
require.NoError(t, err)
392+
require.Contains(t, string(stdout), `-DMY_DEFINE=\"hello world\"`)
393+
}

test/test_compile_part_1.py

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -25,31 +25,6 @@
2525
from .common import running_on_ci
2626

2727

28-
def test_compile_with_build_property_containing_quotes(run_command, data_dir, copy_sketch):
29-
# Init the environment explicitly
30-
assert run_command(["core", "update-index"])
31-
32-
# Install Arduino AVR Boards
33-
assert run_command(["core", "install", "arduino:avr@1.8.3"])
34-
35-
sketch_path = copy_sketch("sketch_with_single_string_define")
36-
fqbn = "arduino:avr:uno"
37-
38-
# Compile using a build property with quotes
39-
res = run_command(
40-
[
41-
"compile",
42-
"-b",
43-
fqbn,
44-
'--build-property=build.extra_flags=\\"-DMY_DEFINE=\\"hello world\\"\\"',
45-
sketch_path,
46-
"--verbose",
47-
]
48-
)
49-
assert res.ok
50-
assert '-DMY_DEFINE=\\"hello world\\"' in res.stdout
51-
52-
5328
def test_compile_with_multiple_build_property_flags(run_command, data_dir, copy_sketch, working_dir):
5429
# Init the environment explicitly
5530
assert run_command(["core", "update-index"])

0 commit comments

Comments
 (0)