Removed useless version param on 'core uninstall'

Author: cmaglie

cli/core/args.go

@@ -32,6 +32,13 @@ type platformReferenceArg struct {
 	Version      string
 }
 
+func (pl *platformReferenceArg) String() string {
+	if pl.Version != "" {
+		return pl.Package + ":" + pl.Architecture + "@" + pl.Version
+	}
+	return pl.Package + ":" + pl.Architecture
+}
+
 // parsePlatformReferenceArgs parses a sequence of "packager:arch@version" tokens and
 // returns a platformReferenceArg slice.
 func parsePlatformReferenceArgs(args []string) []*platformReferenceArg {

cli/core/uninstall.go

@@ -47,12 +47,17 @@ func runUninstallCommand(cmd *cobra.Command, args []string) {
 
 	platformsRefs := parsePlatformReferenceArgs(args)
 
+	for _, platformRef := range platformsRefs {
+		if platformRef.Version != "" {
+			formatter.PrintErrorMessage("Invalid parameter " + platformRef.String() + ": version not allowed")
+			os.Exit(cli.ErrBadArgument)
+		}
+	}
 	for _, platformRef := range platformsRefs {
 		_, err := core.PlatformUninstall(context.Background(), &rpc.PlatformUninstallReq{
 			Instance:        instance,
 			PlatformPackage: platformRef.Package,
 			Architecture:    platformRef.Architecture,
-			Version:         platformRef.Version,
 		}, output.NewTaskProgressCB())
 		if err != nil {
 			formatter.PrintError(err, "Error during uninstall")

commands/core/uninstall.go

@@ -34,16 +34,10 @@ func PlatformUninstall(ctx context.Context, req *rpc.PlatformUninstallReq, taskC
 		return nil, errors.New("invalid instance")
 	}
 
-	// If no version is specified consider the installed
-	version, err := commands.ParseVersion(req)
-	if err != nil {
-		return nil, fmt.Errorf("invalid version: %s", err)
-	}
-
 	ref := &packagemanager.PlatformReference{
 		Package:              req.PlatformPackage,
 		PlatformArchitecture: req.Architecture,
-		PlatformVersion:      version}
+	}
 	if ref.PlatformVersion == nil {
 		platform := pm.FindPlatform(ref)
 		if platform == nil {

rpc/core.pb.go

@@ -50,7 +50,6 @@ message PlatformUninstallReq {
     Instance instance = 1;
 	string platform_package  = 2;
 	string architecture = 3;
-	string version = 4;
 }
 
 message PlatformUninstallResp {