Migrate TestCompileWithCustomBuildPath from test_compile_part_2.py to compile_part_2_test.go

Author: MatteoPologruto

internal/integrationtest/compile/compile_part_2_test.go

@@ -18,6 +18,7 @@ package compile_part_1_test
 import (
 	"crypto/md5"
 	"encoding/hex"
+	"fmt"
 	"strings"
 	"testing"
 
@@ -105,3 +106,49 @@ func TestCompileWithExportBinariesFlag(t *testing.T) {
 	require.FileExists(t, sketchPath.Join("build", fqbn, sketchName+".ino.with_bootloader.bin").String())
 	require.FileExists(t, sketchPath.Join("build", fqbn, sketchName+".ino.with_bootloader.hex").String())
 }
+
+func TestCompileWithCustomBuildPath(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	// Init the environment explicitly
+	_, _, err := cli.Run("core", "update-index")
+	require.NoError(t, err)
+
+	// Download latest AVR
+	_, _, err = cli.Run("core", "install", "arduino:avr")
+	require.NoError(t, err)
+
+	sketchName := "CompileWithBuildPath"
+	sketchPath := cli.SketchbookDir().Join(sketchName)
+	fqbn := "arduino:avr:uno"
+
+	// Create a test sketch
+	_, _, err = cli.Run("sketch", "new", sketchPath.String())
+	require.NoError(t, err)
+
+	// Test the --build-path flag with absolute path
+	buildPath := cli.DataDir().Join("test_dir", "build_dir")
+	_, stderr, err := cli.Run("compile", "-b", fqbn, sketchPath.String(), "--build-path", buildPath.String())
+	fmt.Print(stderr)
+	require.NoError(t, err)
+
+	// Verifies expected binaries have been built to build_path
+	require.DirExists(t, buildPath.String())
+	require.FileExists(t, buildPath.Join(sketchName+".ino.eep").String())
+	require.FileExists(t, buildPath.Join(sketchName+".ino.elf").String())
+	require.FileExists(t, buildPath.Join(sketchName+".ino.hex").String())
+	require.FileExists(t, buildPath.Join(sketchName+".ino.with_bootloader.bin").String())
+	require.FileExists(t, buildPath.Join(sketchName+".ino.with_bootloader.hex").String())
+
+	// Verifies there are no binaries in temp directory
+	md5 := md5.Sum(([]byte(sketchPath.String())))
+	sketchPathMd5 := strings.ToUpper(hex.EncodeToString(md5[:]))
+	require.NotEmpty(t, sketchPathMd5)
+	buildDir := paths.TempDir().Join("arduino-sketch-" + sketchPathMd5)
+	require.NoFileExists(t, buildDir.Join(sketchName+".ino.eep").String())
+	require.NoFileExists(t, buildDir.Join(sketchName+".ino.elf").String())
+	require.NoFileExists(t, buildDir.Join(sketchName+".ino.hex").String())
+	require.NoFileExists(t, buildDir.Join(sketchName+".ino.with_bootloader.bin").String())
+	require.NoFileExists(t, buildDir.Join(sketchName+".ino.with_bootloader.hex").String())
+}

test/test_compile_part_2.py

@@ -19,47 +19,6 @@
 import simplejson as json
 
 
-def test_compile_with_custom_build_path(run_command, data_dir):
-    # Init the environment explicitly
-    run_command(["core", "update-index"])
-
-    # Download latest AVR
-    run_command(["core", "install", "arduino:avr"])
-
-    sketch_name = "CompileWithBuildPath"
-    sketch_path = Path(data_dir, sketch_name)
-    fqbn = "arduino:avr:uno"
-
-    # Create a test sketch
-    result = run_command(["sketch", "new", sketch_path])
-    assert result.ok
-    assert f"Sketch created in: {sketch_path}" in result.stdout
-
-    # Test the --build-path flag with absolute path
-    build_path = Path(data_dir, "test_dir", "build_dir")
-    result = run_command(["compile", "-b", fqbn, sketch_path, "--build-path", build_path])
-    print(result.stderr)
-    assert result.ok
-
-    # Verifies expected binaries have been built to build_path
-    assert build_path.exists()
-    assert build_path.is_dir()
-    assert (build_path / f"{sketch_name}.ino.eep").exists()
-    assert (build_path / f"{sketch_name}.ino.elf").exists()
-    assert (build_path / f"{sketch_name}.ino.hex").exists()
-    assert (build_path / f"{sketch_name}.ino.with_bootloader.bin").exists()
-    assert (build_path / f"{sketch_name}.ino.with_bootloader.hex").exists()
-
-    # Verifies there are no binaries in temp directory
-    sketch_path_md5 = hashlib.md5(bytes(sketch_path)).hexdigest().upper()
-    build_dir = Path(tempfile.gettempdir(), f"arduino-sketch-{sketch_path_md5}")
-    assert not (build_dir / f"{sketch_name}.ino.eep").exists()
-    assert not (build_dir / f"{sketch_name}.ino.elf").exists()
-    assert not (build_dir / f"{sketch_name}.ino.hex").exists()
-    assert not (build_dir / f"{sketch_name}.ino.with_bootloader.bin").exists()
-    assert not (build_dir / f"{sketch_name}.ino.with_bootloader.hex").exists()
-
-
 def test_compile_with_export_binaries_env_var(run_command, data_dir, downloads_dir):
     # Init the environment explicitly
     run_command(["core", "update-index"])