add completion for lib uninstall

Author: umbynos

cli/arguments/completion.go

@@ -8,6 +8,7 @@ import (
 	"github.com/arduino/arduino-cli/commands"
 	"github.com/arduino/arduino-cli/commands/board"
 	"github.com/arduino/arduino-cli/commands/core"
+	"github.com/arduino/arduino-cli/commands/lib"
 	rpc "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/commands/v1"
 )
 
@@ -125,3 +126,23 @@ func GetInstallableCores(toComplete string) []string {
 	}
 	return res
 }
+
+// GetUninstallableLibs is an helper function useful to autocomplete.
+// It returns a list of libs which can be uninstalled
+func GetUninstallableLibs(toComplete string) []string {
+	inst := instance.CreateAndInit() // TODO optimize this: it does not make sense to create an instance everytime
+	libs, _ := lib.LibraryList(context.Background(), &rpc.LibraryListRequest{
+		Instance:  inst,
+		All:       false,
+		Updatable: false,
+		Name:      "",
+		Fqbn:      "",
+	})
+	var res []string
+	// transform the data structure for the completion
+	for _, i := range libs.InstalledLibraries {
+		res = append(res, i.GetLibrary().Name)
+	}
+	return res
+}
+

cli/lib/uninstall.go

@@ -20,6 +20,7 @@ import (
 	"fmt"
 	"os"
 
+	"github.com/arduino/arduino-cli/cli/arguments"
 	"github.com/arduino/arduino-cli/cli/errorcodes"
 	"github.com/arduino/arduino-cli/cli/feedback"
 	"github.com/arduino/arduino-cli/cli/instance"
@@ -38,6 +39,9 @@ func initUninstallCommand() *cobra.Command {
 		Example: "  " + os.Args[0] + " lib uninstall AudioZero",
 		Args:    cobra.MinimumNArgs(1),
 		Run:     runUninstallCommand,
+		ValidArgsFunction: func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
+			return arguments.GetUninstallableLibs(toComplete), cobra.ShellCompDirectiveDefault
+		},
 	}
 	return uninstallCommand
 }

i18n/data/en.po

@@ -892,7 +892,7 @@ msgstr "Error serializing compilation database: %s"
 msgid "Error starting board discoveries"
 msgstr "Error starting board discoveries"
 
-#: cli/lib/uninstall.go:62
+#: cli/lib/uninstall.go:66
 msgid "Error uninstalling %[1]s: %[2]v"
 msgstr "Error uninstalling %[1]s: %[2]v"
 
@@ -1221,7 +1221,7 @@ msgstr "Invalid additional URL: %v"
 #: cli/core/uninstall.go:54
 #: cli/core/upgrade.go:81
 #: cli/lib/download.go:50
-#: cli/lib/uninstall.go:51
+#: cli/lib/uninstall.go:55
 msgid "Invalid argument passed: %v"
 msgstr "Invalid argument passed: %v"
 
@@ -1302,7 +1302,7 @@ msgstr "LIBRARY"
 #: cli/lib/download.go:34
 #: cli/lib/examples.go:39
 #: cli/lib/search.go:39
-#: cli/lib/uninstall.go:35
+#: cli/lib/uninstall.go:36
 msgid "LIBRARY_NAME"
 msgstr "LIBRARY_NAME"
 
@@ -2105,8 +2105,8 @@ msgstr "Uninstalling %s: tool is no more required"
 msgid "Uninstalls one or more cores and corresponding tool dependencies if no longer used."
 msgstr "Uninstalls one or more cores and corresponding tool dependencies if no longer used."
 
-#: cli/lib/uninstall.go:36
 #: cli/lib/uninstall.go:37
+#: cli/lib/uninstall.go:38
 msgid "Uninstalls one or more libraries."
 msgstr "Uninstalls one or more libraries."