Migrate TestRecompileWithDifferentLibrary from test_compile_part_4.py to compile_part_4_test.go

Author: MatteoPologruto

internal/integrationtest/compile/compile_part_4_test.go

@@ -16,9 +16,13 @@
 package compile_test
 
 import (
+	"crypto/md5"
+	"encoding/hex"
+	"strings"
 	"testing"
 
 	"github.com/arduino/arduino-cli/internal/integrationtest"
+	"github.com/arduino/go-paths-helper"
 	"github.com/stretchr/testify/require"
 	"gopkg.in/src-d/go-git.v4"
 	"gopkg.in/src-d/go-git.v4/plumbing"
@@ -112,3 +116,61 @@ func TestCompileWithLibraryPriority(t *testing.T) {
 	}
 	require.Contains(t, string(stdout), expectedOutput[0]+"\n"+expectedOutput[1]+"\n"+expectedOutput[2]+"\n")
 }
+
+func TestRecompileWithDifferentLibrary(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	_, _, err := cli.Run("update")
+	require.NoError(t, err)
+
+	_, _, err = cli.Run("core", "install", "arduino:avr@1.8.3")
+	require.NoError(t, err)
+
+	sketchName := "RecompileCompileSketchWithDifferentLibrary"
+	sketchPath := cli.SketchbookDir().Join(sketchName)
+	fqbn := "arduino:avr:uno"
+
+	// Install library
+	_, _, err = cli.Run("lib", "install", "WiFi101")
+	require.NoError(t, err)
+
+	// Manually installs a library
+	gitUrl := "https://github.com/arduino-libraries/WiFi101.git"
+	manuallyInstalledLibPath := cli.SketchbookDir().Join("my-libraries", "WiFi101")
+	_, err = git.PlainClone(manuallyInstalledLibPath.String(), false, &git.CloneOptions{
+		URL:           gitUrl,
+		ReferenceName: plumbing.NewTagReferenceName("0.16.1"),
+	})
+	require.NoError(t, err)
+
+	// Create new sketch and add library include
+	_, _, err = cli.Run("sketch", "new", sketchPath.String())
+	require.NoError(t, err)
+	sketchFile := sketchPath.Join(sketchName + ".ino")
+	lines, err := sketchFile.ReadFileAsLines()
+	require.NoError(t, err)
+	lines = append([]string{"#include <WiFi101.h>\n"}, lines...)
+	var data []byte
+	for _, l := range lines {
+		data = append(data, []byte(l)...)
+	}
+	err = sketchFile.WriteFile(data)
+	require.NoError(t, err)
+
+	md5 := md5.Sum(([]byte(sketchPath.String())))
+	sketchPathMd5 := strings.ToUpper(hex.EncodeToString(md5[:]))
+	require.NotEmpty(t, sketchPathMd5)
+	buildDir := paths.TempDir().Join("arduino-sketch-" + sketchPathMd5)
+
+	// Compile sketch using library not managed by CLI
+	stdout, _, err := cli.Run("compile", "-b", fqbn, "--library", manuallyInstalledLibPath.String(), sketchPath.String(), "-v")
+	require.NoError(t, err)
+	objPath := buildDir.Join("libraries", "WiFi101", "WiFi.cpp.o")
+	require.NotContains(t, string(stdout), "Using previously compiled file: "+objPath.String())
+
+	// Compile again using library installed from CLI
+	stdout, _, err = cli.Run("compile", "-b", fqbn, sketchPath.String(), "-v")
+	require.NoError(t, err)
+	require.NotContains(t, string(stdout), "Using previously compiled file: "+objPath.String())
+}

test/test_compile_part_4.py

@@ -50,49 +50,6 @@ def test_compile_manually_installed_platform_using_boards_local_txt(run_command,
     assert run_command(["compile", "--clean", "-b", fqbn, sketch_path])
 
 
-def test_recompile_with_different_library(run_command, data_dir):
-    assert run_command(["update"])
-
-    assert run_command(["core", "install", "arduino:avr@1.8.3"])
-
-    sketch_name = "RecompileCompileSketchWithDifferentLibrary"
-    sketch_path = Path(data_dir, sketch_name)
-    fqbn = "arduino:avr:uno"
-
-    # Install library
-    assert run_command(["lib", "install", "WiFi101"])
-
-    # Manually installs the same library already installed
-    git_url = "https://github.com/arduino-libraries/WiFi101.git"
-    manually_install_lib_path = Path(data_dir, "my-libraries", "WiFi101")
-    assert Repo.clone_from(git_url, manually_install_lib_path, multi_options=["-b 0.16.1"])
-
-    # Create new sketch and add library include
-    assert run_command(["sketch", "new", sketch_path])
-    sketch_file = sketch_path / f"{sketch_name}.ino"
-    lines = []
-    with open(sketch_file, "r") as f:
-        lines = f.readlines()
-    lines = ["#include <WiFi101.h>"] + lines
-    with open(sketch_file, "w") as f:
-        f.writelines(lines)
-
-    sketch_path_md5 = hashlib.md5(bytes(sketch_path)).hexdigest().upper()
-    build_dir = Path(tempfile.gettempdir(), f"arduino-sketch-{sketch_path_md5}")
-
-    # Compile sketch using library not managed by CLI
-    res = run_command(["compile", "-b", fqbn, "--library", manually_install_lib_path, sketch_path, "-v"])
-    assert res.ok
-    obj_path = build_dir / "libraries" / "WiFi101" / "WiFi.cpp.o"
-    assert f"Using previously compiled file: {obj_path}" not in res.stdout
-
-    # Compile again using library installed from CLI
-    res = run_command(["compile", "-b", fqbn, sketch_path, "-v"])
-    assert res.ok
-    obj_path = build_dir / "libraries" / "WiFi101" / "WiFi.cpp.o"
-    assert f"Using previously compiled file: {obj_path}" not in res.stdout
-
-
 def test_compile_with_conflicting_libraries_include(run_command, data_dir, copy_sketch):
     assert run_command(["update"])