add fqbn flag for board details command

Author: umbynos

cli/board/details.go

@@ -33,18 +33,21 @@ import (
 
 var tr = i18n.Tr
 var showFullDetails bool
+var fqbn string
 
 func initDetailsCommand() *cobra.Command {
 	var detailsCommand = &cobra.Command{
-		Use:     "details <FQBN>",
+		Use:     "details -b <FQBN>",
 		Short:   tr("Print details about a board."),
 		Long:    tr("Show information about a board, in particular if the board has options to be specified in the FQBN."),
-		Example: "  " + os.Args[0] + " board details arduino:avr:nano",
-		Args:    cobra.ExactArgs(1),
+		Example: "  " + os.Args[0] + " board details -b arduino:avr:nano",
+		Args:    cobra.NoArgs,
 		Run:     runDetailsCommand,
 	}
 
 	detailsCommand.Flags().BoolVarP(&showFullDetails, "full", "f", false, tr("Show full board details"))
+	detailsCommand.Flags().StringVarP(&fqbn, "fqbn", "b", "", "Fully Qualified Board Name, e.g.: arduino:avr:uno")
+	detailsCommand.MarkFlagRequired( "fqbn")
 
 	return detailsCommand
 }
@@ -58,7 +61,7 @@ func runDetailsCommand(cmd *cobra.Command, args []string) {
 
 	res, err := board.Details(context.Background(), &rpc.BoardDetailsReq{
 		Instance: inst,
-		Fqbn:     args[0],
+		Fqbn:     fqbn,
 	})
 
 	if err != nil {

test/test_board.py

@@ -398,7 +398,7 @@ def test_board_details(run_command):
     # Download samd core pinned to 1.8.6
     result = run_command("core install arduino:samd@1.8.6")
     assert result.ok
-    result = run_command("board details arduino:samd:nano_33_iot --format json")
+    result = run_command("board details -b arduino:samd:nano_33_iot --format json")
     assert result.ok
     # Sort everything before compare
     result = json.loads(result.stdout)
@@ -413,3 +413,28 @@ def test_board_details(run_command):
     assert result["platform"] == gold_board_details["platform"]
     for usb_id in gold_board_details["identification_pref"]:
         assert usb_id in result["identification_pref"]
+
+
+# old `arduino-cli board details` did not need -b <fqbn> flag to work
+def test_board_details_old(run_command):
+    result = run_command("core update-index")
+    assert result.ok
+    # Download samd core pinned to 1.8.6
+    result = run_command("core install arduino:samd@1.8.6")
+    assert result.ok
+    result = run_command("board details arduino:samd:nano_33_iot")
+    assert not result.ok
+    assert result.stdout == ""
+    assert 'Error: unknown command "arduino:samd:nano_33_iot" for "arduino-cli board details"' in result.stderr
+
+
+def test_board_details_no_flags(run_command):
+    result = run_command("core update-index")
+    assert result.ok
+    # Download samd core pinned to 1.8.6
+    result = run_command("core install arduino:samd@1.8.6")
+    assert result.ok
+    result = run_command("board details")
+    assert not result.ok
+    assert 'Error: required flag(s) "fqbn" not set in result.stderr'
+    assert result.stdout == ""