Made some variables private

Author: cmaglie

legacy/builder/create_cmake_rule.go

@@ -29,9 +29,9 @@ import (
 	"github.com/arduino/arduino-cli/legacy/builder/utils"
 )
 
-var ValidExportExtensions = []string{".h", ".c", ".hpp", ".hh", ".cpp", ".S", ".a", ".properties"}
-var DotHExtension = []string{".h", ".hh", ".hpp"}
-var DotAExtension = []string{".a"}
+var validExportExtensions = []string{".h", ".c", ".hpp", ".hh", ".cpp", ".S", ".a", ".properties"}
+var dotHExtension = []string{".h", ".hh", ".hpp"}
+var dotAExtension = []string{".a"}
 
 func stringArrayToLookupFunction(in []string) func(string) bool {
 	out := map[string]bool{}
@@ -73,7 +73,7 @@ func (s *ExportProjectCMake) Run(ctx *types.Context) error {
 	cmakeFile := cmakeFolder.Join("CMakeLists.txt")
 
 	dynamicLibsFromPkgConfig := map[string]bool{}
-	extensions := stringArrayToLookupFunction(ValidExportExtensions)
+	extensions := stringArrayToLookupFunction(validExportExtensions)
 	for _, library := range ctx.ImportedLibraries {
 		// Copy used libraries in the correct folder
 		libDir := libBaseFolder.Join(library.Name)
@@ -98,7 +98,7 @@ func (s *ExportProjectCMake) Run(ctx *types.Context) error {
 		}
 
 		// Remove stray folders contining incompatible or not needed libraries archives
-		files, _ := utils.FindFilesInFolder(libDir.Join("src"), true, DotAExtension)
+		files, _ := utils.FindFilesInFolder(libDir.Join("src"), true, dotAExtension)
 		for _, file := range files {
 			staticLibDir := file.Parent()
 			if !isStaticLib || !strings.Contains(staticLibDir.String(), mcu) {
@@ -134,7 +134,7 @@ func (s *ExportProjectCMake) Run(ctx *types.Context) error {
 	}
 
 	// remove "#line 1 ..." from exported c_make folder sketch
-	sketchFiles, _ := utils.FindFilesInFolder(cmakeFolder.Join("sketch"), false, ValidExportExtensions)
+	sketchFiles, _ := utils.FindFilesInFolder(cmakeFolder.Join("sketch"), false, validExportExtensions)
 
 	for _, file := range sketchFiles {
 		input, err := file.ReadFile()
@@ -168,11 +168,11 @@ func (s *ExportProjectCMake) Run(ctx *types.Context) error {
 	extractCompileFlags(ctx, "recipe.cpp.o.pattern", &defines, &dynamicLibsFromGccMinusL, &linkerflags, &linkDirectories)
 
 	// Extract folders with .h in them for adding in include list
-	headerFiles, _ := utils.FindFilesInFolder(cmakeFolder, true, DotHExtension)
+	headerFiles, _ := utils.FindFilesInFolder(cmakeFolder, true, dotHExtension)
 	foldersContainingDotH := findUniqueFoldersRelative(headerFiles.AsStrings(), cmakeFolder.String())
 
 	// Extract folders with .a in them for adding in static libs paths list
-	staticLibs, _ := utils.FindFilesInFolder(cmakeFolder, true, DotAExtension)
+	staticLibs, _ := utils.FindFilesInFolder(cmakeFolder, true, dotAExtension)
 
 	// Generate the CMakeLists global file