removed getters and related usage for version package

Author: Roberto Sora

cli/cli.go

@@ -91,8 +91,8 @@ func InitInstance() *rpc.InitResp {
 	logrus.Info("Initializing package manager")
 	req := packageManagerInitReq()
 
-	userAgentValue := fmt.Sprintf("%s/%s (%s; %s; %s) Commit:%s/Build:%s", version.GetApplication(),
-		version.GetVersion(), runtime.GOARCH, runtime.GOOS, runtime.Version(), version.GetCommit(), version.GetBuildDate())
+	userAgentValue := fmt.Sprintf("%s/%s (%s; %s; %s) Commit:%s/Build:%s", VersionInfo.Application,
+		VersionInfo.VersionString, runtime.GOARCH, runtime.GOOS, runtime.Version(), VersionInfo.Commit, VersionInfo.BuildDate)
 	downloaderHeaders := http.Header{"User-Agent": []string{userAgentValue}}
 
 	resp, err := commands.Init(context.Background(), req, OutputProgressBar(), OutputTaskProgress(), downloaderHeaders)

cli/daemon/daemon.go

@@ -27,7 +27,6 @@ import (
 	"github.com/arduino/arduino-cli/cli"
 	"github.com/arduino/arduino-cli/daemon"
 	"github.com/arduino/arduino-cli/rpc"
-	"github.com/arduino/arduino-cli/version"
 	"github.com/spf13/cobra"
 	"google.golang.org/grpc"
 )
@@ -57,12 +56,11 @@ func runDaemonCommand(cmd *cobra.Command, args []string) {
 	}
 	s := grpc.NewServer()
 
-	userAgentValue := fmt.Sprintf("%s daemon/%s (%s; %s; %s) Commit:%s/Build:%s ", version.GetApplication(),
-		version.GetVersion(), runtime.GOARCH, runtime.GOOS, runtime.Version(), version.GetCommit(), version.GetBuildDate())
+	userAgentValue := fmt.Sprintf("%s/%s daemon (%s; %s; %s) Commit:%s/Build:%s", cli.VersionInfo.Application,
+		cli.VersionInfo.VersionString, runtime.GOARCH, runtime.GOOS, runtime.Version(), cli.VersionInfo.Commit, cli.VersionInfo.BuildDate)
 	headers := http.Header{"User-Agent": []string{userAgentValue}}
 
 	coreServer := daemon.ArduinoCoreServerImpl{DownloaderHeaders: headers}
-
 	rpc.RegisterArduinoCoreServer(s, &coreServer)
 	if err := s.Serve(lis); err != nil {
 		log.Fatalf("failed to serve: %v", err)

cli/root/root.go

@@ -35,7 +35,6 @@ import (
 	"github.com/arduino/arduino-cli/cli/version"
 	"github.com/arduino/arduino-cli/common/formatter"
 	"github.com/arduino/arduino-cli/configs"
-	ver "github.com/arduino/arduino-cli/version"
 	"github.com/arduino/go-paths-helper"
 	"github.com/mattn/go-colorable"
 	"github.com/sirupsen/logrus"
@@ -49,7 +48,7 @@ func Init() *cobra.Command {
 		Use:              "arduino-cli",
 		Short:            "Arduino CLI.",
 		Long:             "Arduino Command Line Interface (arduino-cli).",
-		Example:          "  " + ver.GetAppName() + " <command> [flags...]",
+		Example:          "  " + cli.VersionInfo.Application + " <command> [flags...]",
 		PersistentPreRun: preRun,
 	}
 	command.PersistentFlags().BoolVar(&cli.GlobalFlags.Debug, "debug", false, "Enables debug output (super verbose, used to debug the CLI).")
@@ -92,7 +91,7 @@ func preRun(cmd *cobra.Command, args []string) {
 	}
 	initConfigs()
 
-	logrus.Info(ver.GetAppName() + "-" + ver.GetVersion())
+	logrus.Info(cli.VersionInfo.Application + "-" + cli.VersionInfo.VersionString)
 	logrus.Info("Starting root command preparation (`arduino`)")
 	switch outputFormat {
 	case "text":

version/version.go

@@ -29,26 +29,6 @@ var (
 	buildDate            = time.Time{}
 )
 
-func GetAppName() string {
-	return ""
-}
-
-func GetApplication() string {
-	return ""
-}
-
-func GetVersion() string {
-	return defaultVersionString
-}
-
-func GetCommit() string {
-	return commit
-}
-
-func GetBuildDate() string {
-	return ""
-}
-
 type Info struct {
 	Application   string    `json:"Application"`
 	VersionString string    `json:"VersionString"`