Skip to content

Commit 1ddb5bd

Browse files
Migrate TestAddRemoveSetDeleteOnUnexistingKey from test_config.py to config_test.go
1 parent e5c1f9e commit 1ddb5bd

File tree

2 files changed

+25
-21
lines changed

2 files changed

+25
-21
lines changed

internal/integrationtest/config/config_test.go

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -279,3 +279,28 @@ func TestDumpWithConfigFileFlag(t *testing.T) {
279279
require.NoError(t, err)
280280
requirejson.Query(t, stdout, ".board_manager | .additional_urls", "[\"https://another-url.com\"]")
281281
}
282+
283+
func TestAddRemoveSetDeleteOnUnexistingKey(t *testing.T) {
284+
env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
285+
defer env.CleanUp()
286+
287+
// Create a config file
288+
_, _, err := cli.Run("config", "init", "--dest-dir", ".")
289+
require.NoError(t, err)
290+
291+
_, stderr, err := cli.Run("config", "add", "some.key", "some_value")
292+
require.Error(t, err)
293+
require.Contains(t, string(stderr), "Settings key doesn't exist")
294+
295+
_, stderr, err = cli.Run("config", "remove", "some.key", "some_value")
296+
require.Error(t, err)
297+
require.Contains(t, string(stderr), "Settings key doesn't exist")
298+
299+
_, stderr, err = cli.Run("config", "set", "some.key", "some_value")
300+
require.Error(t, err)
301+
require.Contains(t, string(stderr), "Settings key doesn't exist")
302+
303+
_, stderr, err = cli.Run("config", "delete", "some.key")
304+
require.Error(t, err)
305+
require.Contains(t, string(stderr), "Settings key doesn't exist")
306+
}

test/test_config.py

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -17,27 +17,6 @@
1717
import yaml
1818

1919

20-
def test_add_remove_set_delete_on_unexisting_key(run_command):
21-
# Create a config file
22-
assert run_command(["config", "init", "--dest-dir", "."])
23-
24-
res = run_command(["config", "add", "some.key", "some_value"])
25-
assert res.failed
26-
assert "Settings key doesn't exist" in res.stderr
27-
28-
res = run_command(["config", "remove", "some.key", "some_value"])
29-
assert res.failed
30-
assert "Settings key doesn't exist" in res.stderr
31-
32-
res = run_command(["config", "set", "some.key", "some_value"])
33-
assert res.failed
34-
assert "Settings key doesn't exist" in res.stderr
35-
36-
res = run_command(["config", "delete", "some.key"])
37-
assert res.failed
38-
assert "Settings key doesn't exist" in res.stderr
39-
40-
4120
def test_add_single_argument(run_command):
4221
# Create a config file
4322
assert run_command(["config", "init", "--dest-dir", "."])

0 commit comments

Comments
 (0)