Migrated TestCompileWithSimpleSketch from test_compile_part_1.py to compile_part_1_test.go

Author: MatteoPologruto

internal/integrationtest/compile/compile_part_1_test.go

@@ -16,6 +16,10 @@
 package compile_part_1_test
 
 import (
+	"crypto/md5"
+	"encoding/hex"
+	"encoding/json"
+	"strings"
 	"testing"
 
 	"github.com/arduino/arduino-cli/internal/integrationtest"
@@ -84,3 +88,58 @@ func TestCompileErrorMessage(t *testing.T) {
 	require.Error(t, err)
 	require.Contains(t, string(stderr), "main file missing from sketch:")
 }
+
+func TestCompileWithSimpleSketch(t *testing.T) {
+	env, cli := integrationtest.CreateArduinoCLIWithEnvironment(t)
+	defer env.CleanUp()
+
+	// Init the environment explicitly
+	_, _, err := cli.Run("core", "update-index")
+	require.NoError(t, err)
+
+	// Download latest AVR
+	_, _, err = cli.Run("core", "install", "arduino:avr")
+	require.NoError(t, err)
+
+	sketchName := "CompileIntegrationTest"
+	sketchPath := cli.SketchbookDir().Join(sketchName)
+	fqbn := "arduino:avr:uno"
+
+	// Create a test sketch
+	stdout, _, err := cli.Run("sketch", "new", sketchPath.String())
+	require.NoError(t, err)
+	require.Contains(t, string(stdout), "Sketch created in: "+sketchPath.String())
+
+	// Build sketch for arduino:avr:uno
+	_, _, err = cli.Run("compile", "-b", fqbn, sketchPath.String())
+	require.NoError(t, err)
+
+	// Build sketch for arduino:avr:uno with json output
+	stdout, _, err = cli.Run("compile", "-b", fqbn, sketchPath.String(), "--format", "json")
+	require.NoError(t, err)
+	// check is a valid json and contains requested data
+	var compileOutput map[string]interface{}
+	err = json.Unmarshal(stdout, &compileOutput)
+	require.NoError(t, err)
+	require.NotEmpty(t, compileOutput["compiler_out"])
+	require.Empty(t, compileOutput["compiler_err"])
+
+	// Verifies expected binaries have been built
+	md5 := md5.Sum(([]byte(sketchPath.String())))
+	sketchPathMd5 := strings.ToUpper(hex.EncodeToString(md5[:]))
+	require.NotEmpty(t, sketchPathMd5)
+	buildDir := paths.TempDir().Join("arduino-sketch-" + sketchPathMd5)
+	require.FileExists(t, buildDir.Join(sketchName+".ino.eep").String())
+	require.FileExists(t, buildDir.Join(sketchName+".ino.elf").String())
+	require.FileExists(t, buildDir.Join(sketchName+".ino.hex").String())
+	require.FileExists(t, buildDir.Join(sketchName+".ino.with_bootloader.bin").String())
+	require.FileExists(t, buildDir.Join(sketchName+".ino.with_bootloader.hex").String())
+
+	// Verifies binaries are not exported by default to Sketch folder
+	sketchBuildDir := sketchPath.Join("build" + strings.ReplaceAll(fqbn, ":", "."))
+	require.NoFileExists(t, sketchBuildDir.Join(sketchName+".ino.eep").String())
+	require.NoFileExists(t, sketchBuildDir.Join(sketchName+".ino.elf").String())
+	require.NoFileExists(t, sketchBuildDir.Join(sketchName+".ino.hex").String())
+	require.NoFileExists(t, sketchBuildDir.Join(sketchName+".ino.with_bootloader.bin").String())
+	require.NoFileExists(t, sketchBuildDir.Join(sketchName+".ino.with_bootloader.hex").String())
+}

test/test_compile_part_1.py

@@ -25,52 +25,6 @@
 from .common import running_on_ci
 
 
-def test_compile_with_simple_sketch(run_command, data_dir, working_dir):
-    # Init the environment explicitly
-    run_command(["core", "update-index"])
-
-    # Download latest AVR
-    run_command(["core", "install", "arduino:avr"])
-
-    sketch_name = "CompileIntegrationTest"
-    sketch_path = Path(data_dir, sketch_name)
-    fqbn = "arduino:avr:uno"
-
-    # Create a test sketch
-    result = run_command(["sketch", "new", sketch_path])
-    assert result.ok
-    assert f"Sketch created in: {sketch_path}" in result.stdout
-
-    # Build sketch for arduino:avr:uno
-    result = run_command(["compile", "-b", fqbn, sketch_path])
-    assert result.ok
-
-    # Build sketch for arduino:avr:uno with json output
-    result = run_command(["compile", "-b", fqbn, sketch_path, "--format", "json"])
-    assert result.ok
-    # check is a valid json and contains requested data
-    compile_output = json.loads(result.stdout)
-    assert compile_output["compiler_out"] != ""
-    assert compile_output["compiler_err"] == ""
-
-    # Verifies expected binaries have been built
-    sketch_path_md5 = hashlib.md5(bytes(sketch_path)).hexdigest().upper()
-    build_dir = Path(tempfile.gettempdir(), f"arduino-sketch-{sketch_path_md5}")
-    assert (build_dir / f"{sketch_name}.ino.eep").exists()
-    assert (build_dir / f"{sketch_name}.ino.elf").exists()
-    assert (build_dir / f"{sketch_name}.ino.hex").exists()
-    assert (build_dir / f"{sketch_name}.ino.with_bootloader.bin").exists()
-    assert (build_dir / f"{sketch_name}.ino.with_bootloader.hex").exists()
-
-    # Verifies binaries are not exported by default to Sketch folder
-    sketch_build_dir = Path(sketch_path, "build", fqbn.replace(":", "."))
-    assert not (sketch_build_dir / f"{sketch_name}.ino.eep").exists()
-    assert not (sketch_build_dir / f"{sketch_name}.ino.elf").exists()
-    assert not (sketch_build_dir / f"{sketch_name}.ino.hex").exists()
-    assert not (sketch_build_dir / f"{sketch_name}.ino.with_bootloader.bin").exists()
-    assert not (sketch_build_dir / f"{sketch_name}.ino.with_bootloader.hex").exists()
-
-
 @pytest.mark.skipif(
     running_on_ci() and platform.system() == "Windows",
     reason="Test disabled on Github Actions Win VM until tmpdir inconsistent behavior bug is fixed",