Skip to content

Commit 19bc30f

Browse files
committed
Added test for serial pluggable-monitor compatibility conversion
1 parent e6e0d24 commit 19bc30f

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

arduino/cores/packagemanager/package_manager_test.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -460,6 +460,7 @@ func TestLegacyPackageConversionToPluggableDiscovery(t *testing.T) {
460460
platformProps := platformRelease.Properties
461461
require.Equal(t, "builtin:serial-discovery", platformProps.Get("pluggable_discovery.required.0"))
462462
require.Equal(t, "builtin:mdns-discovery", platformProps.Get("pluggable_discovery.required.1"))
463+
require.Equal(t, "builtin:serial-monitor", platformProps.Get("pluggable_monitor.required.serial"))
463464
require.Equal(t, "{runtime.tools.esptool.path}", platformProps.Get("tools.esptool__pluggable_network.path"))
464465
require.Contains(t, platformProps.Get("tools.esptool__pluggable_network.cmd"), "esptool")
465466
require.Contains(t, platformProps.Get("tools.esptool__pluggable_network.network_cmd"), "{runtime.platform.path}/tools/espota")
@@ -481,6 +482,7 @@ func TestLegacyPackageConversionToPluggableDiscovery(t *testing.T) {
481482
platformProps := platformRelease.Properties
482483
require.Equal(t, "builtin:serial-discovery", platformProps.Get("pluggable_discovery.required.0"))
483484
require.Equal(t, "builtin:mdns-discovery", platformProps.Get("pluggable_discovery.required.1"))
485+
require.Equal(t, "builtin:serial-monitor", platformProps.Get("pluggable_monitor.required.serial"))
484486
require.Equal(t, "", platformProps.Get("tools.esptool__pluggable_network.path"))
485487
require.Equal(t, "{runtime.tools.python3.path}/python3", platformProps.Get("tools.esptool__pluggable_network.cmd"))
486488
require.Equal(t, "{runtime.tools.python3.path}/python3", platformProps.Get("tools.esptool__pluggable_network.network_cmd"))
@@ -502,6 +504,7 @@ func TestLegacyPackageConversionToPluggableDiscovery(t *testing.T) {
502504
platformProps := platformRelease.Properties
503505
require.Equal(t, "builtin:serial-discovery", platformProps.Get("pluggable_discovery.required.0"))
504506
require.Equal(t, "builtin:mdns-discovery", platformProps.Get("pluggable_discovery.required.1"))
507+
require.Equal(t, "builtin:serial-monitor", platformProps.Get("pluggable_monitor.required.serial"))
505508
require.Equal(t, `"{network_cmd}" -address {upload.port.address} -port {upload.port.properties.port} -sketch "{build.path}/{build.project_name}.hex" -upload {upload.port.properties.endpoint_upload} -sync {upload.port.properties.endpoint_sync} -reset {upload.port.properties.endpoint_reset} -sync_exp {upload.port.properties.sync_return}`, platformProps.Get("tools.avrdude__pluggable_network.upload.pattern"))
506509
}
507510
}

0 commit comments

Comments
 (0)