Moved some flags in the command creation

This will turn out useful in the following commits

Author: cmaglie

cli/core/install.go

@@ -31,12 +31,9 @@ import (
 	"github.com/spf13/cobra"
 )
 
-var (
-	postInstallFlags arguments.PostInstallFlags
-	noOverwrite      bool
-)
-
 func initInstallCommand() *cobra.Command {
+	var noOverwrite bool
+	var postInstallFlags arguments.PostInstallFlags
 	installCommand := &cobra.Command{
 		Use:   fmt.Sprintf("install %s:%s[@%s]...", tr("PACKAGER"), tr("ARCH"), tr("VERSION")),
 		Short: tr("Installs one or more cores and corresponding tool dependencies."),
@@ -49,7 +46,9 @@ func initInstallCommand() *cobra.Command {
 		PreRun: func(cmd *cobra.Command, args []string) {
 			arguments.CheckFlagsConflicts(cmd, "run-post-install", "skip-post-install")
 		},
-		Run: runInstallCommand,
+		Run: func(cmd *cobra.Command, args []string) {
+			runInstallCommand(args, postInstallFlags, noOverwrite)
+		},
 		ValidArgsFunction: func(cmd *cobra.Command, args []string, toComplete string) ([]string, cobra.ShellCompDirective) {
 			return arguments.GetInstallableCores(), cobra.ShellCompDirectiveDefault
 		},
@@ -59,7 +58,7 @@ func initInstallCommand() *cobra.Command {
 	return installCommand
 }
 
-func runInstallCommand(cmd *cobra.Command, args []string) {
+func runInstallCommand(args []string, postInstallFlags arguments.PostInstallFlags, noOverwrite bool) {
 	inst := instance.CreateAndInit()
 	logrus.Info("Executing `arduino-cli core install`")
 

cli/core/upgrade.go

@@ -34,6 +34,7 @@ import (
 )
 
 func initUpgradeCommand() *cobra.Command {
+	var postInstallFlags arguments.PostInstallFlags
 	upgradeCommand := &cobra.Command{
 		Use:   fmt.Sprintf("upgrade [%s:%s] ...", tr("PACKAGER"), tr("ARCH")),
 		Short: tr("Upgrades one or all installed platforms to the latest version."),
@@ -43,16 +44,22 @@ func initUpgradeCommand() *cobra.Command {
 			"  " + os.Args[0] + " core upgrade\n\n" +
 			"  # " + tr("upgrade arduino:samd to the latest version") + "\n" +
 			"  " + os.Args[0] + " core upgrade arduino:samd",
-		Run: runUpgradeCommand,
+		Run: func(cmd *cobra.Command, args []string) {
+			runUpgradeCommand(args, postInstallFlags.DetectSkipPostInstallValue())
+		},
 	}
 	postInstallFlags.AddToCommand(upgradeCommand)
 	return upgradeCommand
 }
 
-func runUpgradeCommand(cmd *cobra.Command, args []string) {
+func runUpgradeCommand(args []string, skipPostInstall bool) {
 	inst := instance.CreateAndInit()
 	logrus.Info("Executing `arduino-cli core upgrade`")
+	Upgrade(inst, args, skipPostInstall)
+}
 
+// Upgrade upgrades one or all installed platforms to the latest version.
+func Upgrade(inst *rpc.Instance, args []string, skipPostInstall bool) {
 	// if no platform was passed, upgrade allthethings
 	if len(args) == 0 {
 		targets, err := core.GetPlatforms(&rpc.PlatformListRequest{
@@ -93,7 +100,7 @@ func runUpgradeCommand(cmd *cobra.Command, args []string) {
 			Instance:        inst,
 			PlatformPackage: platformRef.PackageName,
 			Architecture:    platformRef.Architecture,
-			SkipPostInstall: postInstallFlags.DetectSkipPostInstallValue(),
+			SkipPostInstall: skipPostInstall,
 		}
 
 		if _, err := core.PlatformUpgrade(context.Background(), r, output.ProgressBar(), output.TaskProgress()); err != nil {