Made 'core search' logic identical to Arduino IDE 1.8.x search dialog

Author: cmaglie

commands/core/search.go

@@ -29,58 +29,54 @@ import (
 
 // PlatformSearch FIXMEDOC
 func PlatformSearch(req *rpc.PlatformSearchRequest) (*rpc.PlatformSearchResponse, error) {
-	searchArgs := strings.TrimSpace(req.SearchArgs)
-	allVersions := req.AllVersions
 	pme, release := commands.GetPackageManagerExplorer(req)
 	if pme == nil {
 		return nil, &arduino.InvalidInstanceError{}
 	}
 	defer release()
 
 	res := []*cores.PlatformRelease{}
-	if isUsb, _ := regexp.MatchString("[0-9a-f]{4}:[0-9a-f]{4}", searchArgs); isUsb {
-		vid, pid := searchArgs[:4], searchArgs[5:]
+	if isUsb, _ := regexp.MatchString("[0-9a-f]{4}:[0-9a-f]{4}", req.SearchArgs); isUsb {
+		vid, pid := req.SearchArgs[:4], req.SearchArgs[5:]
 		res = pme.FindPlatformReleaseProvidingBoardsWithVidPid(vid, pid)
 	} else {
-
+		searchArgs := rpc.SearchTermsFromQueryString(req.SearchArgs)
+		allVersions := req.AllVersions
 		for _, targetPackage := range pme.GetPackages() {
 			for _, platform := range targetPackage.Platforms {
-				// discard invalid platforms
 				// Users can install platforms manually in the Sketchbook hardware folder,
 				// the core search command must operate only on platforms installed through
 				// the PlatformManager, thus we skip the manually installed ones.
 				if platform == nil || platform.Name == "" || platform.ManuallyInstalled {
 					continue
 				}
 
-				// discard invalid releases
-				platformRelease := platform.GetLatestRelease()
-				if platformRelease == nil {
+				// Discard platforms with no releases
+				latestRelease := platform.GetLatestRelease()
+				if latestRelease == nil {
 					continue
 				}
 
 				// Gather all strings that can be used for searching
-				toTest := []string{
-					platform.String(),
-					platform.Name,
-					platform.Architecture,
-					targetPackage.Name,
-					targetPackage.Maintainer,
-					targetPackage.WebsiteURL,
-				}
-				for _, board := range platformRelease.BoardsManifest {
-					toTest = append(toTest, board.Name)
+				toTest := platform.String() + " " +
+					platform.Name + " " +
+					platform.Architecture + " " +
+					targetPackage.Name + " " +
+					targetPackage.Maintainer + " " +
+					targetPackage.WebsiteURL
+				for _, board := range latestRelease.BoardsManifest {
+					toTest += board.Name + " "
 				}
 
 				// Search
-				if !utils.MatchAny(searchArgs, toTest) {
+				if !utils.Match(toTest, searchArgs) {
 					continue
 				}
 
 				if allVersions {
 					res = append(res, platform.GetAllReleases()...)
 				} else {
-					res = append(res, platformRelease)
+					res = append(res, latestRelease)
 				}
 			}
 		}