ModulinoKnob: fix bug on set() and apply workaround

Author: facchinm

src/Modulino.h

@@ -220,6 +220,20 @@ class ModulinoKnob : public Module {
 public:
   ModulinoKnob(uint8_t address = 0xFF)
     : Module(address, "ENCODER") {}
+  bool begin() {
+    auto ret = Module::begin();
+    if (ret) {
+      // check for set() bug
+      auto _val = get();
+      set(100);
+      if (get() != 100) {
+        _bug_on_set = true;
+        set(-_val);
+      } else {
+        set(_val);
+      }
+    }
+  }
   int16_t get() {
     uint8_t buf[3];
     auto res = read(buf, 3);
@@ -231,6 +245,9 @@ class ModulinoKnob : public Module {
     return ret;
   }
   void set(int16_t value) {
+    if (_bug_on_set) {
+      value = -value;
+    }
     uint8_t buf[4];
     memcpy(buf, &value, 2);
     write(buf, 4);
@@ -248,6 +265,7 @@ class ModulinoKnob : public Module {
   }
 private:
   bool _pressed = false;
+  bool _bug_on_set = false;
 protected:
   std::vector<uint8_t> match = { 0x74, 0x76 };
 };

src/fw.h

@@ -95,16 +95,16 @@ unsigned char node_base_bin[] = {
   0x1a, 0x78, 0x00, 0x2a, 0x03, 0xd0, 0x00, 0x22, 0x06, 0x20, 0x1a, 0x70,
   0x16, 0xbd, 0x1d, 0x4b, 0x1d, 0x4c, 0x1b, 0x78, 0x23, 0x70, 0x76, 0x2b,
   0x06, 0xd0, 0x13, 0xd8, 0x20, 0x20, 0x6c, 0x2b, 0xf4, 0xd0, 0x1d, 0x38,
-  0x74, 0x2b, 0xf1, 0xd1, 0x6a, 0x46, 0x18, 0x4b, 0x91, 0x1d, 0x1b, 0x68,
-  0x17, 0x4a, 0x5b, 0x6a, 0x12, 0x88, 0x17, 0x48, 0x9b, 0x1a, 0x02, 0x22,
+  0x74, 0x2b, 0xf1, 0xd1, 0x18, 0x4b, 0x19, 0x48, 0x1b, 0x68, 0x5a, 0x6a,
+  0x6b, 0x46, 0x99, 0x1d, 0x17, 0x4b, 0x1b, 0x88, 0x9b, 0x18, 0x02, 0x22,
   0x0b, 0x80, 0x02, 0xf0, 0xcf, 0xfc, 0x12, 0xe0, 0x03, 0x20, 0x7c, 0x2b,
   0xe0, 0xd1, 0xa0, 0x20, 0x01, 0x21, 0xc0, 0x05, 0x01, 0xf0, 0x2a, 0xf8,
   0x43, 0x42, 0x58, 0x41, 0x60, 0x70, 0xa0, 0x20, 0x02, 0x21, 0xc0, 0x05,
   0x01, 0xf0, 0x22, 0xf8, 0x43, 0x42, 0x58, 0x41, 0xa0, 0x70, 0xa0, 0x20,
   0x04, 0x21, 0xc0, 0x05, 0x01, 0xf0, 0x1a, 0xf8, 0x43, 0x42, 0x58, 0x41,
   0xe0, 0x70, 0x03, 0x20, 0xc6, 0xe7, 0xc0, 0x46, 0x28, 0x00, 0x00, 0x20,
   0x2c, 0x00, 0x00, 0x20, 0x2e, 0x00, 0x00, 0x20, 0xb0, 0x00, 0x00, 0x20,
-  0x2a, 0x00, 0x00, 0x20, 0x2f, 0x00, 0x00, 0x20, 0x08, 0x4b, 0x20, 0x20,
+  0x2f, 0x00, 0x00, 0x20, 0x2a, 0x00, 0x00, 0x20, 0x08, 0x4b, 0x20, 0x20,
   0x1b, 0x78, 0x6c, 0x2b, 0x04, 0xd0, 0x04, 0xd8, 0x1d, 0x38, 0x3c, 0x2b,
   0x00, 0xd1, 0x05, 0x30, 0x70, 0x47, 0x02, 0x22, 0x93, 0x43, 0x74, 0x3b,
   0x5a, 0x42, 0x53, 0x41, 0xd8, 0x1c, 0xf7, 0xe7, 0x2c, 0x00, 0x00, 0x20,
@@ -126,64 +126,64 @@ unsigned char node_base_bin[] = {
   0x00, 0x93, 0x00, 0xf0, 0xcf, 0xfc, 0x00, 0x28, 0x01, 0xd0, 0x72, 0xb6,
   0xfe, 0xe7, 0x0d, 0xb0, 0x00, 0xbd, 0x00, 0x00, 0xf0, 0xb5, 0x8f, 0xb0,
   0x00, 0xf0, 0x9c, 0xfa, 0xff, 0xf7, 0xcc, 0xff, 0x01, 0x21, 0x02, 0x24,
-  0x04, 0x25, 0xb0, 0x4b, 0x0a, 0xa8, 0x5a, 0x6b, 0x09, 0xae, 0x0a, 0x43,
+  0x04, 0x26, 0xb0, 0x4b, 0x0a, 0xa8, 0x5a, 0x6b, 0x09, 0xad, 0x0a, 0x43,
   0x5a, 0x63, 0x5a, 0x6b, 0x0a, 0x40, 0x03, 0x92, 0x03, 0x9a, 0x5a, 0x6b,
   0x1f, 0x31, 0x22, 0x43, 0x5a, 0x63, 0x5a, 0x6b, 0x22, 0x40, 0x04, 0x92,
-  0x04, 0x9a, 0x5a, 0x6b, 0x2a, 0x43, 0x5a, 0x63, 0x5a, 0x6b, 0x2a, 0x40,
+  0x04, 0x9a, 0x5a, 0x6b, 0x32, 0x43, 0x5a, 0x63, 0x5a, 0x6b, 0x32, 0x40,
   0x05, 0x92, 0x05, 0x9a, 0x5a, 0x6b, 0x0a, 0x43, 0x5a, 0x63, 0x5b, 0x6b,
   0x10, 0x22, 0x0b, 0x40, 0x06, 0x93, 0x00, 0x21, 0x06, 0x9b, 0x02, 0xf0,
-  0xd2, 0xfb, 0xe0, 0x23, 0xa0, 0x20, 0x5b, 0x00, 0x31, 0x00, 0xc0, 0x05,
-  0x09, 0x93, 0xb4, 0x60, 0x00, 0xf0, 0xa6, 0xfe, 0xc0, 0x23, 0x31, 0x00,
-  0x1b, 0x02, 0x99, 0x48, 0x09, 0x93, 0x00, 0xf0, 0x9f, 0xfe, 0x31, 0x00,
-  0x97, 0x48, 0x09, 0x95, 0x00, 0xf0, 0x9a, 0xfe, 0xa0, 0x20, 0x40, 0x21,
+  0xd2, 0xfb, 0xe0, 0x23, 0xa0, 0x20, 0x5b, 0x00, 0x29, 0x00, 0xc0, 0x05,
+  0x09, 0x93, 0xac, 0x60, 0x00, 0xf0, 0xa6, 0xfe, 0xc0, 0x23, 0x29, 0x00,
+  0x1b, 0x02, 0x99, 0x48, 0x09, 0x93, 0x00, 0xf0, 0x9f, 0xfe, 0x29, 0x00,
+  0x97, 0x48, 0x09, 0x96, 0x00, 0xf0, 0x9a, 0xfe, 0xa0, 0x20, 0x40, 0x21,
   0xc0, 0x05, 0x00, 0xf0, 0x49, 0xff, 0x04, 0x00, 0xa0, 0x20, 0x80, 0x21,
   0xc0, 0x05, 0x00, 0xf0, 0x43, 0xff, 0xa4, 0x01, 0x40, 0x01, 0x04, 0x43,
   0x80, 0x21, 0xa0, 0x20, 0x49, 0x00, 0xc0, 0x05, 0x00, 0xf0, 0x3a, 0xff,
-  0x80, 0x21, 0xa8, 0x40, 0x64, 0xb2, 0x04, 0x43, 0xc9, 0x01, 0x88, 0x48,
+  0x80, 0x21, 0xb0, 0x40, 0x64, 0xb2, 0x04, 0x43, 0xc9, 0x01, 0x88, 0x48,
   0x00, 0xf0, 0x32, 0xff, 0x80, 0x21, 0xc0, 0x00, 0x64, 0xb2, 0x04, 0x43,
   0x09, 0x02, 0x84, 0x48, 0x00, 0xf0, 0x2a, 0xff, 0x64, 0xb2, 0x80, 0x00,
-  0x29, 0x00, 0x04, 0x43, 0x81, 0x48, 0x00, 0xf0, 0x23, 0xff, 0x81, 0x4a,
+  0x31, 0x00, 0x04, 0x43, 0x81, 0x48, 0x00, 0xf0, 0x23, 0xff, 0x81, 0x4a,
   0x64, 0xb2, 0x40, 0x00, 0x80, 0x4b, 0x04, 0x43, 0x00, 0x92, 0x12, 0x78,
   0xe4, 0xb2, 0x1c, 0x70, 0x01, 0x93, 0x51, 0x1e, 0x7d, 0x4b, 0xc9, 0xb2,
   0x1c, 0x70, 0xfd, 0x29, 0x06, 0xd8, 0x00, 0x99, 0x48, 0x78, 0x33, 0x21,
-  0x51, 0x40, 0x88, 0x42, 0x00, 0xd1, 0x1a, 0x70, 0x78, 0x4d, 0x1b, 0x78,
-  0x78, 0x4a, 0xab, 0x60, 0x01, 0x23, 0x2a, 0x60, 0x77, 0x4a, 0xeb, 0x60,
-  0x6a, 0x60, 0x80, 0x22, 0x00, 0x23, 0x12, 0x03, 0x28, 0x00, 0x2b, 0x61,
-  0xea, 0x61, 0x2b, 0x62, 0x00, 0xf0, 0xd0, 0xff, 0x01, 0x1e, 0x01, 0xd0,
-  0x72, 0xb6, 0xfe, 0xe7, 0x28, 0x00, 0x01, 0xf0, 0x53, 0xfe, 0x01, 0x1e,
-  0x01, 0xd0, 0x72, 0xb6, 0xfe, 0xe7, 0x28, 0x00, 0x01, 0xf0, 0x72, 0xfe,
+  0x51, 0x40, 0x88, 0x42, 0x00, 0xd1, 0x1a, 0x70, 0x78, 0x4e, 0x1b, 0x78,
+  0x78, 0x4a, 0xb3, 0x60, 0x01, 0x23, 0x32, 0x60, 0x77, 0x4a, 0xf3, 0x60,
+  0x72, 0x60, 0x80, 0x22, 0x00, 0x23, 0x12, 0x03, 0x30, 0x00, 0x33, 0x61,
+  0xf2, 0x61, 0x33, 0x62, 0x00, 0xf0, 0xd0, 0xff, 0x01, 0x1e, 0x01, 0xd0,
+  0x72, 0xb6, 0xfe, 0xe7, 0x30, 0x00, 0x01, 0xf0, 0x53, 0xfe, 0x01, 0x1e,
+  0x01, 0xd0, 0x72, 0xb6, 0xfe, 0xe7, 0x30, 0x00, 0x01, 0xf0, 0x72, 0xfe,
   0x00, 0x28, 0x01, 0xd0, 0x72, 0xb6, 0xfe, 0xe7, 0x69, 0x4f, 0x6a, 0x4b,
   0x78, 0x60, 0x3b, 0x60, 0x69, 0x4b, 0x38, 0x00, 0xfb, 0x60, 0xbb, 0x60,
   0x01, 0xf0, 0x90, 0xfe, 0x04, 0x1e, 0x01, 0xd0, 0x72, 0xb6, 0xfe, 0xe7,
   0x02, 0x00, 0x01, 0x00, 0x17, 0x20, 0x00, 0xf0, 0x03, 0xfa, 0x17, 0x20,
-  0x00, 0xf0, 0x2a, 0xfa, 0xff, 0xf7, 0x98, 0xfd, 0x28, 0x00, 0x01, 0xf0,
+  0x00, 0xf0, 0x2a, 0xfa, 0xff, 0xf7, 0x98, 0xfd, 0x30, 0x00, 0x01, 0xf0,
   0xdb, 0xf8, 0x38, 0x00, 0x01, 0xf0, 0xae, 0xfe, 0x00, 0x2c, 0x07, 0xd0,
   0x00, 0xf0, 0xee, 0xf9, 0xa0, 0x42, 0x04, 0xd9, 0x00, 0x21, 0x5a, 0x48,
-  0x02, 0xf0, 0x74, 0xfa, 0x00, 0x24, 0x59, 0x4d, 0x2b, 0x78, 0x00, 0x2b,
+  0x02, 0xf0, 0x74, 0xfa, 0x00, 0x24, 0x59, 0x4e, 0x33, 0x78, 0x00, 0x2b,
   0xed, 0xd0, 0x58, 0x49, 0x0a, 0x78, 0x44, 0x2a, 0x07, 0xd1, 0x4b, 0x78,
   0x49, 0x2b, 0x35, 0xd1, 0x8b, 0x78, 0x45, 0x2b, 0x32, 0xd1, 0xff, 0xf7,
   0x23, 0xfd, 0x43, 0x2a, 0x2e, 0xd1, 0x4b, 0x78, 0x46, 0x2b, 0x2b, 0xd1,
-  0x32, 0x00, 0x50, 0x4b, 0x8c, 0x78, 0x83, 0xcb, 0x83, 0xc2, 0x00, 0xf0,
-  0x17, 0xfd, 0x02, 0xa9, 0x30, 0x00, 0x00, 0xf0, 0xa3, 0xfd, 0x33, 0x22,
+  0x2a, 0x00, 0x50, 0x4b, 0x8c, 0x78, 0x83, 0xcb, 0x83, 0xc2, 0x00, 0xf0,
+  0x17, 0xfd, 0x02, 0xa9, 0x28, 0x00, 0x00, 0xf0, 0xa3, 0xfd, 0x33, 0x22,
   0x07, 0xab, 0x62, 0x40, 0x1c, 0x70, 0x9c, 0x70, 0x1c, 0x71, 0x9c, 0x71,
   0x5a, 0x70, 0xda, 0x70, 0x5a, 0x71, 0xda, 0x71, 0x07, 0x9a, 0x08, 0x9b,
   0x00, 0x99, 0x01, 0x20, 0x00, 0xf0, 0x50, 0xfd, 0x01, 0x22, 0x43, 0x4b,
-  0x1a, 0x70, 0x00, 0x23, 0x2b, 0x70, 0x00, 0xf0, 0x0d, 0xfd, 0xbf, 0xf3,
+  0x1a, 0x70, 0x00, 0x23, 0x33, 0x70, 0x00, 0xf0, 0x0d, 0xfd, 0xbf, 0xf3,
   0x4f, 0x8f, 0x40, 0x4b, 0x40, 0x4a, 0xda, 0x60, 0xbf, 0xf3, 0x4f, 0x8f,
   0xc0, 0x46, 0xfd, 0xe7, 0x01, 0x9b, 0x1b, 0x78, 0x74, 0x2b, 0x42, 0xd0,
   0x07, 0xd8, 0x3c, 0x2b, 0x25, 0xd0, 0x6c, 0x2b, 0x49, 0xd0, 0x00, 0x22,
   0x33, 0x4b, 0x1a, 0x70, 0xa3, 0xe7, 0x76, 0x2b, 0x37, 0xd0, 0x7c, 0x2b,
   0xf7, 0xd1, 0x53, 0x1e, 0x9a, 0x41, 0xa0, 0x20, 0x08, 0x21, 0xd2, 0xb2,
-  0xc0, 0x05, 0x00, 0xf0, 0x6b, 0xfe, 0x2d, 0x4d, 0xa0, 0x20, 0x6a, 0x78,
+  0xc0, 0x05, 0x00, 0xf0, 0x6b, 0xfe, 0x2d, 0x4e, 0xa0, 0x20, 0x72, 0x78,
   0x10, 0x21, 0x53, 0x1e, 0x9a, 0x41, 0xc0, 0x05, 0xd2, 0xb2, 0x00, 0xf0,
-  0x61, 0xfe, 0xaa, 0x78, 0xa0, 0x20, 0x53, 0x1e, 0x9a, 0x41, 0x20, 0x21,
+  0x61, 0xfe, 0xb2, 0x78, 0xa0, 0x20, 0x53, 0x1e, 0x9a, 0x41, 0x20, 0x21,
   0xd2, 0xb2, 0xc0, 0x05, 0x00, 0xf0, 0x58, 0xfe, 0xdb, 0xe7, 0x04, 0x22,
-  0x07, 0xa8, 0x02, 0xf0, 0xe9, 0xfa, 0x04, 0x22, 0x25, 0x49, 0x30, 0x00,
+  0x07, 0xa8, 0x02, 0xf0, 0xe9, 0xfa, 0x04, 0x22, 0x25, 0x49, 0x28, 0x00,
   0x02, 0xf0, 0xe4, 0xfa, 0x00, 0xf0, 0x6e, 0xf9, 0x09, 0x9c, 0x07, 0x99,
   0x04, 0x19, 0x22, 0x48, 0xff, 0xf7, 0x2e, 0xfc, 0x21, 0x4b, 0x00, 0x21,
   0xd8, 0x62, 0x40, 0x08, 0x58, 0x63, 0x16, 0x48, 0x02, 0xf0, 0x9a, 0xf9,
-  0xc1, 0xe7, 0x1e, 0x4d, 0x02, 0x22, 0x28, 0x00, 0x02, 0xf0, 0xce, 0xfa,
-  0x11, 0x4b, 0x1b, 0x68, 0x5a, 0x6a, 0x2b, 0x88, 0x9b, 0x18, 0x2b, 0x80,
+  0xc1, 0xe7, 0x02, 0x22, 0x28, 0x00, 0x02, 0xf0, 0xcf, 0xfa, 0x12, 0x4b,
+  0x2a, 0x88, 0x1b, 0x68, 0x59, 0x6a, 0x1a, 0x4b, 0x52, 0x1a, 0x1a, 0x80,
   0xb5, 0xe7, 0x08, 0x00, 0xff, 0xf7, 0xbe, 0xfc, 0xb1, 0xe7, 0xc0, 0x46,
   0x00, 0x10, 0x02, 0x40, 0x00, 0x08, 0x00, 0x50, 0x00, 0x14, 0x00, 0x50,
   0x00, 0x38, 0x00, 0x08, 0x2c, 0x00, 0x00, 0x20, 0x2d, 0x00, 0x00, 0x20,