leds: avoid easy buffer overflow

facchinm · facchinm · commit 61e0b3004b34 · 2024-04-05T17:01:04.000+02:00
diff --git a/src/Modulino.h b/src/Modulino.h
@@ -184,8 +184,10 @@ class ModulinoPixels : public Module {
     Module::begin();
   }
   void set(int idx, ModulinoColor rgb, uint8_t brightness = 25) {
-    uint8_t _brightness = map(brightness, 0, 100, 0, 0x1F);
-    data[idx] = (uint32_t)rgb | _brightness | 0xE0;
+    if (idx < NUMLEDS) {
+      uint8_t _brightness = map(brightness, 0, 100, 0, 0x1F);
+      data[idx] = (uint32_t)rgb | _brightness | 0xE0;
+    }
   }
   void set(int idx, uint8_t r, uint8_t g, uint8_t b, uint8_t brightness = 5) {
     set(idx, ModulinoColor(r,g,b), brightness);

Original file line number	Diff line number	Diff line change
`@@ -184,8 +184,10 @@ class ModulinoPixels : public Module {`
`184`	`184`	`Module::begin();`
`185`	`185`	`}`
`186`	`186`	`void set(int idx, ModulinoColor rgb, uint8_t brightness = 25) {`
`187`		`- uint8_t _brightness = map(brightness, 0, 100, 0, 0x1F);`
`188`		`- data[idx] = (uint32_t)rgb \| _brightness \| 0xE0;`
	`187`	`+ if (idx < NUMLEDS) {`
	`188`	`+ uint8_t _brightness = map(brightness, 0, 100, 0, 0x1F);`
	`189`	`+ data[idx] = (uint32_t)rgb \| _brightness \| 0xE0;`
	`190`	`+ }`
`189`	`191`	`}`
`190`	`192`	`void set(int idx, uint8_t r, uint8_t g, uint8_t b, uint8_t brightness = 5) {`
`191`	`193`	`set(idx, ModulinoColor(r,g,b), brightness);`