Eliminate pointer to read buffer from IO response, therefore making the necessity of keeping the read buffer on the stack in scope more visible.

Author: aentinger

ThreadsafeIO/examples/ts_spi/ts_spi.ino

@@ -94,7 +94,7 @@ byte bmp388_read_reg(byte const reg_addr)
 
   rsp->wait();
 
-  return rsp->read_buf[2];
+  return read_buf[2];
 }
 
 void bmp388_thread_func()

ThreadsafeIO/examples/ts_wire/ts_wire.ino

@@ -50,7 +50,7 @@ void setup()
 
 void loop()
 {
-  rtos::ThisThread::sleep_for(10);
+
 }
 
 /**************************************************************************************
@@ -72,7 +72,7 @@ byte lsm6dsox_read_reg(byte const reg_addr)
 
   rsp->wait();
 
-  return rsp->read_buf[0];
+  return read_buf;
 }
 
 

ThreadsafeIO/src/IoTransaction.h

@@ -52,15 +52,13 @@ class IoResponse
 {
 public:
 
-  IoResponse(uint8_t * read_buf_)
-  : read_buf{read_buf_}
-  , bytes_written{0}
+  IoResponse()
+  : bytes_written{0}
   , bytes_read{0}
   , _cond{_mutex}
   , _is_done{false}
   { }
 
-  uint8_t * read_buf{nullptr};
   size_t bytes_written{0};
   size_t bytes_read{0};
 

ThreadsafeIO/src/spi/SpiDispatcher.cpp

@@ -62,7 +62,7 @@ IoResponse SpiDispatcher::dispatch(IoRequest * req, SpiBusDeviceConfig * config)
   if (!spi_io_transaction)
     return nullptr;
 
-  IoResponse rsp(new impl::IoResponse{req->read_buf});
+  IoResponse rsp(new impl::IoResponse());
 
   spi_io_transaction->req = req;
   spi_io_transaction->rsp = rsp;

ThreadsafeIO/src/wire/WireDispatcher.cpp

@@ -62,7 +62,7 @@ IoResponse WireDispatcher::dispatch(IoRequest * req, WireBusDeviceConfig * confi
   if (!wire_io_transaction)
     return nullptr;
 
-  IoResponse rsp(new impl::IoResponse{req->read_buf});
+  IoResponse rsp(new impl::IoResponse());
 
   wire_io_transaction->req = req;
   wire_io_transaction->rsp = rsp;
@@ -152,7 +152,7 @@ void WireDispatcher::processWireIoRequest(WireIoTransaction * wire_io_transactio
     size_t bytes_read = 0;
     for (; bytes_read < io_request->bytes_to_read; bytes_read++)
     {
-      io_response->read_buf[bytes_read] = Wire.read();
+      io_request->read_buf[bytes_read] = Wire.read();
     }
     io_response->bytes_read = bytes_read;
   }