Replacing uint8_t with byte for better consistency with the Arduino way.

Author: aentinger

ThreadsafeIO/examples/ts_spi/ts_spi.ino

@@ -10,7 +10,7 @@
 
 static int     const BMP388_CS_PIN  = 2;
 static int     const BMP388_INT_PIN = 6;
-static uint8_t const BMP388_CHIP_ID_REG_ADDR = 0x00;
+static byte const BMP388_CHIP_ID_REG_ADDR = 0x00;
 
 static size_t constexpr NUM_THREADS = 20;
 
@@ -81,7 +81,7 @@ byte bmp388_read_reg(byte const reg_addr)
 {
   byte const write_buf[3] =
   {
-    static_cast<uint8_t>(0x80 | reg_addr), /* REG_ADDR, if MSBit is set -> READ access */
+    static_cast<byte>(0x80 | reg_addr), /* REG_ADDR, if MSBit is set -> READ access */
     0,                                     /* Dummy byte.                              */
     0                                      /* REG_VAL is output on SDO                 */
   };

ThreadsafeIO/src/IoTransaction.h

@@ -9,9 +9,10 @@
  * INCLUDE
  **************************************************************************************/
 
-#include <stdint.h>
+#include <Arduino.h>
 
 #include <mbed.h>
+
 #include <SharedPtr.h>
 
 /**************************************************************************************
@@ -26,20 +27,20 @@ class IoRequest
 {
 public:
 
-  IoRequest(uint8_t const * const write_buf_, size_t const bytes_to_write_, uint8_t * read_buf_, size_t const bytes_to_read_)
+  IoRequest(byte const * const write_buf_, size_t const bytes_to_write_, byte * read_buf_, size_t const bytes_to_read_)
   : write_buf{write_buf_}
   , bytes_to_write{bytes_to_write_}
   , read_buf{read_buf_}
   , bytes_to_read{bytes_to_read_}
   { }
 
-  IoRequest(uint8_t const & write_buf_, uint8_t & read_buf_)
+  IoRequest(byte const & write_buf_, byte & read_buf_)
   : IoRequest{&write_buf_, 1, &read_buf_, 1}
   { }
 
-  uint8_t const * const write_buf{nullptr};
+  byte const * const write_buf{nullptr};
   size_t const bytes_to_write{0};
-  uint8_t * read_buf{nullptr};
+  byte * read_buf{nullptr};
   size_t const bytes_to_read{0};
 
 };

ThreadsafeIO/src/spi/SpiBusDeviceConfig.h

@@ -9,10 +9,12 @@
  * INCLUDE
  **************************************************************************************/
 
-#include <functional>
 #include <Arduino.h>
+
 #include <SPI.h>
 
+#include <functional>
+
 /**************************************************************************************
  * CLASS DECLARATION
  **************************************************************************************/
@@ -25,7 +27,7 @@ class SpiBusDeviceConfig
   typedef std::function<void(void)> SpiDeselectFunc;
 
 
-  SpiBusDeviceConfig(SPISettings const & spi_settings, SpiSelectFunc spi_select, SpiDeselectFunc spi_deselect, uint8_t const fill_symbol = 0xFF)
+  SpiBusDeviceConfig(SPISettings const & spi_settings, SpiSelectFunc spi_select, SpiDeselectFunc spi_deselect, byte const fill_symbol = 0xFF)
   : _spi_settings{spi_settings}
   , _spi_select{spi_select}
   , _spi_deselect{spi_deselect}
@@ -36,15 +38,15 @@ class SpiBusDeviceConfig
   SPISettings settings   () const { return _spi_settings; }
   void        select     () const { if (_spi_select) _spi_select(); }
   void        deselect   () const { if (_spi_deselect) _spi_deselect(); }
-  uint8_t     fill_symbol() const { return _fill_symbol; }
+  byte        fill_symbol() const { return _fill_symbol; }
 
 
 private:
 
   SPISettings _spi_settings;
   SpiSelectFunc _spi_select{nullptr};
   SpiDeselectFunc _spi_deselect{nullptr};
-  uint8_t _fill_symbol{0xFF};
+  byte _fill_symbol{0xFF};
 
 };
 

ThreadsafeIO/src/spi/SpiDispatcher.cpp

@@ -136,14 +136,14 @@ void SpiDispatcher::processSpiIoRequest(SpiIoTransaction * spi_io_transaction)
       bytes_received < io_request->bytes_to_read;
       bytes_received++, bytes_sent++)
   {
-    uint8_t tx_byte = 0;
+    byte tx_byte = 0;
 
     if (bytes_sent < io_request->bytes_to_write)
       tx_byte = io_request->write_buf[bytes_sent];
     else
       tx_byte = config->fill_symbol();
 
-    uint8_t const rx_byte = SPI.transfer(tx_byte);
+    byte const rx_byte = SPI.transfer(tx_byte);
 
     io_request->read_buf[bytes_received] = rx_byte;
   }

ThreadsafeIO/src/wire/WireDispatcher.cpp

@@ -144,7 +144,7 @@ void WireDispatcher::processWireIoRequest(WireIoTransaction * wire_io_transactio
   {
     Wire.requestFrom(config->slave_addr(), io_request->bytes_to_read, config->stop());
 
-    while(Wire.available() != io_request->bytes_to_read)
+    while(Wire.available() != static_cast<int>(io_request->bytes_to_read))
     {
       /* TODO: Insert a timeout. */
     }