Skip to content

Commit b025d20

Browse files
committed
serialAgent refactor
1 parent 00bb976 commit b025d20

File tree

1 file changed

+18
-16
lines changed

1 file changed

+18
-16
lines changed

src/ConfiguratorAgents/agents/Serial/SerialAgent.h

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -117,24 +117,26 @@ inline bool SerialAgentClass::isPeerConnected() {
117117

118118
inline ConfiguratorAgent::AgentConfiguratorStates SerialAgentClass::handleInit() {
119119
AgentConfiguratorStates nextState = _state;
120-
if (Serial) {
121-
PacketManager::ReceivedData receivedData;
122-
while (Serial.available()) {
123-
uint8_t byte = Serial.read();
124-
PacketManager::ReceivingState res = PacketManager::getInstance().handleReceivedByte(receivedData, byte);
125-
if (res == PacketManager::ReceivingState::RECEIVED) {
126-
if (receivedData.type == PacketManager::MessageType::TRANSMISSION_CONTROL) {
127-
if (receivedData.payload.len() == 1 && receivedData.payload[0] == 0x01) {
128-
//CONNECT
129-
nextState = AgentConfiguratorStates::PEER_CONNECTED;
130-
PacketManager::getInstance().clear();
131-
}
120+
if (!Serial) {
121+
return nextState;
122+
}
123+
124+
PacketManager::ReceivedData receivedData;
125+
while (Serial.available()) {
126+
uint8_t byte = Serial.read();
127+
PacketManager::ReceivingState res = PacketManager::getInstance().handleReceivedByte(receivedData, byte);
128+
if (res == PacketManager::ReceivingState::RECEIVED) {
129+
if (receivedData.type == PacketManager::MessageType::TRANSMISSION_CONTROL) {
130+
if (receivedData.payload.len() == 1 && receivedData.payload[0] == 0x01) {
131+
//CONNECT
132+
nextState = AgentConfiguratorStates::PEER_CONNECTED;
133+
PacketManager::getInstance().clear();
132134
}
133-
} else if (res == PacketManager::ReceivingState::ERROR) {
134-
DEBUG_DEBUG("SerialAgentClass::%s Error receiving packet", __FUNCTION__);
135-
PacketManager::getInstance().clear();
136-
clearInputBuffer();
137135
}
136+
} else if (res == PacketManager::ReceivingState::ERROR) {
137+
DEBUG_DEBUG("SerialAgentClass::%s Error receiving packet", __FUNCTION__);
138+
PacketManager::getInstance().clear();
139+
clearInputBuffer();
138140
}
139141
}
140142

0 commit comments

Comments
 (0)