Skip to content

Commit 697cd61

Browse files
pennamandreagilardoni
authored andcommitted
Use Arduino_CloudUtils
1 parent 03d1d62 commit 697cd61

File tree

8 files changed

+8
-421
lines changed

8 files changed

+8
-421
lines changed

src/ota/implementation/OTAUnoR4.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414
#include "OTAUnoR4.h"
1515

1616
#include <Arduino_DebugUtils.h>
17-
#include "tls/utility/SHA256.h"
1817
#include "fsp_common_api.h"
1918
#include "r_flash_lp.h"
2019
#include "WiFi.h"

src/ota/interface/OTAInterface.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
#if OTA_ENABLED
2020
#include "../OTATypes.h"
21-
#include "tls/utility/SHA256.h"
21+
#include <Arduino_SHA256.h>
2222

2323
#include <interfaces/CloudProcess.h>
2424
#include <Arduino_DebugUtils.h>

src/ota/interface/OTAInterfaceDefault.cpp

Lines changed: 5 additions & 51 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
#include <AIoTC_Config.h>
1111

1212
#if OTA_ENABLED && ! defined(OFFLOADED_DOWNLOAD)
13+
#include <Arduino_CRC32.h>
1314
#include "OTAInterfaceDefault.h"
1415
#include "../OTA.h"
1516

@@ -119,7 +120,7 @@ OTACloudProcessInterface::State OTADefaultCloudProcessInterface::fetch() {
119120
// this could distinguish between consistency of the downloaded bytes and filesize
120121

121122
// validate CRC
122-
context->calculatedCrc32 ^= 0xFFFFFFFF; // finalize CRC
123+
context->calculatedCrc32 = arduino::crc32::finalize(context->calculatedCrc32);
123124
if(context->header.header.crc32 == context->calculatedCrc32) {
124125
DEBUG_VERBOSE("Ota download completed successfully");
125126
res = FlashOTA;
@@ -215,7 +216,7 @@ void OTADefaultCloudProcessInterface::parseOta(uint8_t* buffer, size_t bufLen) {
215216
if(sizeof(context->header.buf) == context->headerCopiedBytes) {
216217
context->downloadState = OtaDownloadFile;
217218

218-
context->calculatedCrc32 = crc_update(
219+
context->calculatedCrc32 = arduino::crc32::update(
219220
context->calculatedCrc32,
220221
&(context->header.header.magic_number),
221222
sizeof(context->header) - offsetof(ota::OTAHeader, header.magic_number)
@@ -234,7 +235,7 @@ void OTADefaultCloudProcessInterface::parseOta(uint8_t* buffer, size_t bufLen) {
234235
const uint32_t dataLeft = bufLen - (cursor-buffer);
235236
context->decoder.decompress(cursor, dataLeft); // TODO verify return value
236237

237-
context->calculatedCrc32 = crc_update(
238+
context->calculatedCrc32 = arduino::crc32::update(
238239
context->calculatedCrc32,
239240
cursor,
240241
dataLeft
@@ -292,7 +293,7 @@ OTADefaultCloudProcessInterface::Context::Context(
292293
const char* url, std::function<void(uint8_t)> putc)
293294
: parsed_url(url)
294295
, downloadState(OtaDownloadHeader)
295-
, calculatedCrc32(0xFFFFFFFF)
296+
, calculatedCrc32(arduino::crc32::begin())
296297
, headerCopiedBytes(0)
297298
, downloadedSize(0)
298299
, lastReportTime(0)
@@ -301,51 +302,4 @@ OTADefaultCloudProcessInterface::Context::Context(
301302
, downloadedChunkSize(0)
302303
, decoder(putc) { }
303304

304-
static const uint32_t crc_table[256] = {
305-
0x00000000, 0x77073096, 0xee0e612c, 0x990951ba, 0x076dc419, 0x706af48f, 0xe963a535, 0x9e6495a3,
306-
0x0edb8832, 0x79dcb8a4, 0xe0d5e91e, 0x97d2d988, 0x09b64c2b, 0x7eb17cbd, 0xe7b82d07, 0x90bf1d91,
307-
0x1db71064, 0x6ab020f2, 0xf3b97148, 0x84be41de, 0x1adad47d, 0x6ddde4eb, 0xf4d4b551, 0x83d385c7,
308-
0x136c9856, 0x646ba8c0, 0xfd62f97a, 0x8a65c9ec, 0x14015c4f, 0x63066cd9, 0xfa0f3d63, 0x8d080df5,
309-
0x3b6e20c8, 0x4c69105e, 0xd56041e4, 0xa2677172, 0x3c03e4d1, 0x4b04d447, 0xd20d85fd, 0xa50ab56b,
310-
0x35b5a8fa, 0x42b2986c, 0xdbbbc9d6, 0xacbcf940, 0x32d86ce3, 0x45df5c75, 0xdcd60dcf, 0xabd13d59,
311-
0x26d930ac, 0x51de003a, 0xc8d75180, 0xbfd06116, 0x21b4f4b5, 0x56b3c423, 0xcfba9599, 0xb8bda50f,
312-
0x2802b89e, 0x5f058808, 0xc60cd9b2, 0xb10be924, 0x2f6f7c87, 0x58684c11, 0xc1611dab, 0xb6662d3d,
313-
0x76dc4190, 0x01db7106, 0x98d220bc, 0xefd5102a, 0x71b18589, 0x06b6b51f, 0x9fbfe4a5, 0xe8b8d433,
314-
0x7807c9a2, 0x0f00f934, 0x9609a88e, 0xe10e9818, 0x7f6a0dbb, 0x086d3d2d, 0x91646c97, 0xe6635c01,
315-
0x6b6b51f4, 0x1c6c6162, 0x856530d8, 0xf262004e, 0x6c0695ed, 0x1b01a57b, 0x8208f4c1, 0xf50fc457,
316-
0x65b0d9c6, 0x12b7e950, 0x8bbeb8ea, 0xfcb9887c, 0x62dd1ddf, 0x15da2d49, 0x8cd37cf3, 0xfbd44c65,
317-
0x4db26158, 0x3ab551ce, 0xa3bc0074, 0xd4bb30e2, 0x4adfa541, 0x3dd895d7, 0xa4d1c46d, 0xd3d6f4fb,
318-
0x4369e96a, 0x346ed9fc, 0xad678846, 0xda60b8d0, 0x44042d73, 0x33031de5, 0xaa0a4c5f, 0xdd0d7cc9,
319-
0x5005713c, 0x270241aa, 0xbe0b1010, 0xc90c2086, 0x5768b525, 0x206f85b3, 0xb966d409, 0xce61e49f,
320-
0x5edef90e, 0x29d9c998, 0xb0d09822, 0xc7d7a8b4, 0x59b33d17, 0x2eb40d81, 0xb7bd5c3b, 0xc0ba6cad,
321-
0xedb88320, 0x9abfb3b6, 0x03b6e20c, 0x74b1d29a, 0xead54739, 0x9dd277af, 0x04db2615, 0x73dc1683,
322-
0xe3630b12, 0x94643b84, 0x0d6d6a3e, 0x7a6a5aa8, 0xe40ecf0b, 0x9309ff9d, 0x0a00ae27, 0x7d079eb1,
323-
0xf00f9344, 0x8708a3d2, 0x1e01f268, 0x6906c2fe, 0xf762575d, 0x806567cb, 0x196c3671, 0x6e6b06e7,
324-
0xfed41b76, 0x89d32be0, 0x10da7a5a, 0x67dd4acc, 0xf9b9df6f, 0x8ebeeff9, 0x17b7be43, 0x60b08ed5,
325-
0xd6d6a3e8, 0xa1d1937e, 0x38d8c2c4, 0x4fdff252, 0xd1bb67f1, 0xa6bc5767, 0x3fb506dd, 0x48b2364b,
326-
0xd80d2bda, 0xaf0a1b4c, 0x36034af6, 0x41047a60, 0xdf60efc3, 0xa867df55, 0x316e8eef, 0x4669be79,
327-
0xcb61b38c, 0xbc66831a, 0x256fd2a0, 0x5268e236, 0xcc0c7795, 0xbb0b4703, 0x220216b9, 0x5505262f,
328-
0xc5ba3bbe, 0xb2bd0b28, 0x2bb45a92, 0x5cb36a04, 0xc2d7ffa7, 0xb5d0cf31, 0x2cd99e8b, 0x5bdeae1d,
329-
0x9b64c2b0, 0xec63f226, 0x756aa39c, 0x026d930a, 0x9c0906a9, 0xeb0e363f, 0x72076785, 0x05005713,
330-
0x95bf4a82, 0xe2b87a14, 0x7bb12bae, 0x0cb61b38, 0x92d28e9b, 0xe5d5be0d, 0x7cdcefb7, 0x0bdbdf21,
331-
0x86d3d2d4, 0xf1d4e242, 0x68ddb3f8, 0x1fda836e, 0x81be16cd, 0xf6b9265b, 0x6fb077e1, 0x18b74777,
332-
0x88085ae6, 0xff0f6a70, 0x66063bca, 0x11010b5c, 0x8f659eff, 0xf862ae69, 0x616bffd3, 0x166ccf45,
333-
0xa00ae278, 0xd70dd2ee, 0x4e048354, 0x3903b3c2, 0xa7672661, 0xd06016f7, 0x4969474d, 0x3e6e77db,
334-
0xaed16a4a, 0xd9d65adc, 0x40df0b66, 0x37d83bf0, 0xa9bcae53, 0xdebb9ec5, 0x47b2cf7f, 0x30b5ffe9,
335-
0xbdbdf21c, 0xcabac28a, 0x53b39330, 0x24b4a3a6, 0xbad03605, 0xcdd70693, 0x54de5729, 0x23d967bf,
336-
0xb3667a2e, 0xc4614ab8, 0x5d681b02, 0x2a6f2b94, 0xb40bbe37, 0xc30c8ea1, 0x5a05df1b, 0x2d02ef8d
337-
};
338-
339-
uint32_t crc_update(uint32_t crc, const void * data, size_t data_len) {
340-
const unsigned char *d = (const unsigned char *)data;
341-
unsigned int tbl_idx;
342-
343-
while (data_len--) {
344-
tbl_idx = (crc ^ *d) & 0xff;
345-
crc = (crc_table[tbl_idx] ^ (crc >> 8)) & 0xffffffff;
346-
d++;
347-
}
348-
349-
return crc & 0xffffffff;
350-
}
351305
#endif /* OTA_ENABLED && ! defined(OFFLOADED_DOWNLOAD) */

src/ota/interface/OTAInterfaceDefault.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
#include <ArduinoHttpClient.h>
1818
#include <URLParser.h>
19-
#include "utility/lzss/lzss.h"
19+
#include <Arduino_Lzss.h>
2020
#include "OTAInterface.h"
2121

2222
/**
@@ -87,7 +87,7 @@ class OTADefaultCloudProcessInterface: public OTACloudProcessInterface {
8787
uint32_t downloadedChunkSize;
8888

8989
// LZSS decoder
90-
LZSSDecoder decoder;
90+
arduino::lzss::Decoder decoder;
9191

9292
static constexpr size_t bufLen = 64;
9393
uint8_t buffer[bufLen];

src/tls/utility/SHA256.cpp

Lines changed: 0 additions & 47 deletions
This file was deleted.

src/tls/utility/SHA256.h

Lines changed: 0 additions & 48 deletions
This file was deleted.

src/utility/lzss/lzss.cpp

Lines changed: 0 additions & 163 deletions
This file was deleted.

0 commit comments

Comments
 (0)