From ab427be6d27fb22de28e96db4f435f1f3fcfe8c4 Mon Sep 17 00:00:00 2001
From: Alexander Entinger <consulting@lxrobotics.com>
Date: Wed, 21 Feb 2024 18:55:39 +0100
Subject: [PATCH 1/2] Revert "Fix regression: report size delta size on PR.
 (#39)"

This reverts commit cac25edced590e38cc6e4867dadff514e185e69a.
---
 .github/workflows/compile-examples.yml   | 27 ++++--------------------
 .github/workflows/report-size-deltas.yml | 24 +++++++++++++++++++++
 2 files changed, 28 insertions(+), 23 deletions(-)
 create mode 100644 .github/workflows/report-size-deltas.yml

diff --git a/.github/workflows/compile-examples.yml b/.github/workflows/compile-examples.yml
index 13d1e0f..d80f79f 100644
--- a/.github/workflows/compile-examples.yml
+++ b/.github/workflows/compile-examples.yml
@@ -20,15 +20,14 @@ on:
   workflow_dispatch:
   repository_dispatch:
 
-env:
-  # It's convenient to set variables for values used multiple times in the workflow.
-  SKETCHES_REPORTS_PATH: sketches-reports
-
 jobs:
-  compile:
+  build:
     name: ${{ matrix.board.fqbn }}
     runs-on: ubuntu-latest
 
+    env:
+      SKETCHES_REPORTS_PATH: sketches-reports
+
     strategy:
       fail-fast: false
 
@@ -73,21 +72,3 @@ jobs:
           if-no-files-found: error
           name: sketches-report-${{ matrix.board.artifact-name-suffix }}
           path: ${{ env.SKETCHES_REPORTS_PATH }}
-
-  # When using a matrix to compile for multiple boards, it's necessary to use a separate job for the deltas report
-  report:
-    needs: compile # Wait for the compile job to finish to get the data for the report
-    if: github.event_name == 'pull_request' # Only run the job when the workflow is triggered by a pull request
-    runs-on: ubuntu-latest
-
-    steps:
-      # This step is needed to get the size data produced by the compile jobs
-      - name: Download sketches reports artifacts
-        uses: actions/download-artifact@v4
-        with:
-          # All workflow artifacts will be downloaded to this location.
-          path: ${{ env.SKETCHES_REPORTS_PATH }}
-
-      - uses: arduino/report-size-deltas@v1
-        with:
-          sketches-reports-source: ${{ env.SKETCHES_REPORTS_PATH }}
diff --git a/.github/workflows/report-size-deltas.yml b/.github/workflows/report-size-deltas.yml
new file mode 100644
index 0000000..652be5d
--- /dev/null
+++ b/.github/workflows/report-size-deltas.yml
@@ -0,0 +1,24 @@
+name: Report Size Deltas
+
+# See: https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows
+on:
+  push:
+    paths:
+      - ".github/workflows/report-size-deltas.yml"
+  schedule:
+    # Run at the minimum interval allowed by GitHub Actions.
+    # Note: GitHub Actions periodically has outages which result in workflow failures.
+    # In this event, the workflows will start passing again once the service recovers.
+    - cron: "*/5 * * * *"
+  workflow_dispatch:
+  repository_dispatch:
+
+jobs:
+  report:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Comment size deltas reports to PRs
+        uses: arduino/report-size-deltas@v1
+        with:
+          # The name of the workflow artifact created by the sketch compilation workflow
+          sketches-reports-source: sketches-reports

From c9ec0e44178f5788319edd9706e90533286e44ca Mon Sep 17 00:00:00 2001
From: Alexander Entinger <consulting@lxrobotics.com>
Date: Wed, 21 Feb 2024 18:56:12 +0100
Subject: [PATCH 2/2] Correct workflow artifact name pattern in size deltas
 report workflow The "sketches-reports-source" input of the
 "arduino/report-size-deltas" GitHub Actions action defines the regular
 expression that matches the names of the sketches report workflow artifacts
 produced by the "Compile Examples" workflow.

The key string in the names of these artifacts was set to "sketches-report" when the "Compile Examples" workflow was
adjusted for compatibility with the breaking changes introduced by updating to version 4.x of the workflow's
"actions/upload-artifact" GitHub Actions action dependency. The pattern set in the size deltas report workflow was
"sketches-reports". The "s" at the end of that pattern caused it to no longer match against the key string in the
artifact names after that adjustment of the "Compile Examples" workflow, resulting in size deltas reports no longer
being generated by the workflow.

Although a minimal fix would be to simply remove the "s" from the end of the pattern, the decision was made to use a
more strict regular expression. This will make it easier for maintainers and contributors to understand that this value
is a regular expression and the exact nature of how that regular expression functio
---
 .github/workflows/report-size-deltas.yml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/report-size-deltas.yml b/.github/workflows/report-size-deltas.yml
index 652be5d..39e2a0a 100644
--- a/.github/workflows/report-size-deltas.yml
+++ b/.github/workflows/report-size-deltas.yml
@@ -20,5 +20,5 @@ jobs:
       - name: Comment size deltas reports to PRs
         uses: arduino/report-size-deltas@v1
         with:
-          # The name of the workflow artifact created by the sketch compilation workflow
-          sketches-reports-source: sketches-reports
+          # Regex matching the names of the workflow artifacts created by the "Compile Examples" workflow
+          sketches-reports-source: ^sketches-report-.+