Skip to content

Commit ae1cb39

Browse files
committed
tests refactoring
1 parent 32034c0 commit ae1cb39

File tree

7 files changed

+425
-404
lines changed

7 files changed

+425
-404
lines changed

src/test/java/com/arangodb/springframework/AbstractTxTest.java

Lines changed: 23 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,34 +1,49 @@
11
package com.arangodb.springframework;
22

3+
import com.arangodb.model.DocumentCreateOptions;
4+
import com.arangodb.model.DocumentReadOptions;
35
import com.arangodb.model.StreamTransactionOptions;
46
import com.arangodb.springframework.core.mapping.testdata.BasicEdgeLazyTestEntity;
57
import com.arangodb.springframework.core.mapping.testdata.BasicEdgeTestEntity;
68
import com.arangodb.springframework.core.mapping.testdata.BasicTestEntity;
79
import org.junit.jupiter.api.AfterEach;
810
import org.junit.jupiter.api.BeforeEach;
911

12+
import java.util.ArrayList;
1013
import java.util.Arrays;
11-
import java.util.HashSet;
12-
import java.util.Set;
14+
import java.util.Collections;
1315

1416
public abstract class AbstractTxTest extends AbstractArangoTest {
1517
protected String tx;
18+
protected DocumentCreateOptions insertOpts;
19+
protected DocumentReadOptions findOpts;
20+
21+
private static Class<?>[] enrichCollections(final Class<?>... collections) {
22+
ArrayList<Class<?>> classes = new ArrayList<>();
23+
Collections.addAll(classes, collections);
24+
classes.add(BasicTestEntity.class);
25+
classes.add(BasicEdgeTestEntity.class);
26+
classes.add(BasicEdgeLazyTestEntity.class);
27+
return classes.toArray(new Class[0]);
28+
}
29+
30+
protected AbstractTxTest(final Class<?>... collections) {
31+
super(enrichCollections(collections));
32+
}
1633

1734
@BeforeEach
1835
void beginTx() {
19-
Set<Class<?>> cols = new HashSet<>(Arrays.asList(getClass().getDeclaredClasses()));
20-
cols.add(BasicTestEntity.class);
21-
cols.add(BasicEdgeTestEntity.class);
22-
cols.add(BasicEdgeLazyTestEntity.class);
23-
24-
String[] txCols = cols.stream()
36+
String[] txCols = Arrays.stream(collections)
2537
.map(it -> template.collection(it).name())
2638
.toArray(String[]::new);
2739

2840
tx = db.beginStreamTransaction(new StreamTransactionOptions()
2941
.readCollections(txCols)
3042
.writeCollections(txCols)
3143
).getId();
44+
45+
insertOpts = new DocumentCreateOptions().streamTransactionId(tx);
46+
findOpts = new DocumentReadOptions().streamTransactionId(tx);
3247
}
3348

3449
@AfterEach

src/test/java/com/arangodb/springframework/core/mapping/AbstractMappingTxTest.java

Lines changed: 0 additions & 17 deletions
This file was deleted.

src/test/java/com/arangodb/springframework/core/mapping/EdgeMappingTxTest.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020

2121
package com.arangodb.springframework.core.mapping;
2222

23+
import com.arangodb.springframework.AbstractTxTest;
2324
import com.arangodb.springframework.annotation.From;
2425
import com.arangodb.springframework.annotation.To;
2526
import com.arangodb.springframework.core.mapping.testdata.BasicEdgeLazyTestEntity;
@@ -35,7 +36,11 @@
3536
* @author Mark Vollmary
3637
*
3738
*/
38-
public class EdgeMappingTxTest extends AbstractMappingTxTest {
39+
public class EdgeMappingTxTest extends AbstractTxTest {
40+
41+
EdgeMappingTxTest() {
42+
super(EdgeMappingTxTest.class.getDeclaredClasses());
43+
}
3944

4045
@Test
4146
public void edgeFromTo() {

0 commit comments

Comments
 (0)