From bbeda938405c1ec98a54a90770286fa7bed3b876 Mon Sep 17 00:00:00 2001 From: Anthony Mahanna Date: Fri, 2 Feb 2024 16:50:25 -0500 Subject: [PATCH 1/4] DE-752 | initial commit --- tests/test_analyzer.py | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/tests/test_analyzer.py b/tests/test_analyzer.py index 63627251..dff85777 100644 --- a/tests/test_analyzer.py +++ b/tests/test_analyzer.py @@ -14,13 +14,23 @@ def test_analyzer_management(db, bad_db, cluster, enterprise, db_version): full_analyzer_name = db.name + "::" + analyzer_name bad_analyzer_name = generate_analyzer_name() - # Test create analyzer + # Test create identity analyzer result = db.create_analyzer(analyzer_name, "identity", {}) assert result["name"] == full_analyzer_name assert result["type"] == "identity" assert result["properties"] == {} assert result["features"] == [] + # Test create delimiter analyzer + result = db.create_analyzer( + name=generate_analyzer_name(), + analyzer_type="delimiter", + properties={"delimiter": ","}, + ) + assert result["type"] == "delimiter" + assert result["properties"] == {"delimiter": ","} + assert result["features"] == [] + # Test create duplicate with bad database with assert_raises(AnalyzerCreateError) as err: bad_db.create_analyzer(analyzer_name, "identity", {}, []) @@ -71,3 +81,16 @@ def test_analyzer_management(db, bad_db, cluster, enterprise, db_version): "format": "latLngDouble", } assert db.delete_analyzer(analyzer_name) + + # Test create delimieter analyzer with multiple delimiters + # NOTE: This is currently failing on 3.12.0-NIGHTLY.20240116 + if db_version >= version.parse("3.12.0"): + result = db.create_analyzer( + name=generate_analyzer_name(), + analyzer_type="delimiter", + properties={"delimiter": [",", "."]}, + ) + + assert result["type"] == "delimiter" + assert result["properties"] == {"delimiter": [",", "."]} + assert result["features"] == [] From b48e105135fbd567da9864fd15c359845452fc4d Mon Sep 17 00:00:00 2001 From: Anthony Mahanna Date: Sun, 4 Feb 2024 17:32:23 -0500 Subject: [PATCH 2/4] fix: analyzer type --- tests/test_analyzer.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tests/test_analyzer.py b/tests/test_analyzer.py index dff85777..64c4991f 100644 --- a/tests/test_analyzer.py +++ b/tests/test_analyzer.py @@ -84,13 +84,14 @@ def test_analyzer_management(db, bad_db, cluster, enterprise, db_version): # Test create delimieter analyzer with multiple delimiters # NOTE: This is currently failing on 3.12.0-NIGHTLY.20240116 + # [HTTP 501][ERR 9] Not implemented analyzer type 'multi_delimiter' if db_version >= version.parse("3.12.0"): result = db.create_analyzer( name=generate_analyzer_name(), - analyzer_type="delimiter", + analyzer_type="multi_delimiter", properties={"delimiter": [",", "."]}, ) - assert result["type"] == "delimiter" + assert result["type"] == "multi_delimiter" assert result["properties"] == {"delimiter": [",", "."]} assert result["features"] == [] From 6e5bc342c4b01c54e915adae89953ed883c2d775 Mon Sep 17 00:00:00 2001 From: Anthony Mahanna Date: Fri, 8 Mar 2024 09:58:39 -0500 Subject: [PATCH 3/4] fix: analyzer test --- tests/test_analyzer.py | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/tests/test_analyzer.py b/tests/test_analyzer.py index 64c4991f..32882013 100644 --- a/tests/test_analyzer.py +++ b/tests/test_analyzer.py @@ -83,15 +83,13 @@ def test_analyzer_management(db, bad_db, cluster, enterprise, db_version): assert db.delete_analyzer(analyzer_name) # Test create delimieter analyzer with multiple delimiters - # NOTE: This is currently failing on 3.12.0-NIGHTLY.20240116 - # [HTTP 501][ERR 9] Not implemented analyzer type 'multi_delimiter' if db_version >= version.parse("3.12.0"): result = db.create_analyzer( name=generate_analyzer_name(), analyzer_type="multi_delimiter", - properties={"delimiter": [",", "."]}, + properties={"delimiters": [",", "."]}, ) assert result["type"] == "multi_delimiter" - assert result["properties"] == {"delimiter": [",", "."]} + assert result["properties"] == {"delimiters": [",", "."]} assert result["features"] == [] From ac2dd4a805694ee7769d67d5828e471d5f0602d4 Mon Sep 17 00:00:00 2001 From: Anthony Mahanna Date: Mon, 22 Apr 2024 17:06:20 -0400 Subject: [PATCH 4/4] fix: `test_analyzer_management` --- tests/test_analyzer.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/test_analyzer.py b/tests/test_analyzer.py index e842a12f..a8c77396 100644 --- a/tests/test_analyzer.py +++ b/tests/test_analyzer.py @@ -1,3 +1,5 @@ +from packaging import version + from arango.exceptions import ( AnalyzerCreateError, AnalyzerDeleteError, @@ -7,7 +9,7 @@ from tests.helpers import assert_raises, generate_analyzer_name -def test_analyzer_management(db, bad_db, cluster, enterprise): +def test_analyzer_management(db, bad_db, cluster, enterprise, db_version): analyzer_name = generate_analyzer_name() full_analyzer_name = db.name + "::" + analyzer_name bad_analyzer_name = generate_analyzer_name()