From 958aec87c8bbe9c83056aaf50abd3c7659e126c9 Mon Sep 17 00:00:00 2001
From: Denis Zubarev <dvzubarev@yandex.ru>
Date: Wed, 3 Aug 2022 20:51:48 +0300
Subject: [PATCH] add missing parameters to insert_many method

add overwrite_mode, keep_none, merge similar to insert method.
They were added in arangodb 3.7
---
 arango/collection.py   | 25 ++++++++++++++++++
 tests/test_document.py | 57 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 82 insertions(+)

diff --git a/arango/collection.py b/arango/collection.py
index aac97bb9..7cf8078b 100644
--- a/arango/collection.py
+++ b/arango/collection.py
@@ -1383,6 +1383,9 @@ def insert_many(
         silent: bool = False,
         overwrite: bool = False,
         return_old: bool = False,
+        overwrite_mode: Optional[str] = None,
+        keep_none: Optional[bool] = None,
+        merge: Optional[bool] = None,
     ) -> Result[Union[bool, List[Union[Json, ArangoServerError]]]]:
         """Insert multiple documents.
 
@@ -1420,6 +1423,21 @@ def insert_many(
         :param return_old: Include body of the old documents if replaced.
             Applies only when value of **overwrite** is set to True.
         :type return_old: bool
+        :param overwrite_mode: Overwrite behavior used when the document key
+            exists already. Allowed values are "replace" (replace-insert),
+            "update" (update-insert), "ignore" or "conflict".
+            Implicitly sets the value of parameter **overwrite**.
+        :type overwrite_mode: str | None
+        :param keep_none: If set to True, fields with value None are retained
+            in the document. Otherwise, they are removed completely. Applies
+            only when **overwrite_mode** is set to "update" (update-insert).
+        :type keep_none: bool | None
+        :param merge: If set to True (default), sub-dictionaries are merged
+            instead of the new one overwriting the old one. Applies only when
+            **overwrite_mode** is set to "update" (update-insert).
+        :type merge: bool | None
+        :return: Document metadata (e.g. document key, revision) or True if
+            parameter **silent** was set to True.
         :return: List of document metadata (e.g. document keys, revisions) and
             any exception, or True if parameter **silent** was set to True.
         :rtype: [dict | ArangoServerError] | bool
@@ -1436,6 +1454,13 @@ def insert_many(
         if sync is not None:
             params["waitForSync"] = sync
 
+        if overwrite_mode is not None:
+            params["overwriteMode"] = overwrite_mode
+        if keep_none is not None:
+            params["keepNull"] = keep_none
+        if merge is not None:
+            params["mergeObjects"] = merge
+
         request = Request(
             method="post",
             endpoint=f"/_api/document/{self.name}",
diff --git a/tests/test_document.py b/tests/test_document.py
index d7db480a..b10bf136 100644
--- a/tests/test_document.py
+++ b/tests/test_document.py
@@ -236,6 +236,63 @@ def test_document_insert_many(col, bad_col, docs):
         bad_col.insert_many(docs)
     assert err.value.error_code in {11, 1228}
 
+    # test overwrite_mode: replace
+    extra_docs = [
+        {"_key": docs[0]["_key"], "foo": {"qux": 2}},
+        {"_key": "20", "foo": "t"},
+    ]
+    results = col.insert_many(
+        documents=extra_docs,
+        return_old=True,
+        return_new=True,
+        overwrite_mode="replace",
+        keep_none=False,
+        merge=True,
+    )
+
+    assert "old" in results[0]
+    assert "new" in results[0]
+    assert "old" not in results[1]
+    assert "new" in results[1]
+
+    # test overwrite_mode: update
+    extra_docs = [
+        {"_key": docs[0]["_key"], "foo": {"t": 1}},
+        {"_key": "20", "foo": None},
+    ]
+    results = col.insert_many(
+        documents=extra_docs,
+        return_old=True,
+        return_new=True,
+        overwrite_mode="update",
+        keep_none=False,
+        merge=True,
+    )
+    assert "old" in results[0]
+    assert "new" in results[0]
+    assert results[0]["new"]["foo"] == {"qux": 2, "t": 1}
+    assert "old" in results[1]
+    assert "new" in results[1]
+    assert "foo" not in results[1]["new"]
+
+    extra_docs = [
+        {"_key": docs[0]["_key"], "foo": {"t": 1}},
+        {"_key": "21", "foo": None},
+    ]
+
+    # Test insert conflict
+    results = col.insert_many(
+        documents=extra_docs,
+        return_old=True,
+        return_new=True,
+        overwrite_mode="conflict",
+        keep_none=True,
+        merge=True,
+    )
+    assert isinstance(results[0], DocumentInsertError)
+    assert results[0].error_code == 1210
+    assert "new" in results[1]
+
 
 def test_document_update(col, docs):
     doc = docs[0]