Adjusting typing information - The Json serializer must be able to deal with sequences

Author: apetenchea

arangoasync/collection.py

@@ -38,9 +38,9 @@
     RequestHeaders,
 )
 
-T = TypeVar("T")
-U = TypeVar("U")
-V = TypeVar("V")
+T = TypeVar("T")  # Serializer type
+U = TypeVar("U")  # Deserializer loads
+V = TypeVar("V")  # Deserializer loads_many
 
 
 class Collection(Generic[T, U, V]):
@@ -892,7 +892,7 @@ def response_handler(resp: Response) -> bool | Json:
 
     async def get_many(
         self,
-        documents: Sequence[str | Json],
+        documents: Sequence[str | T],
         allow_dirty_read: Optional[bool] = None,
         ignore_revs: Optional[bool] = None,
     ) -> Result[V]:
@@ -925,14 +925,17 @@ async def get_many(
 
         headers: RequestHeaders = {}
         if allow_dirty_read is not None:
-            headers["x-arango-allow-dirty-read"] = allow_dirty_read
+            if allow_dirty_read is True:
+                headers["x-arango-allow-dirty-read"] = "true"
+            else:
+                headers["x-arango-allow-dirty-read"] = "false"
 
         request = Request(
             method=Method.PUT,
             endpoint=f"/_api/document/{self.name}",
             params=params,
             headers=headers,
-            data=self.serializer.dumps(documents),
+            data=self._doc_serializer.dumps(documents),
         )
 
         def response_handler(resp: Response) -> V:

arangoasync/serialization.py

@@ -26,7 +26,7 @@ class Serializer(ABC, Generic[T]):  # pragma: no cover
     """
 
     @abstractmethod
-    def dumps(self, data: str | bool | T | Sequence[T | str]) -> str:
+    def dumps(self, data: T | Sequence[T | str]) -> str:
         """Serialize any generic data.
 
         Args:
@@ -87,7 +87,7 @@ def loads_many(self, data: bytes) -> U:
 class JsonSerializer(Serializer[Json]):
     """JSON serializer."""
 
-    def dumps(self, data: T) -> str:
+    def dumps(self, data: Json | Sequence[str | Json]) -> str:
         try:
             return json.dumps(data, separators=(",", ":"))
         except Exception as e: