Skip to content

Commit 17035b2

Browse files
authored
Merge pull request #244 from limpid-kzonix/master
cleanup-refactoring in ArangoCollectionImpl
2 parents 2bc0de7 + b390736 commit 17035b2

File tree

1 file changed

+7
-20
lines changed

1 file changed

+7
-20
lines changed

src/main/java/com/arangodb/internal/ArangoCollectionImpl.java

Lines changed: 7 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,7 @@ protected ArangoCollectionImpl(final ArangoDatabaseImpl db, final String name) {
6969

7070
@Override
7171
public <T> DocumentCreateEntity<T> insertDocument(final T value) throws ArangoDBException {
72-
final DocumentCreateOptions options = new DocumentCreateOptions();
73-
return executor.execute(insertDocumentRequest(value, options),
74-
insertDocumentResponseDeserializer(value, options));
72+
return insertDocument(value, new DocumentCreateOptions());
7573
}
7674

7775
@Override
@@ -84,9 +82,7 @@ public <T> DocumentCreateEntity<T> insertDocument(final T value, final DocumentC
8482
@Override
8583
public <T> MultiDocumentEntity<DocumentCreateEntity<T>> insertDocuments(final Collection<T> values)
8684
throws ArangoDBException {
87-
final DocumentCreateOptions params = new DocumentCreateOptions();
88-
return executor.execute(insertDocumentsRequest(values, params),
89-
insertDocumentsResponseDeserializer(values, params));
85+
return insertDocuments(values, new DocumentCreateOptions());
9086
}
9187

9288
@Override
@@ -111,8 +107,7 @@ public DocumentImportEntity importDocuments(final Collection<?> values, final Do
111107

112108
@Override
113109
public DocumentImportEntity importDocuments(final String values) throws ArangoDBException {
114-
return executor.execute(importDocumentsRequest(values, new DocumentImportOptions()),
115-
DocumentImportEntity.class);
110+
return importDocuments(values, new DocumentImportOptions());
116111
}
117112

118113
@Override
@@ -161,9 +156,7 @@ public <T> MultiDocumentEntity<T> getDocuments(
161156

162157
@Override
163158
public <T> DocumentUpdateEntity<T> replaceDocument(final String key, final T value) throws ArangoDBException {
164-
final DocumentReplaceOptions options = new DocumentReplaceOptions();
165-
return executor.execute(replaceDocumentRequest(key, value, options),
166-
replaceDocumentResponseDeserializer(value, options));
159+
return replaceDocument(key, value, new DocumentReplaceOptions());
167160
}
168161

169162
@Override
@@ -178,9 +171,7 @@ public <T> DocumentUpdateEntity<T> replaceDocument(
178171
@Override
179172
public <T> MultiDocumentEntity<DocumentUpdateEntity<T>> replaceDocuments(final Collection<T> values)
180173
throws ArangoDBException {
181-
final DocumentReplaceOptions params = new DocumentReplaceOptions();
182-
return executor.execute(replaceDocumentsRequest(values, params),
183-
replaceDocumentsResponseDeserializer(values, params));
174+
return replaceDocuments(values, new DocumentReplaceOptions());
184175
}
185176

186177
@Override
@@ -194,9 +185,7 @@ public <T> MultiDocumentEntity<DocumentUpdateEntity<T>> replaceDocuments(
194185

195186
@Override
196187
public <T> DocumentUpdateEntity<T> updateDocument(final String key, final T value) throws ArangoDBException {
197-
final DocumentUpdateOptions options = new DocumentUpdateOptions();
198-
return executor.execute(updateDocumentRequest(key, value, options),
199-
updateDocumentResponseDeserializer(value, options));
188+
return updateDocument(key, value, new DocumentUpdateOptions());
200189
}
201190

202191
@Override
@@ -211,9 +200,7 @@ public <T> DocumentUpdateEntity<T> updateDocument(
211200
@Override
212201
public <T> MultiDocumentEntity<DocumentUpdateEntity<T>> updateDocuments(final Collection<T> values)
213202
throws ArangoDBException {
214-
final DocumentUpdateOptions params = new DocumentUpdateOptions();
215-
return executor.execute(updateDocumentsRequest(values, params),
216-
updateDocumentsResponseDeserializer(values, params));
203+
return updateDocuments(values, new DocumentUpdateOptions());
217204
}
218205

219206
@Override

0 commit comments

Comments
 (0)