Skip to content

Commit 123b5ce

Browse files
committed
concurrent test fixes
1 parent c56a985 commit 123b5ce

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

src/test/java/com/arangodb/async/BaseTest.java

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,21 @@ public static void shutdown() throws InterruptedException, ExecutionException {
6464
arangoDB = null;
6565
}
6666

67+
protected static boolean isAtLeastVersion(final ArangoDBAsync arangoDB, final int major, final int minor, final int patch)
68+
throws InterruptedException, ExecutionException {
69+
return com.arangodb.util.TestUtils.isAtLeastVersion(arangoDB.getVersion().get().getVersion(), major, minor, patch);
70+
}
6771
protected static boolean isAtLeastVersion(final ArangoDBAsync arangoDB, final int major, final int minor)
6872
throws InterruptedException, ExecutionException {
69-
return com.arangodb.util.TestUtils.isAtLeastVersion(arangoDB.getVersion().get().getVersion(), major, minor, 0);
73+
return isAtLeastVersion(arangoDB, major, minor, 0);
74+
}
75+
76+
protected boolean isAtLeastVersion(final int major, final int minor, final int patch) throws InterruptedException, ExecutionException {
77+
return isAtLeastVersion(arangoDB, major, minor, patch);
7078
}
7179

7280
protected boolean isAtLeastVersion(final int major, final int minor) throws InterruptedException, ExecutionException {
73-
return isAtLeastVersion(arangoDB, major, minor);
81+
return isAtLeastVersion(major, minor, 0);
7482
}
7583

7684
boolean isStorageEngine(ArangoDBEngine.StorageEngineName name) throws ExecutionException, InterruptedException {

src/test/java/com/arangodb/async/StreamTransactionConflictsTest.java

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ public void teardown() throws ExecutionException, InterruptedException {
5959

6060
@Test
6161
public void conflictOnInsertDocumentWithNotYetCommittedTx() throws ExecutionException, InterruptedException {
62-
assumeTrue(isSingleServer());
6362
assumeTrue(isAtLeastVersion(3, 5));
6463
assumeTrue(isStorageEngine(ArangoDBEngine.StorageEngineName.rocksdb));
6564

@@ -82,7 +81,6 @@ public void conflictOnInsertDocumentWithNotYetCommittedTx() throws ExecutionExce
8281
fail();
8382
} catch (ExecutionException e) {
8483
assertThat(e.getCause(), Matchers.instanceOf(ArangoDBException.class));
85-
e.getCause().printStackTrace();
8684
}
8785

8886
db.abortStreamTransaction(tx1.getId()).get();
@@ -91,7 +89,6 @@ public void conflictOnInsertDocumentWithNotYetCommittedTx() throws ExecutionExce
9189

9290
@Test
9391
public void conflictOnInsertDocumentWithAlreadyCommittedTx() throws ExecutionException, InterruptedException {
94-
assumeTrue(isSingleServer());
9592
assumeTrue(isAtLeastVersion(3, 5));
9693
assumeTrue(isStorageEngine(ArangoDBEngine.StorageEngineName.rocksdb));
9794

@@ -117,7 +114,6 @@ public void conflictOnInsertDocumentWithAlreadyCommittedTx() throws ExecutionExc
117114
fail();
118115
} catch (ExecutionException e) {
119116
assertThat(e.getCause(), Matchers.instanceOf(ArangoDBException.class));
120-
e.getCause().printStackTrace();
121117
}
122118

123119
db.abortStreamTransaction(tx2.getId()).get();

0 commit comments

Comments
 (0)