Update Selenium version to v4.33.0 +semver:feature (#270)

mialeska · web-flow · commit b8fd334ec99d · 2025-05-30T11:12:46.000+02:00
* Update Selenium version to v4.33.0 +semver:feature

* fix review comment

* Accept cookies in manytools site

* Stabilize Should_BePossibleTo_FindByImage
diff --git a/Aquality.Selenium/src/Aquality.Selenium.Images/Aquality.Selenium.Images.csproj b/Aquality.Selenium/src/Aquality.Selenium.Images/Aquality.Selenium.Images.csproj
@@ -40,10 +40,10 @@
   </ItemGroup>
   <ItemGroup>
 	<PackageReference Include="OpenCvSharp4.runtime.osx_arm64" Version="4.8.1-rc" />
-	<PackageReference Include="OpenCvSharp4" Version="4.10.0.20241108" />
-	<PackageReference Include="OpenCvSharp4.runtime.linux-arm" Version="4.10.0.20241107" />
+	<PackageReference Include="OpenCvSharp4" Version="4.11.0.20250507" />
+	<PackageReference Include="OpenCvSharp4.runtime.linux-arm" Version="4.11.0.20250506" />
 	<PackageReference Include="OpenCvSharp4.runtime.osx.10.15-x64" Version="4.6.0.20230105" />
-	<PackageReference Include="OpenCvSharp4.runtime.win" Version="4.10.0.20241108" />
+	<PackageReference Include="OpenCvSharp4.runtime.win" Version="4.11.0.20250507" />
 	<PackageReference Include="OpenCvSharp4_.runtime.ubuntu.20.04-x64" Version="4.10.0.20240616" />
   </ItemGroup>	
 	
diff --git a/Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.csproj b/Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.csproj
@@ -91,7 +91,7 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Aquality.Selenium.Core" Version="3.2.1" />
+    <PackageReference Include="Aquality.Selenium.Core" Version="3.3.0" />
     <PackageReference Include="WebDriverManager" Version="2.17.5" />
   </ItemGroup>
 
diff --git a/Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.xml b/Aquality.Selenium/src/Aquality.Selenium/Aquality.Selenium.xml
diff --git a/Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsEmulationExtensions.cs b/Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsEmulationExtensions.cs
@@ -1,7 +1,7 @@
 ﻿using Aquality.Selenium.Core.Utilities;
 using OpenQA.Selenium.DevTools;
-using OpenQA.Selenium.DevTools.V135.DOM;
-using OpenQA.Selenium.DevTools.V135.Emulation;
+using OpenQA.Selenium.DevTools.V137.DOM;
+using OpenQA.Selenium.DevTools.V137.Emulation;
 using System;
 using System.Collections.Generic;
 using System.Linq;
diff --git a/Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsPerformanceExtensions.cs b/Aquality.Selenium/src/Aquality.Selenium/Browsers/DevToolsPerformanceExtensions.cs
@@ -1,4 +1,4 @@
-﻿using OpenQA.Selenium.DevTools.V135.Performance;
+﻿using OpenQA.Selenium.DevTools.V137.Performance;
 using System.Collections.Generic;
 using System.Globalization;
 using System.Linq;
diff --git a/Aquality.Selenium/tests/Aquality.Selenium.Tests/Aquality.Selenium.Tests.csproj b/Aquality.Selenium/tests/Aquality.Selenium.Tests/Aquality.Selenium.Tests.csproj
@@ -34,7 +34,7 @@
       <PrivateAssets>all</PrivateAssets>
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
     </PackageReference>
-    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.13.0" />
+    <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.0" />
   </ItemGroup>
 
   <ItemGroup>
diff --git a/Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/DevToolsEmulationTests.cs b/Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/DevToolsEmulationTests.cs
@@ -5,7 +5,7 @@
 using Aquality.Selenium.Tests.Integration.TestApp.TheInternet.Forms;
 using NUnit.Framework;
 using OpenQA.Selenium;
-using OpenQA.Selenium.DevTools.V135.Emulation;
+using OpenQA.Selenium.DevTools.V136.Emulation;
 using System;
 using System.Collections.Generic;
 
@@ -59,11 +59,11 @@ public void Should_BePossibleTo_SetAndClearDeviceMetricsOverride_WithVersionSpec
         {
             void setAction(long width, long height, bool isMobile, double scaleFactor)
             {
-                var parameters = new OpenQA.Selenium.DevTools.V134.Emulation.SetDeviceMetricsOverrideCommandSettings
+                var parameters = new OpenQA.Selenium.DevTools.V136.Emulation.SetDeviceMetricsOverrideCommandSettings
                 {
-                    DisplayFeature = new OpenQA.Selenium.DevTools.V134.Emulation.DisplayFeature
+                    DisplayFeature = new OpenQA.Selenium.DevTools.V136.Emulation.DisplayFeature
                     {
-                        Orientation = OpenQA.Selenium.DevTools.V134.Emulation.DisplayFeatureOrientationValues.Horizontal
+                        Orientation = OpenQA.Selenium.DevTools.V136.Emulation.DisplayFeatureOrientationValues.Horizontal
                     },
                     Width = width,
                     Height = height,
diff --git a/Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/ImageLocatorTests.cs b/Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/ImageLocatorTests.cs
@@ -27,8 +27,14 @@ public void Should_BePossibleTo_FindByImage()
 
             var documentByTag = AqualityServices.Get<IElementFactory>().GetLabel(By.TagName("body"), "document by tag");
             var fullThreshold = 1;
-            var documentByImage = AqualityServices.Get<IElementFactory>().GetLabel(new ByImage(documentByTag.GetElement().GetScreenshot().AsByteArray) { Threshold = fullThreshold },
+            var getDocByImage = () => AqualityServices.Get<IElementFactory>().GetLabel(new ByImage(documentByTag.GetElement().GetScreenshot().AsByteArray) { Threshold = fullThreshold },
                     "body screen");
+            ILabel documentByImage = getDocByImage();
+            AqualityServices.ConditionalWait.WaitForTrue(() =>
+            {
+                documentByImage = getDocByImage();
+                return documentByImage.State.IsDisplayed;
+            });
             Assert.That(documentByImage.State.IsDisplayed, "Should be possible to find element by document screenshot");
             Assert.That((documentByImage.Locator as ByImage)?.Threshold, Is.EqualTo(fullThreshold), "Should be possible to get ByImage threshold");
             Assert.That(documentByImage.GetElement().TagName, Is.EqualTo("body"), "Correct element must be found");
diff --git a/Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/TestApp/ManyTools/Forms/ManyToolsForm.cs b/Aquality.Selenium/tests/Aquality.Selenium.Tests/Integration/TestApp/ManyTools/Forms/ManyToolsForm.cs
@@ -10,11 +10,12 @@ namespace Aquality.Selenium.Tests.Integration.TestApp.ManyTools.Forms
 {
     internal abstract class ManyToolsForm<T> : Form where T : ManyToolsForm<T>
     {
-        private const string BaseUrl = "https://manytools.org/";
+        private const string BaseUrl = "https://manytools.org/";        
 
         protected ManyToolsForm(By locator, string name) : base(locator, name)
         {
         }
+        private IButton AgreeButton => ElementFactory.GetButton(By.XPath("//button[@mode='primary']"), "Agree");
         private ILabel ValueLabel => FormElement.FindChildElement<ILabel>(By.XPath(".//code"), Name);
 
         protected abstract string UrlPart { get; }
@@ -29,6 +30,12 @@ public T Open()
             {
                 AqualityServices.Browser.GoTo(Url);
                 AqualityServices.Browser.WaitForPageToLoad();
+                State.WaitForDisplayed();
+                if (AgreeButton.State.IsDisplayed)
+                {
+                    AgreeButton.Click();
+                    AgreeButton.State.WaitForNotDisplayed();
+                }
             }, new List<Type> { typeof(WebDriverTimeoutException) });
 
             return (T)this;

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-using OpenQA.Selenium.DevTools.V135.Performance;`
	`1`	`+using OpenQA.Selenium.DevTools.V137.Performance;`
`2`	`2`	`using System.Collections.Generic;`
`3`	`3`	`using System.Globalization;`
`4`	`4`	`using System.Linq;`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`using Aquality.Selenium.Tests.Integration.TestApp.TheInternet.Forms;`
`6`	`6`	`using NUnit.Framework;`
`7`	`7`	`using OpenQA.Selenium;`
`8`		`-using OpenQA.Selenium.DevTools.V135.Emulation;`
	`8`	`+using OpenQA.Selenium.DevTools.V136.Emulation;`
`9`	`9`	`using System;`
`10`	`10`	`using System.Collections.Generic;`
`11`	`11`
`@@ -59,11 +59,11 @@ public void Should_BePossibleTo_SetAndClearDeviceMetricsOverride_WithVersionSpec`
`59`	`59`	`{`
`60`	`60`	`void setAction(long width, long height, bool isMobile, double scaleFactor)`
`61`	`61`	`{`
`62`		`- var parameters = new OpenQA.Selenium.DevTools.V134.Emulation.SetDeviceMetricsOverrideCommandSettings`
	`62`	`+ var parameters = new OpenQA.Selenium.DevTools.V136.Emulation.SetDeviceMetricsOverrideCommandSettings`
`63`	`63`	`{`
`64`		`- DisplayFeature = new OpenQA.Selenium.DevTools.V134.Emulation.DisplayFeature`
	`64`	`+ DisplayFeature = new OpenQA.Selenium.DevTools.V136.Emulation.DisplayFeature`
`65`	`65`	`{`
`66`		`- Orientation = OpenQA.Selenium.DevTools.V134.Emulation.DisplayFeatureOrientationValues.Horizontal`
	`66`	`+ Orientation = OpenQA.Selenium.DevTools.V136.Emulation.DisplayFeatureOrientationValues.Horizontal`
`67`	`67`	`},`
`68`	`68`	`Width = width,`
`69`	`69`	`Height = height,`
Original file line number	Diff line number	Diff line change
`@@ -10,11 +10,12 @@ namespace Aquality.Selenium.Tests.Integration.TestApp.ManyTools.Forms`
`10`	`10`	`{`
`11`	`11`	`internal abstract class ManyToolsForm<T> : Form where T : ManyToolsForm<T>`
`12`	`12`	`{`
`13`		`- private const string BaseUrl = "https://manytools.org/";`
	`13`	`+ private const string BaseUrl = "https://manytools.org/";`
`14`	`14`
`15`	`15`	`protected ManyToolsForm(By locator, string name) : base(locator, name)`
`16`	`16`	`{`
`17`	`17`	`}`
	`18`	`+ private IButton AgreeButton => ElementFactory.GetButton(By.XPath("//button[@mode='primary']"), "Agree");`
`18`	`19`	`private ILabel ValueLabel => FormElement.FindChildElement<ILabel>(By.XPath(".//code"), Name);`
`19`	`20`
`20`	`21`	`protected abstract string UrlPart { get; }`
`@@ -29,6 +30,12 @@ public T Open()`
`29`	`30`	`{`
`30`	`31`	`AqualityServices.Browser.GoTo(Url);`
`31`	`32`	`AqualityServices.Browser.WaitForPageToLoad();`
	`33`	`+ State.WaitForDisplayed();`
	`34`	`+ if (AgreeButton.State.IsDisplayed)`
	`35`	`+ {`
	`36`	`+ AgreeButton.Click();`
	`37`	`+ AgreeButton.State.WaitForNotDisplayed();`
	`38`	`+ }`
`32`	`39`	`}, new List<Type> { typeof(WebDriverTimeoutException) });`
`33`	`40`
`34`	`41`	`return (T)this;`