fix: header parameter should be case insensitive (#7031)

fixes #7022

Author: soyuka

src/State/Util/ParameterParserTrait.php

@@ -46,6 +46,14 @@ private function extractParameterValues(Parameter $parameter, array $values): st
     {
         $accessors = null;
         $key = $parameter->getKey();
+        if (null === $key) {
+            throw new \RuntimeException('A Parameter should have a key.');
+        }
+
+        if ($parameter instanceof HeaderParameterInterface) {
+            $key = strtolower($key);
+        }
+
         $parsedKey = explode('[:property]', $key);
         if (isset($parsedKey[0]) && isset($values[$parsedKey[0]])) {
             $key = $parsedKey[0];

tests/Fixtures/TestBundle/ApiResource/WithParameter.php

@@ -80,6 +80,13 @@
     parameters: new Parameters([new QueryParameter(key: 'q'), new HeaderParameter(key: 'q')]),
     provider: [self::class, 'headerAndQueryProvider']
 )]
+#[GetCollection(
+    uriTemplate: 'header_required',
+    parameters: [
+        'Req' => new HeaderParameter(required: true, schema: ['type' => 'string']),
+    ],
+    provider: [self::class, 'headerProvider']
+)]
 #[QueryParameter(key: 'everywhere')]
 class WithParameter
 {
@@ -128,7 +135,7 @@ public static function restrictAccess(): void
         throw new AccessDeniedHttpException();
     }
 
-    public static function headerAndQueryProvider(Operation $operation, array $uriVariables = [], array $context = [])
+    public static function headerAndQueryProvider(Operation $operation, array $uriVariables = [], array $context = []): JsonResponse
     {
         $parameters = $operation->getParameters();
         $values = [$parameters->get('q', HeaderParameter::class)->getValue(), $parameters->get('q', QueryParameter::class)->getValue()];
@@ -155,4 +162,12 @@ public static function toInt(Parameter $parameter, array $parameters = [], array
 
         return $operation->withParameters($parameters);
     }
+
+    public static function headerProvider(Operation $operation, array $uriVariables = [], array $context = []): JsonResponse
+    {
+        $parameters = $operation->getParameters();
+        $values = [$parameters->get('Req', HeaderParameter::class)->getValue()];
+
+        return new JsonResponse($values);
+    }
 }

tests/Functional/Parameters/ParameterTest.php

@@ -85,4 +85,13 @@ public function testHeaderAndQuery(): void
             'blabla',
         ]);
     }
+
+    public function testHeaderParameterRequired(): void
+    {
+        self::createClient()->request('GET', 'header_required', ['headers' => ['req' => 'blabla']]);
+        $this->assertResponseStatusCodeSame(200);
+
+        self::createClient()->request('GET', 'header_required', ['headers' => []]);
+        $this->assertResponseStatusCodeSame(422);
+    }
 }