soyuka review

Author: JF

src/hydra/addFilters.js

@@ -6,21 +6,20 @@ export default api => {
 
   for (const resource of api.resources) {
     let promise = fetchResource(resource.url).then(response => {
-      const resourceFilters = [];
-
-      if (response.filters) {
-        for (const filter of response.filters) {
-          let property = filter.property;
+      if (!response.filters) {
+        return [];
+      }
 
-          // TODO : To prevent PropertyFilter, maybe should be handle specifically ?
-          if (property === null) {
-            continue;
-          }
+      const resourceFilters = [];
 
-          const resourceFilter = new Filter(property, filter.variable);
+      for (const filter of response.filters) {
+        let property = filter.property;
 
-          resourceFilters.push(resourceFilter);
+        if (property === null) {
+          continue;
         }
+
+        resourceFilters.push(new Filter(property, filter.variable));
       }
 
       return resourceFilters;

src/hydra/parseHydraDocumentation.test.js

@@ -558,6 +558,9 @@ const resourceCollection = `{
       {
         "property": "id",
         "variable": "id"
+      },
+      {
+        "variable": "test"
       }
     ]
   }
@@ -567,6 +570,9 @@ const filters = [
   {
     property: "id",
     variable: "id"
+  },
+  {
+    variable: "test"
   }
 ];