Skip to content

Commit 8c10099

Browse files
lukasz-antoniakabsurdfarce
authored andcommitted
Upgrade Guava to 33.3.1-jre
patch by Lukasz Antoniak; reviewed by Alexandre Dutra and Bret McGuire for CASSJAVA-53
1 parent 7689c5a commit 8c10099

File tree

4 files changed

+11
-12
lines changed

4 files changed

+11
-12
lines changed

core/src/test/java/com/datastax/dse/driver/internal/core/cql/reactive/TestSubscriber.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,8 @@ public List<T> getElements() {
8181
}
8282

8383
public void awaitTermination() {
84-
Uninterruptibles.awaitUninterruptibly(latch, 1, TimeUnit.MINUTES);
85-
if (latch.getCount() > 0) fail("subscriber not terminated");
84+
if (!Uninterruptibles.awaitUninterruptibly(latch, 1, TimeUnit.MINUTES)) {
85+
fail("subscriber not terminated");
86+
}
8687
}
8788
}

guava-shaded/pom.xml

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,6 @@
4545
<groupId>com.google.errorprone</groupId>
4646
<artifactId>error_prone_annotations</artifactId>
4747
</exclusion>
48-
<exclusion>
49-
<groupId>com.google.j2objc</groupId>
50-
<artifactId>j2objc-annotations</artifactId>
51-
</exclusion>
52-
<exclusion>
53-
<groupId>org.codehaus.mojo</groupId>
54-
<artifactId>animal-sniffer-annotations</artifactId>
55-
</exclusion>
5648
</exclusions>
5749
</dependency>
5850
<dependency>
@@ -78,6 +70,8 @@
7870
<includes>
7971
<include>org.apache.cassandra:java-driver-guava-shaded</include>
8072
<include>com.google.guava:guava</include>
73+
<include>com.google.guava:failureaccess</include>
74+
<include>com.google.j2objc:j2objc-annotations</include>
8175
</includes>
8276
</artifactSet>
8377
<relocations>

mapper-runtime/src/test/java/com/datastax/dse/driver/api/mapper/reactive/TestSubscriber.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
*/
1818
package com.datastax.dse.driver.api.mapper.reactive;
1919

20+
import static org.assertj.core.api.Fail.fail;
21+
2022
import com.datastax.oss.driver.shaded.guava.common.util.concurrent.Uninterruptibles;
2123
import edu.umd.cs.findbugs.annotations.NonNull;
2224
import edu.umd.cs.findbugs.annotations.Nullable;
@@ -70,6 +72,8 @@ public List<T> getElements() {
7072
}
7173

7274
public void awaitTermination() {
73-
Uninterruptibles.awaitUninterruptibly(latch, 1, TimeUnit.MINUTES);
75+
if (!Uninterruptibles.awaitUninterruptibly(latch, 1, TimeUnit.MINUTES)) {
76+
fail("subscriber not terminated");
77+
}
7478
}
7579
}

pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,7 @@
114114
<!-- Version of Guava used in shaded module and for integration tests. -->
115115
<groupId>com.google.guava</groupId>
116116
<artifactId>guava</artifactId>
117-
<version>25.1-jre</version>
117+
<version>33.3.1-jre</version>
118118
</dependency>
119119
<dependency>
120120
<groupId>com.typesafe</groupId>

0 commit comments

Comments
 (0)