Skip to content

Commit 63142ef

Browse files
committed
Java-3142: Corrected the test case, by adding remote nodes
1 parent bd35105 commit 63142ef

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

core/src/test/java/com/datastax/oss/driver/internal/core/loadbalancing/BasicLoadBalancingPolicyPreferredRemoteDcsTest.java

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -68,19 +68,21 @@ public class BasicLoadBalancingPolicyPreferredRemoteDcsTest
6868
public void should_prioritize_and_shuffle_replicas() {
6969
when(request.getRoutingKeyspace()).thenReturn(KEYSPACE);
7070
when(request.getRoutingKey()).thenReturn(ROUTING_KEY);
71-
when(tokenMap.getReplicas(KEYSPACE, ROUTING_KEY)).thenReturn(ImmutableSet.of(node3, node5));
71+
when(tokenMap.getReplicas(KEYSPACE, ROUTING_KEY))
72+
.thenReturn(ImmutableSet.of(node1, node2, node3, node6, node9));
7273

74+
// node 6 and 9 being in a remote DC, they don't get a boost for being a replica
7375
assertThat(policy.newQueryPlan(request, session))
7476
.containsExactly(
75-
node3, node5, node1, node2, node4, node9, node10, node6, node7, node12, node13);
76-
assertThat(policy.newQueryPlan(request, session))
77-
.containsExactly(
78-
node3, node5, node2, node4, node1, node9, node10, node6, node7, node12, node13);
77+
node1, node2, node3, node4, node5, node9, node10, node6, node7, node12, node13);
7978
assertThat(policy.newQueryPlan(request, session))
8079
.containsExactly(
81-
node3, node5, node4, node1, node2, node9, node10, node6, node7, node12, node13);
80+
node1, node2, node3, node5, node4, node9, node10, node6, node7, node12, node13);
8281

83-
verify(policy, times(12)).shuffleHead(any(), eq(2));
82+
// should shuffle replicas
83+
verify(policy, times(2)).shuffleHead(any(), eq(3));
84+
// should shuffle remote nodes
85+
verify(policy, times(6)).shuffleHead(any(), eq(2));
8486
// No power of two choices with only two replicas
8587
verify(session, never()).getPools();
8688
}

0 commit comments

Comments
 (0)