From 7f020601bc39c6c70d60677fed8ca3cc0d41dce8 Mon Sep 17 00:00:00 2001 From: Dmitry Gorelenkov Date: Thu, 12 Mar 2020 00:54:18 +0100 Subject: [PATCH 1/3] fix(web-server): since node 12 there is no util.puts see https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V12.md and https://github.com/nodejs/node/pull/25377 --- testapp/scripts/web-server.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/testapp/scripts/web-server.js b/testapp/scripts/web-server.js index 7ded03d89..dc54b162e 100755 --- a/testapp/scripts/web-server.js +++ b/testapp/scripts/web-server.js @@ -3,7 +3,6 @@ var express = require('express'); var bodyParser = require('body-parser') var optimist = require('optimist'); -var util = require('util'); var path = require('path'); var env = require('../../spec/environment.js'); @@ -27,7 +26,7 @@ var main = function() { testApp.use(bodyParser.json()); testApp.use(testMiddleware); testApp.listen(port); - util.puts(["Starting express web server in", testAppDir ,"on port", port]. + console.log(["Starting express web server in", testAppDir ,"on port", port]. join(" ")); }; From 7773107f8f38783ece575d8f6e8b0b02afe86ba2 Mon Sep 17 00:00:00 2001 From: Dmitry Gorelenkov Date: Thu, 12 Mar 2020 01:00:12 +0100 Subject: [PATCH 2/3] chore(web-server): jshint cosmetic fixes --- testapp/scripts/web-server.js | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/testapp/scripts/web-server.js b/testapp/scripts/web-server.js index dc54b162e..57fd79b41 100755 --- a/testapp/scripts/web-server.js +++ b/testapp/scripts/web-server.js @@ -1,7 +1,7 @@ #!/usr/bin/env node var express = require('express'); -var bodyParser = require('body-parser') +var bodyParser = require('body-parser'); var optimist = require('optimist'); var path = require('path'); var env = require('../../spec/environment.js'); @@ -54,14 +54,14 @@ var testMiddleware = function(req, res, next) { res.status(400).send('must specify query'); } } else if (req.method === 'POST') { - if (req.body.key == 'newChatMessage') { - if (!storage['chatMessages']) { - storage['chatMessages'] = []; + if (req.body.key === 'newChatMessage') { + if (!storage.chatMessages) { + storage.chatMessages = []; } - storage['chatMessages'].push(req.body.value); + storage.chatMessages.push(req.body.value); res.sendStatus(200); - } else if (req.body.key == 'clearChatMessages') { - storage['chatMessages'] = []; + } else if (req.body.key === 'clearChatMessages') { + storage.chatMessages = []; res.sendStatus(200); } else { res.status(400).send('Unknown command'); From 8c41c2b547bb22c3d0860507b58dd5f738d56217 Mon Sep 17 00:00:00 2001 From: Dmitry Gorelenkov Date: Thu, 12 Mar 2020 16:22:45 +0100 Subject: [PATCH 3/3] chore(web-server): simplify console.log arguments --- testapp/scripts/web-server.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/testapp/scripts/web-server.js b/testapp/scripts/web-server.js index 57fd79b41..7e59d7e7c 100755 --- a/testapp/scripts/web-server.js +++ b/testapp/scripts/web-server.js @@ -26,8 +26,7 @@ var main = function() { testApp.use(bodyParser.json()); testApp.use(testMiddleware); testApp.listen(port); - console.log(["Starting express web server in", testAppDir ,"on port", port]. - join(" ")); + console.log("Starting express web server in", testAppDir ,"on port", port); }; var storage = {};