From 93f4c95a63a1c355bb341461eac07307d49ac16a Mon Sep 17 00:00:00 2001 From: Craig Nishina Date: Fri, 22 Mar 2019 21:57:02 -0700 Subject: [PATCH] chore(tests): circleci - chrome 69 requires chromdriver to 2.44 - Move circle.yml file to .circleci/config.yml to satisfy circleci warnings. - The browser in circle is version 69. The browser requires chromedriver 2.44. --- circle.yml => .circleci/config.yml | 4 ++-- gulpfile.js | 6 ++++-- 2 files changed, 6 insertions(+), 4 deletions(-) rename circle.yml => .circleci/config.yml (93%) diff --git a/circle.yml b/.circleci/config.yml similarity index 93% rename from circle.yml rename to .circleci/config.yml index 7c1bb9179..fc9077ded 100644 --- a/circle.yml +++ b/.circleci/config.yml @@ -54,8 +54,8 @@ jobs: name: Selenium Start background: true command: | - ./node_modules/.bin/webdriver-manager update - ./node_modules/.bin/webdriver-manager start + ./node_modules/.bin/webdriver-manager update --versions.chrome=2.44 + ./node_modules/.bin/webdriver-manager start --versions.chrome=2.44 - run: name: TestApp Start diff --git a/gulpfile.js b/gulpfile.js index c3cb36fe2..be0b7b5b6 100644 --- a/gulpfile.js +++ b/gulpfile.js @@ -40,7 +40,8 @@ gulp.task('tslint', () => { gulp.task('format:enforce', () => { return gulp.src(['lib/**/*.ts']) - .pipe(format.checkFormat('file', clangFormat, {verbose: true, fail: true})); + .pipe(format.checkFormat('file', clangFormat, + {verbose: true, fail: true})); }); gulp.task('lint', gulp.series('tslint', 'format:enforce')); @@ -71,7 +72,8 @@ gulp.task('built:copy:typings', () => { }); gulp.task('webdriver:update', (done) => { - runSpawn(done, 'node', ['bin/webdriver-manager', 'update']); + runSpawn(done, 'node', ['bin/webdriver-manager', 'update', + '--versions.chrome=2.44']); }); gulp.task('format', () => {